Skip to content

Commit f4dcc77

Browse files
committed
Delete inert report.requiredSections from director packages
Every director declared report.requiredSections, but nothing read it except its own definition sites and a test assertion checking it matched a hardcoded list. It never drove hasReportEnvelope() (which independently hardcodes the four headings in report.ts) and was never rendered into any prompt — the real enforcement is buildSubAgentReportContract(), spliced unconditionally into the base prompt. CL-6946 will replace the whole four-heading envelope with a schema-validated submit_result, so building this into a real mechanism now would be thrown away; delete the dead config instead. Added a test pinning that the one real mechanism stays internally consistent: buildSubAgentReportContract()'s rendered headings satisfy hasReportEnvelope().
1 parent d1594a2 commit f4dcc77

36 files changed

Lines changed: 14 additions & 145 deletions

src/agent/directors/brand-reviewer/package.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,6 @@ describe("brandReviewerPackage", () => {
3333
expect(brandReviewerPackage.systemPrompt).not.toMatch(/authz/i);
3434
});
3535

36-
test("report.requiredSections covers the leaf envelope", () => {
37-
const sections = brandReviewerPackage.report.requiredSections;
38-
expect(sections).toContain("Summary");
39-
expect(sections).toContain("Findings");
40-
expect(sections).toContain("Blockers");
41-
expect(sections).toContain("Paths");
42-
});
43-
4436
test("modelRole is docs", () => {
4537
expect(brandReviewerPackage.modelRole).toBe("docs");
4638
});

src/agent/directors/brand-reviewer/package.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export const brandReviewerPackage: DirectorPackage = {
1717
tools: { allow: DOCS_TOOLS },
1818
spawn: { maySpawn: false },
1919
nudge: { maxTurns: 40 },
20-
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
2120
modelRole: "docs",
2221
systemPrompt: `You are BrandReviewerDirector, a specialist in Corbits Code.
2322

src/agent/directors/bruckheimer/package.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ describe("bruckheimerPackage", () => {
2929
expect(bruckheimerPackage.writePaths).toBeUndefined();
3030
});
3131

32-
test("report requires envelope sections", () => {
33-
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
34-
expect(bruckheimerPackage.report.requiredSections).toContain(section);
35-
}
36-
});
37-
3832
test("modelRole is docs", () => {
3933
expect(bruckheimerPackage.modelRole).toBe("docs");
4034
});

src/agent/directors/bruckheimer/package.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export const bruckheimerPackage: DirectorPackage = {
1818
tools: { allow: DOCS_TOOLS },
1919
spawn: { maySpawn: false },
2020
nudge: { maxTurns: 40 },
21-
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
2221
modelRole: "docs",
2322
systemPrompt: `You are BruckheimerDirector, a specialist in Corbits Code.
2423

src/agent/directors/build/package.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,6 @@ describe("buildDirectorPackage", () => {
2727
expect(allow).toContain("apply_patch");
2828
});
2929

30-
test("report.requiredSections includes Summary, Findings, Blockers, Paths", () => {
31-
const sections = buildDirectorPackage.report.requiredSections;
32-
expect(sections).toContain("Summary");
33-
expect(sections).toContain("Findings");
34-
expect(sections).toContain("Blockers");
35-
expect(sections).toContain("Paths");
36-
});
37-
3830
test("modelRole is implement", () => {
3931
expect(buildDirectorPackage.modelRole).toBe("implement");
4032
});

src/agent/directors/build/package.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export const buildDirectorPackage: DirectorPackage = {
1616
tools: { allow: BUILD_TOOLS },
1717
spawn: { maySpawn: false },
1818
nudge: { maxTurns: 60 },
19-
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
2019
modelRole: "implement",
2120
systemPrompt: `You are BuildDirector, a specialist in Corbits Code.
2221

src/agent/directors/critique/package.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,6 @@ describe("critiquePackage", () => {
6464
expect(allow).not.toContain("delete_file");
6565
});
6666

67-
test("report.requiredSections covers the leaf envelope", () => {
68-
const sections = critiquePackage.report.requiredSections;
69-
expect(sections).toContain("Summary");
70-
expect(sections).toContain("Findings");
71-
expect(sections).toContain("Blockers");
72-
expect(sections).toContain("Paths");
73-
});
74-
7567
test("modelRole is review", () => {
7668
expect(critiquePackage.modelRole).toBe("review");
7769
});

src/agent/directors/critique/package.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export const critiquePackage: DirectorPackage = {
2020
tools: { allow: REVIEW_TOOLS },
2121
spawn: { maySpawn: false },
2222
nudge: { maxTurns: 45 },
23-
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
2423
modelRole: "review",
2524
systemPrompt: `You are CritiqueDirector, a specialist in Corbits Code.
2625

src/agent/directors/draper/package.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,6 @@ describe("draperPackage", () => {
2828
expect(allow).not.toContain("delete_file");
2929
});
3030

31-
test("report.requiredSections covers the leaf envelope", () => {
32-
const sections = draperPackage.report.requiredSections;
33-
expect(sections).toContain("Summary");
34-
expect(sections).toContain("Findings");
35-
expect(sections).toContain("Blockers");
36-
expect(sections).toContain("Paths");
37-
});
38-
3931
test("modelRole is review", () => {
4032
expect(draperPackage.modelRole).toBe("review");
4133
});

src/agent/directors/draper/package.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export const draperPackage: DirectorPackage = {
1919
tools: { allow: REVIEW_TOOLS },
2020
spawn: { maySpawn: false },
2121
nudge: { maxTurns: 40 },
22-
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
2322
modelRole: "review",
2423
systemPrompt: `You are DraperDirector, a specialist in Corbits Code.
2524

0 commit comments

Comments
 (0)