diff --git a/apps/hub/package.json b/apps/hub/package.json index 9ce5eee2..d99de299 100644 --- a/apps/hub/package.json +++ b/apps/hub/package.json @@ -47,6 +47,7 @@ "@corbits/tasks": "workspace:*", "@corbits/tool-registry-publish": "workspace:*", "@corbits/turn-artifacts": "workspace:*", + "@corbits/workflow-deploy-source": "workspace:*", "@corbits/url-path": "workspace:*", "@corbits/webhook-triggers": "workspace:*", "@corbits/workflow-catalog": "workspace:*", diff --git a/apps/hub/src/index.ts b/apps/hub/src/index.ts index 9b2cc371..74391c50 100644 --- a/apps/hub/src/index.ts +++ b/apps/hub/src/index.ts @@ -206,6 +206,10 @@ import { createRunKeyHistoryRoutes, lookupRunKeyHistoryReconnectKey, } from "@corbits/run-key-history"; +import { + createDrizzleWorkflowDeploySourceStore, + withDeploySourceRecording, +} from "@corbits/workflow-deploy-source"; import { createMyraAgentDefinitionDrafting, createPlannerRoutes, @@ -870,17 +874,28 @@ export async function createHub(config: HubConfig) { getSigningPublicKey: agentRepoStore.getSigningPublicKey, repoStore: launchCaches.repoStore, }; - const sessionService = createSessionService({ - sidecarRouter, - agentRepoStore: launchAgentRepoStore, - assetService: launchCaches.assetService, - db, - toolPackageRegistries: { - httpRegistries: REGISTRIES, - defaultRegistry: "npmjs", - scopeRouting: [{ scope: "@corbits", registry: CORBITS_TOOLS_REGISTRY }], - }, - }); + // Shared placement's code-sourced deploys previously left their + // `WorkflowDefinitionSource` durable nowhere on the hub -- only on the + // sidecar's local `deployment.json` (CL-6581). Wrapping the two deploy + // methods here, at the composition root, records that source into + // Postgres on every deploy without touching vendored + // `session-service.ts`; exclusive placement already persists its own via + // `workflow_run_launch_spec`, untouched. + const workflowDeploySourceStore = createDrizzleWorkflowDeploySourceStore(db); + const sessionService = withDeploySourceRecording( + createSessionService({ + sidecarRouter, + agentRepoStore: launchAgentRepoStore, + assetService: launchCaches.assetService, + db, + toolPackageRegistries: { + httpRegistries: REGISTRIES, + defaultRegistry: "npmjs", + scopeRouting: [{ scope: "@corbits", registry: CORBITS_TOOLS_REGISTRY }], + }, + }), + workflowDeploySourceStore, + ); // Provisioner plugins are injected at the application composition // boundary, mirroring @intx/hub-sessions's own reference wiring: the // registry always exists, but ships with no provisioners (and no diff --git a/bun.lock b/bun.lock index f0522267..9904bf04 100644 --- a/bun.lock +++ b/bun.lock @@ -68,6 +68,7 @@ "@corbits/url-path": "workspace:*", "@corbits/webhook-triggers": "workspace:*", "@corbits/workflow-catalog": "workspace:*", + "@corbits/workflow-deploy-source": "workspace:*", "@corbits/workflow-freeze": "workspace:*", "@corbits/workflow-source": "workspace:*", "@intx/authz": "0.3.0", @@ -898,7 +899,7 @@ }, "packages/jimmy-agent": { "name": "@corbits/jimmy-agent", - "version": "0.0.1", + "version": "0.0.2", "dependencies": { "@intx/agent": "0.3.0", "@intx/types": "0.3.0", @@ -1189,7 +1190,7 @@ }, "packages/scout-agent": { "name": "@corbits/scout-agent", - "version": "0.0.1", + "version": "0.0.2", "dependencies": { "@intx/agent": "0.3.0", "@intx/types": "0.3.0", @@ -1526,6 +1527,22 @@ "typescript": "catalog:", }, }, + "packages/workflow-deploy-source": { + "name": "@corbits/workflow-deploy-source", + "version": "0.0.1", + "dependencies": { + "@intx/hub-sessions": "workspace:*", + "@intx/log": "0.3.0", + "@intx/types": "0.3.0", + "arktype": "catalog:", + "drizzle-orm": "catalog:", + "postgres": "catalog:", + }, + "devDependencies": { + "@types/bun": "catalog:", + "typescript": "catalog:", + }, + }, "packages/workflow-freeze": { "name": "@corbits/workflow-freeze", "version": "0.0.1", @@ -2226,6 +2243,8 @@ "@corbits/workflow-catalog": ["@corbits/workflow-catalog@workspace:packages/workflow-catalog"], + "@corbits/workflow-deploy-source": ["@corbits/workflow-deploy-source@workspace:packages/workflow-deploy-source"], + "@corbits/workflow-freeze": ["@corbits/workflow-freeze@workspace:packages/workflow-freeze"], "@corbits/workflow-host-actions": ["@corbits/workflow-host-actions@workspace:packages/workflow-host-actions"], diff --git a/packages/workflow-deploy-source/LICENSE b/packages/workflow-deploy-source/LICENSE new file mode 100644 index 00000000..c6487f4f --- /dev/null +++ b/packages/workflow-deploy-source/LICENSE @@ -0,0 +1,176 @@ +GNU LESSER GENERAL PUBLIC LICENSE + +Version 2.1, February 1999 + +Copyright (C) 1991, 1999 Free Software Foundation, Inc. +51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. + +[This is the first released version of the Lesser GPL. It also counts as the successor of the GNU Library Public License, version 2, hence the version number 2.1.] + +Preamble + +The licenses for most software are designed to take away your freedom to share and change it. By contrast, the GNU General Public Licenses are intended to guarantee your freedom to share and change free software--to make sure the software is free for all its users. + +This license, the Lesser General Public License, applies to some specially designated software packages--typically libraries--of the Free Software Foundation and other authors who decide to use it. You can use it too, but we suggest you first think carefully about whether this license or the ordinary General Public License is the better strategy to use in any particular case, based on the explanations below. + +When we speak of free software, we are referring to freedom of use, not price. Our General Public Licenses are designed to make sure that you have the freedom to distribute copies of free software (and charge for this service if you wish); that you receive source code or can get it if you want it; that you can change the software and use pieces of it in new free programs; and that you are informed that you can do these things. + +To protect your rights, we need to make restrictions that forbid distributors to deny you these rights or to ask you to surrender these rights. These restrictions translate to certain responsibilities for you if you distribute copies of the library or if you modify it. + +For example, if you distribute copies of the library, whether gratis or for a fee, you must give the recipients all the rights that we gave you. You must make sure that they, too, receive or can get the source code. If you link other code with the library, you must provide complete object files to the recipients, so that they can relink them with the library after making changes to the library and recompiling it. And you must show them these terms so they know their rights. + +We protect your rights with a two-step method: (1) we copyright the library, and (2) we offer you this license, which gives you legal permission to copy, distribute and/or modify the library. + +To protect each distributor, we want to make it very clear that there is no warranty for the free library. Also, if the library is modified by someone else and passed on, the recipients should know that what they have is not the original version, so that the original author's reputation will not be affected by problems that might be introduced by others. + +Finally, software patents pose a constant threat to the existence of any free program. We wish to make sure that a company cannot effectively restrict the users of a free program by obtaining a restrictive license from a patent holder. Therefore, we insist that any patent license obtained for a version of the library must be consistent with the full freedom of use specified in this license. + +Most GNU software, including some libraries, is covered by the ordinary GNU General Public License. This license, the GNU Lesser General Public License, applies to certain designated libraries, and is quite different from the ordinary General Public License. We use this license for certain libraries in order to permit linking those libraries into non-free programs. + +When a program is linked with a library, whether statically or using a shared library, the combination of the two is legally speaking a combined work, a derivative of the original library. The ordinary General Public License therefore permits such linking only if the entire combination fits its criteria of freedom. The Lesser General Public License permits more lax criteria for linking other code with the library. + +We call this license the "Lesser" General Public License because it does Less to protect the user's freedom than the ordinary General Public License. It also provides other free software developers Less of an advantage over competing non-free programs. These disadvantages are the reason we use the ordinary General Public License for many libraries. However, the Lesser license provides advantages in certain special circumstances. + +For example, on rare occasions, there may be a special need to encourage the widest possible use of a certain library, so that it becomes a de-facto standard. To achieve this, non-free programs must be allowed to use the library. A more frequent case is that a free library does the same job as widely used non-free libraries. In this case, there is little to gain by limiting the free library to free software only, so we use the Lesser General Public License. + +In other cases, permission to use a particular library in non-free programs enables a greater number of people to use a large body of free software. For example, permission to use the GNU C Library in non-free programs enables many more people to use the whole GNU operating system, as well as its variant, the GNU/Linux operating system. + +Although the Lesser General Public License is Less protective of the users' freedom, it does ensure that the user of a program that is linked with the Library has the freedom and the wherewithal to run that program using a modified version of the Library. + +The precise terms and conditions for copying, distribution and modification follow. Pay close attention to the difference between a "work based on the library" and a "work that uses the library". The former contains code derived from the library, whereas the latter must be combined with the library in order to run. + +GNU LESSER GENERAL PUBLIC LICENSE +TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION + +0. This License Agreement applies to any software library or other program which contains a notice placed by the copyright holder or other authorized party saying it may be distributed under the terms of this Lesser General Public License (also called "this License"). Each licensee is addressed as "you". + +A "library" means a collection of software functions and/or data prepared so as to be conveniently linked with application programs (which use some of those functions and data) to form executables. + +The "Library", below, refers to any such software library or work which has been distributed under these terms. A "work based on the Library" means either the Library or any derivative work under copyright law: that is to say, a work containing the Library or a portion of it, either verbatim or with modifications and/or translated straightforwardly into another language. (Hereinafter, translation is included without limitation in the term "modification".) + +"Source code" for a work means the preferred form of the work for making modifications to it. For a library, complete source code means all the source code for all modules it contains, plus any associated interface definition files, plus the scripts used to control compilation and installation of the library. + +Activities other than copying, distribution and modification are not covered by this License; they are outside its scope. The act of running a program using the Library is not restricted, and output from such a program is covered only if its contents constitute a work based on the Library (independent of the use of the Library in a tool for writing it). Whether that is true depends on what the Library does and what the program that uses the Library does. + +1. You may copy and distribute verbatim copies of the Library's complete source code as you receive it, in any medium, provided that you conspicuously and appropriately publish on each copy an appropriate copyright notice and disclaimer of warranty; keep intact all the notices that refer to this License and to the absence of any warranty; and distribute a copy of this License along with the Library. + +You may charge a fee for the physical act of transferring a copy, and you may at your option offer warranty protection in exchange for a fee. + +2. You may modify your copy or copies of the Library or any portion of it, thus forming a work based on the Library, and copy and distribute such modifications or work under the terms of Section 1 above, provided that you also meet all of these conditions: + + a) The modified work must itself be a software library. + + b) You must cause the files modified to carry prominent notices stating that you changed the files and the date of any change. + + c) You must cause the whole of the work to be licensed at no charge to all third parties under the terms of this License. + + d) If a facility in the modified Library refers to a function or a table of data to be supplied by an application program that uses the facility, other than as an argument passed when the facility is invoked, then you must make a good faith effort to ensure that, in the event an application does not supply such function or table, the facility still operates, and performs whatever part of its purpose remains meaningful. + +(For example, a function in a library to compute square roots has a purpose that is entirely well-defined independent of the application. Therefore, Subsection 2d requires that any application-supplied function or table used by this function must be optional: if the application does not supply it, the square root function must still compute square roots.) + +These requirements apply to the modified work as a whole. If identifiable sections of that work are not derived from the Library, and can be reasonably considered independent and separate works in themselves, then this License, and its terms, do not apply to those sections when you distribute them as separate works. But when you distribute the same sections as part of a whole which is a work based on the Library, the distribution of the whole must be on the terms of this License, whose permissions for other licensees extend to the entire whole, and thus to each and every part regardless of who wrote it. + +Thus, it is not the intent of this section to claim rights or contest your rights to work written entirely by you; rather, the intent is to exercise the right to control the distribution of derivative or collective works based on the Library. + +In addition, mere aggregation of another work not based on the Library with the Library (or with a work based on the Library) on a volume of a storage or distribution medium does not bring the other work under the scope of this License. + +3. You may opt to apply the terms of the ordinary GNU General Public License instead of this License to a given copy of the Library. To do this, you must alter all the notices that refer to this License, so that they refer to the ordinary GNU General Public License, version 2, instead of to this License. (If a newer version than version 2 of the ordinary GNU General Public License has appeared, then you can specify that version instead if you wish.) Do not make any other change in these notices. + +Once this change is made in a given copy, it is irreversible for that copy, so the ordinary GNU General Public License applies to all subsequent copies and derivative works made from that copy. + +This option is useful when you wish to copy part of the code of the Library into a program that is not a library. + +4. You may copy and distribute the Library (or a portion or derivative of it, under Section 2) in object code or executable form under the terms of Sections 1 and 2 above provided that you accompany it with the complete corresponding machine-readable source code, which must be distributed under the terms of Sections 1 and 2 above on a medium customarily used for software interchange. + +If distribution of object code is made by offering access to copy from a designated place, then offering equivalent access to copy the source code from the same place satisfies the requirement to distribute the source code, even though third parties are not compelled to copy the source along with the object code. + +5. A program that contains no derivative of any portion of the Library, but is designed to work with the Library by being compiled or linked with it, is called a "work that uses the Library". Such a work, in isolation, is not a derivative work of the Library, and therefore falls outside the scope of this License. + +However, linking a "work that uses the Library" with the Library creates an executable that is a derivative of the Library (because it contains portions of the Library), rather than a "work that uses the library". The executable is therefore covered by this License. Section 6 states terms for distribution of such executables. + +When a "work that uses the Library" uses material from a header file that is part of the Library, the object code for the work may be a derivative work of the Library even though the source code is not. Whether this is true is especially significant if the work can be linked without the Library, or if the work is itself a library. The threshold for this to be true is not precisely defined by law. + +If such an object file uses only numerical parameters, data structure layouts and accessors, and small macros and small inline functions (ten lines or less in length), then the use of the object file is unrestricted, regardless of whether it is legally a derivative work. (Executables containing this object code plus portions of the Library will still fall under Section 6.) + +Otherwise, if the work is a derivative of the Library, you may distribute the object code for the work under the terms of Section 6. Any executables containing that work also fall under Section 6, whether or not they are linked directly with the Library itself. + +6. As an exception to the Sections above, you may also combine or link a "work that uses the Library" with the Library to produce a work containing portions of the Library, and distribute that work under terms of your choice, provided that the terms permit modification of the work for the customer's own use and reverse engineering for debugging such modifications. + +You must give prominent notice with each copy of the work that the Library is used in it and that the Library and its use are covered by this License. You must supply a copy of this License. If the work during execution displays copyright notices, you must include the copyright notice for the Library among them, as well as a reference directing the user to the copy of this License. Also, you must do one of these things: + + a) Accompany the work with the complete corresponding machine-readable source code for the Library including whatever changes were used in the work (which must be distributed under Sections 1 and 2 above); and, if the work is an executable linked with the Library, with the complete machine-readable "work that uses the Library", as object code and/or source code, so that the user can modify the Library and then relink to produce a modified executable containing the modified Library. (It is understood that the user who changes the contents of definitions files in the Library will not necessarily be able to recompile the application to use the modified definitions.) + + b) Use a suitable shared library mechanism for linking with the Library. A suitable mechanism is one that (1) uses at run time a copy of the library already present on the user's computer system, rather than copying library functions into the executable, and (2) will operate properly with a modified version of the library, if the user installs one, as long as the modified version is interface-compatible with the version that the work was made with. + + c) Accompany the work with a written offer, valid for at least three years, to give the same user the materials specified in Subsection 6a, above, for a charge no more than the cost of performing this distribution. + + d) If distribution of the work is made by offering access to copy from a designated place, offer equivalent access to copy the above specified materials from the same place. + + e) Verify that the user has already received a copy of these materials or that you have already sent this user a copy. + +For an executable, the required form of the "work that uses the Library" must include any data and utility programs needed for reproducing the executable from it. However, as a special exception, the materials to be distributed need not include anything that is normally distributed (in either source or binary form) with the major components (compiler, kernel, and so on) of the operating system on which the executable runs, unless that component itself accompanies the executable. + +It may happen that this requirement contradicts the license restrictions of other proprietary libraries that do not normally accompany the operating system. Such a contradiction means you cannot use both them and the Library together in an executable that you distribute. + +7. You may place library facilities that are a work based on the Library side-by-side in a single library together with other library facilities not covered by this License, and distribute such a combined library, provided that the separate distribution of the work based on the Library and of the other library facilities is otherwise permitted, and provided that you do these two things: + + a) Accompany the combined library with a copy of the same work based on the Library, uncombined with any other library facilities. This must be distributed under the terms of the Sections above. + + b) Give prominent notice with the combined library of the fact that part of it is a work based on the Library, and explaining where to find the accompanying uncombined form of the same work. + +8. You may not copy, modify, sublicense, link with, or distribute the Library except as expressly provided under this License. Any attempt otherwise to copy, modify, sublicense, link with, or distribute the Library is void, and will automatically terminate your rights under this License. However, parties who have received copies, or rights, from you under this License will not have their licenses terminated so long as such parties remain in full compliance. + +9. You are not required to accept this License, since you have not signed it. However, nothing else grants you permission to modify or distribute the Library or its derivative works. These actions are prohibited by law if you do not accept this License. Therefore, by modifying or distributing the Library (or any work based on the Library), you indicate your acceptance of this License to do so, and all its terms and conditions for copying, distributing or modifying the Library or works based on it. + +10. Each time you redistribute the Library (or any work based on the Library), the recipient automatically receives a license from the original licensor to copy, distribute, link with or modify the Library subject to these terms and conditions. You may not impose any further restrictions on the recipients' exercise of the rights granted herein. You are not responsible for enforcing compliance by third parties with this License. + +11. If, as a consequence of a court judgment or allegation of patent infringement or for any other reason (not limited to patent issues), conditions are imposed on you (whether by court order, agreement or otherwise) that contradict the conditions of this License, they do not excuse you from the conditions of this License. If you cannot distribute so as to satisfy simultaneously your obligations under this License and any other pertinent obligations, then as a consequence you may not distribute the Library at all. For example, if a patent license would not permit royalty-free redistribution of the Library by all those who receive copies directly or indirectly through you, then the only way you could satisfy both it and this License would be to refrain entirely from distribution of the Library. + +If any portion of this section is held invalid or unenforceable under any particular circumstance, the balance of the section is intended to apply, and the section as a whole is intended to apply in other circumstances. + +It is not the purpose of this section to induce you to infringe any patents or other property right claims or to contest validity of any such claims; this section has the sole purpose of protecting the integrity of the free software distribution system which is implemented by public license practices. Many people have made generous contributions to the wide range of software distributed through that system in reliance on consistent application of that system; it is up to the author/donor to decide if he or she is willing to distribute software through any other system and a licensee cannot impose that choice. + +This section is intended to make thoroughly clear what is believed to be a consequence of the rest of this License. + +12. If the distribution and/or use of the Library is restricted in certain countries either by patents or by copyrighted interfaces, the original copyright holder who places the Library under this License may add an explicit geographical distribution limitation excluding those countries, so that distribution is permitted only in or among countries not thus excluded. In such case, this License incorporates the limitation as if written in the body of this License. + +13. The Free Software Foundation may publish revised and/or new versions of the Lesser General Public License from time to time. Such new versions will be similar in spirit to the present version, but may differ in detail to address new problems or concerns. + +Each version is given a distinguishing version number. If the Library specifies a version number of this License which applies to it and "any later version", you have the option of following the terms and conditions either of that version or of any later version published by the Free Software Foundation. If the Library does not specify a license version number, you may choose any version ever published by the Free Software Foundation. + +14. If you wish to incorporate parts of the Library into other free programs whose distribution conditions are incompatible with these, write to the author to ask for permission. For software which is copyrighted by the Free Software Foundation, write to the Free Software Foundation; we sometimes make exceptions for this. Our decision will be guided by the two goals of preserving the free status of all derivatives of our free software and of promoting the sharing and reuse of software generally. + +NO WARRANTY + +15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE LIBRARY IS WITH YOU. SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION. + +16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE LIBRARY (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. + +END OF TERMS AND CONDITIONS + +How to Apply These Terms to Your New Libraries + +If you develop a new library, and you want it to be of the greatest possible use to the public, we recommend making it free software that everyone can redistribute and change. You can do so by permitting redistribution under these terms (or, alternatively, under the terms of the ordinary General Public License). + +To apply these terms, attach the following notices to the library. It is safest to attach them to the start of each source file to most effectively convey the exclusion of warranty; and each file should have at least the "copyright" line and a pointer to where the full notice is found. + + one line to give the library's name and an idea of what it does. + Copyright (C) year name of author + + This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Also add information on how to contact you by electronic and paper mail. + +You should also get your employer (if you work as a programmer) or your school, if any, to sign a "copyright disclaimer" for the library, if necessary. Here is a sample; alter the names: + +Yoyodyne, Inc., hereby disclaims all copyright interest in +the library `Frob' (a library for tweaking knobs) written +by James Random Hacker. + +signature of Ty Coon, 1 April 1990 +Ty Coon, President of Vice +That's all there is to it! diff --git a/packages/workflow-deploy-source/package.json b/packages/workflow-deploy-source/package.json new file mode 100644 index 00000000..56a49989 --- /dev/null +++ b/packages/workflow-deploy-source/package.json @@ -0,0 +1,28 @@ +{ + "name": "@corbits/workflow-deploy-source", + "private": true, + "description": "Durable, hub-side record of a native workflow's deploy source (WorkflowDefinitionSource: an asset commit or a registry name@range pin), for every sidecar placement — so a deployment can be recreated from Postgres alone, with nothing owed to the sidecar's local disk.", + "version": "0.0.1", + "license": "LGPL-2.1-or-later", + "type": "module", + "exports": { + ".": "./src/index.ts", + "./migrations": "./src/migrations.ts" + }, + "scripts": { + "typecheck": "tsc --noEmit", + "test": "bun test" + }, + "dependencies": { + "@intx/hub-sessions": "workspace:*", + "@intx/log": "0.3.0", + "@intx/types": "0.3.0", + "arktype": "catalog:", + "drizzle-orm": "catalog:", + "postgres": "catalog:" + }, + "devDependencies": { + "@types/bun": "catalog:", + "typescript": "catalog:" + } +} diff --git a/packages/workflow-deploy-source/src/index.ts b/packages/workflow-deploy-source/src/index.ts new file mode 100644 index 00000000..9f45e7dc --- /dev/null +++ b/packages/workflow-deploy-source/src/index.ts @@ -0,0 +1,12 @@ +export { + createDrizzleWorkflowDeploySourceStore, + type WorkflowDeploySourceDb, + type WorkflowDeploySourceRecord, + type WorkflowDeploySourceStore, +} from "./store"; +export { workflowDeploySource, workflowDeploySourceSchema } from "./schema"; +export type { WorkflowDeploySourceRow } from "./schema"; +export { + withDeploySourceRecording, + type DeployWorkflowDeployer, +} from "./record-on-deploy"; diff --git a/packages/workflow-deploy-source/src/migrations.ts b/packages/workflow-deploy-source/src/migrations.ts new file mode 100644 index 00000000..c5739b6f --- /dev/null +++ b/packages/workflow-deploy-source/src/migrations.ts @@ -0,0 +1,99 @@ +// Package-owned migrations for @corbits/workflow-deploy-source. +// Bookkeeping uses its own ledger table so the package can be extracted +// without disentangling history from the platform drizzle journal. The +// table this package owns lives in its own `workflow_deploy_source` +// Postgres schema, never `public`; see docs/package-migrations.md. +import postgres from "postgres"; + +export interface WorkflowDeploySourceMigration { + name: string; + sql: string; +} + +const SCHEMA = "workflow_deploy_source"; + +export const workflowDeploySourceMigrations: readonly WorkflowDeploySourceMigration[] = + [ + { + name: "0001_workflow_deploy_source", + sql: ` + CREATE TABLE IF NOT EXISTS "workflow_deploy_source"."workflow_deploy_source" ( + "anchor_run_id" text PRIMARY KEY, + "tenant_id" text NOT NULL, + "deployment_domain" text NOT NULL, + "source" jsonb NOT NULL, + "entry" text NOT NULL, + "pin" text, + "definition_asset_id" text NOT NULL, + "source_ref" text, + "source_authority_principal_id" text NOT NULL, + "recorded_at" timestamptz NOT NULL DEFAULT now() + ); + CREATE INDEX IF NOT EXISTS "workflow_deploy_source_tenant_idx" + ON "workflow_deploy_source"."workflow_deploy_source" ("tenant_id"); + `, + }, + ]; + +function quoteIdentifier(name: string): string { + return `"${name.replace(/"/g, '""')}"`; +} + +function quoteQualified(schema: string, name: string): string { + return `${quoteIdentifier(schema)}.${quoteIdentifier(name)}`; +} + +const LEDGER_TABLE = "workflow_deploy_source_migrations"; + +export interface ApplyWorkflowDeploySourceMigrationsReport { + applied: string[]; + alreadyApplied: string[]; +} + +export async function applyWorkflowDeploySourceMigrations( + databaseUrl: string, +): Promise { + const sql = postgres(databaseUrl, { max: 1, onnotice: () => undefined }); + try { + await sql.unsafe(`CREATE SCHEMA IF NOT EXISTS ${quoteIdentifier(SCHEMA)}`); + + await sql.unsafe( + `CREATE TABLE IF NOT EXISTS ${quoteQualified(SCHEMA, LEDGER_TABLE)} (` + + `name text PRIMARY KEY, applied_at timestamptz NOT NULL DEFAULT now())`, + ); + + const applied: string[] = []; + const alreadyApplied: string[] = []; + + for (const migration of workflowDeploySourceMigrations) { + const existing = await sql.unsafe( + `SELECT 1 FROM ${quoteQualified(SCHEMA, LEDGER_TABLE)} WHERE name = $1`, + [migration.name], + ); + if (existing.length > 0) { + alreadyApplied.push(migration.name); + continue; + } + try { + await sql.begin(async (tx) => { + await tx.unsafe(migration.sql); + await tx.unsafe( + `INSERT INTO ${quoteQualified(SCHEMA, LEDGER_TABLE)} (name) VALUES ($1)`, + [migration.name], + ); + }); + applied.push(migration.name); + } catch (err) { + const message = err instanceof Error ? err.message : String(err); + throw new Error( + `workflow_deploy_source migration ${migration.name} failed: ${message}`, + { cause: err }, + ); + } + } + + return { applied, alreadyApplied }; + } finally { + await sql.end({ timeout: 5 }); + } +} diff --git a/packages/workflow-deploy-source/src/record-on-deploy.ts b/packages/workflow-deploy-source/src/record-on-deploy.ts new file mode 100644 index 00000000..b31775e3 --- /dev/null +++ b/packages/workflow-deploy-source/src/record-on-deploy.ts @@ -0,0 +1,88 @@ +// The write-side seam: wraps a `SessionService & AdoptingWorkflowDeployer` +// so every code-sourced workflow deploy on SHARED capacity -- the only +// placement whose source previously existed nowhere in Postgres -- durably +// records its `WorkflowDefinitionSource` before returning to the caller. +// +// This is a workbench-side decorator around `@intx/hub-sessions`' +// `createSessionService(...)` output, composed at the app root +// (apps/hub/src/index.ts) exactly where `createLaunchCaches` already wraps +// `repoStore`/`assetService` the same way -- never a change to +// vendor/intx/hub-sessions/src/session-service.ts, whose two deploy methods +// this only wraps, not reimplements. Exclusive placement is unaffected: it +// already persists its source durably via `workflow_run_launch_spec` +// (vendor/intx/db/src/schema/workflow-run-launch-spec.ts), written from +// vendored `workflow-allocation-service.ts`, which this package does not +// touch. +import { getLogger } from "@intx/log"; +import type { + AdoptingWorkflowDeployer, + DeployAdoptedWorkflowFromSourceParams, + DeployWorkflowFromSourceParams, + SessionService, +} from "@intx/hub-sessions"; + +import type { WorkflowDeploySourceStore } from "./store"; + +const logger = getLogger(["workflow-deploy-source", "record-on-deploy"]); + +export type DeployWorkflowDeployer = SessionService & AdoptingWorkflowDeployer; + +function recordFromDeployParams( + params: + DeployWorkflowFromSourceParams | DeployAdoptedWorkflowFromSourceParams, +) { + return { + anchorRunId: params.anchorRunId, + tenantId: params.tenantId, + deploymentDomain: params.deploymentDomain, + source: params.source, + entry: params.entry, + definitionAssetId: params.definitionAssetId, + sourceAuthorityPrincipalId: params.config.principalId, + ...(params.pin !== undefined ? { pin: params.pin } : {}), + ...(params.sourceRef !== undefined ? { sourceRef: params.sourceRef } : {}), + }; +} + +/** + * Wrap a session service so `deployWorkflowFromSource` and + * `deployAdoptedWorkflowFromSource` -- the shared-capacity code-sourced + * deploy entry points `POST /workflows/deployments` and the routine + * launcher's adopted-anchor deploy drive -- record their `source` durably + * AFTER the deploy itself succeeds. A recording failure is reported (never + * a bare catch) but does not fail the deploy: the sidecar agent is already + * live by the time this runs, so surfacing the recording failure as a + * deploy failure would strand a live deployment behind a 500. + */ +export function withDeploySourceRecording( + sessionService: T, + store: WorkflowDeploySourceStore, +): T { + return { + ...sessionService, + async deployWorkflowFromSource(params) { + const result = await sessionService.deployWorkflowFromSource(params); + await recordOrLog(store, recordFromDeployParams(params)); + return result; + }, + async deployAdoptedWorkflowFromSource(params) { + const result = + await sessionService.deployAdoptedWorkflowFromSource(params); + await recordOrLog(store, recordFromDeployParams(params)); + return result; + }, + }; +} + +async function recordOrLog( + store: WorkflowDeploySourceStore, + entry: ReturnType, +): Promise { + try { + await store.record(entry); + } catch (cause) { + logger.error`failed to record deploy source for anchor run ${entry.anchorRunId}: ${ + cause instanceof Error ? cause.message : String(cause) + }`; + } +} diff --git a/packages/workflow-deploy-source/src/schema.ts b/packages/workflow-deploy-source/src/schema.ts new file mode 100644 index 00000000..e1ba8ee4 --- /dev/null +++ b/packages/workflow-deploy-source/src/schema.ts @@ -0,0 +1,59 @@ +// The one table this package owns: one row per anchor run naming the +// deploy-time inputs the hub needs to reissue that run's deploy call +// with no input beyond what Postgres already holds. It lives in its own +// `workflow_deploy_source` Postgres schema, fully siloed from `public` — +// see docs/package-migrations.md — and never reads `workflow_run` or +// `workflow_run_launch_spec` itself, so it never races either. +// +// `source` is `WorkflowDefinitionSource` verbatim — the same discriminated +// union `POST /workflows/deployments` already accepts (`registry` or +// `asset`). A hub-git asset is one arm of that union, not a hardcoded +// shape: nothing here assumes the bytes came from `RepoStore`, so a future +// source arm (a remote git origin, say) needs no new column, just a new +// case inside the same jsonb value. +import { index, jsonb, pgSchema, text, timestamp } from "drizzle-orm/pg-core"; + +export const workflowDeploySourceSchema = pgSchema("workflow_deploy_source"); + +export const workflowDeploySource = workflowDeploySourceSchema.table( + "workflow_deploy_source", + { + // The deployment's anchor `workflow_run.id`. One durable source record + // per deployment: a redeploy or a rotation overwrites this row rather + // than appending, so a lookup by anchor run id always answers with the + // current source. + anchorRunId: text("anchor_run_id").primaryKey(), + tenantId: text("tenant_id").notNull(), + deploymentDomain: text("deployment_domain").notNull(), + // Where the definition's bytes come from at apply time — the + // `WorkflowDefinitionSource` union (registry name@range, or an asset + // commit/tarball in the hub's git-backed store), stored as-is. + source: jsonb("source").notNull(), + // The `interchange.workflow` entry-module path the sidecar evaluates. + entry: text("entry").notNull(), + // A `name@range` spec for the definition package. Required for the + // `registry` and asset-`tarball` source variants; null for asset-`source`, + // whose member is selected by `source.package.packageName` instead. + pin: text("pin"), + // The `workflow`-kind asset the deployed definition projects a + // `workflow_definition` row over. + definitionAssetId: text("definition_asset_id").notNull(), + // WORKBENCH DELTA companion (see vendor/intx/hub-sessions + // `DeployWorkflowFromSourceParams.sourceRef`): the git ref inside the + // source asset that carries `source.package.commitSha`, when the asset + // mints a fresh tree per run rather than living on its default ref. + sourceRef: text("source_ref"), + // The principal whose grant/catalog authority a redeploy resolves fresh + // inference sources against. Never a resolved source or a credential — + // those are re-resolved at redeploy time, exactly as the exclusive + // placement's launch spec re-resolves from offering ids rather than + // persisting secrets. + sourceAuthorityPrincipalId: text("source_authority_principal_id").notNull(), + recordedAt: timestamp("recorded_at", { withTimezone: true }) + .notNull() + .defaultNow(), + }, + (table) => [index("workflow_deploy_source_tenant_idx").on(table.tenantId)], +); + +export type WorkflowDeploySourceRow = typeof workflowDeploySource.$inferSelect; diff --git a/packages/workflow-deploy-source/src/store.ts b/packages/workflow-deploy-source/src/store.ts new file mode 100644 index 00000000..8d85552b --- /dev/null +++ b/packages/workflow-deploy-source/src/store.ts @@ -0,0 +1,92 @@ +// Persistence for `workflow_deploy_source`, kept apart from the +// deploy-call decorator that drives it so the write shape is +// unit-testable without a real `SessionService`. `WorkflowDeploySourceStore` +// is the seam; `createDrizzleWorkflowDeploySourceStore` is its production +// implementation over `./schema.ts`. +import { eq } from "drizzle-orm"; +import type { PostgresJsDatabase } from "drizzle-orm/postgres-js"; +import type { WorkflowDefinitionSource } from "@intx/types/workflow-sources"; + +import { workflowDeploySource, type WorkflowDeploySourceRow } from "./schema"; + +/** + * The drizzle handle `createDrizzleWorkflowDeploySourceStore` operates + * against. Generic over the host's schema record, like + * `@corbits/run-key-history`'s own `RunKeyHistoryDb` — the host hands in + * its own `drizzle(sql, { schema })` instance unchanged, and no cast is + * needed at the call site. + */ +export type WorkflowDeploySourceDb< + TSchema extends Record = Record, +> = PostgresJsDatabase; + +export type WorkflowDeploySourceRecord = { + anchorRunId: string; + tenantId: string; + deploymentDomain: string; + source: WorkflowDefinitionSource; + entry: string; + pin?: string; + definitionAssetId: string; + sourceRef?: string; + sourceAuthorityPrincipalId: string; +}; + +export interface WorkflowDeploySourceStore { + /** + * Record (or overwrite, on a redeploy/rotation) the deploy source for one + * anchor run. Idempotent: recording the same anchor run twice replaces the + * row in place rather than accumulating history — the durable answer to + * "what is this deployment's source right now", not an audit log. + */ + record(entry: WorkflowDeploySourceRecord): Promise; + /** The current source record for an anchor run, or `null` if none was + * ever recorded (e.g. a deployment that predates this store). */ + get(anchorRunId: string): Promise; +} + +export function createDrizzleWorkflowDeploySourceStore< + TSchema extends Record, +>(db: WorkflowDeploySourceDb): WorkflowDeploySourceStore { + return { + async record(entry) { + await db + .insert(workflowDeploySource) + .values({ + anchorRunId: entry.anchorRunId, + tenantId: entry.tenantId, + deploymentDomain: entry.deploymentDomain, + source: entry.source, + entry: entry.entry, + pin: entry.pin ?? null, + definitionAssetId: entry.definitionAssetId, + sourceRef: entry.sourceRef ?? null, + sourceAuthorityPrincipalId: entry.sourceAuthorityPrincipalId, + recordedAt: new Date(), + }) + .onConflictDoUpdate({ + target: workflowDeploySource.anchorRunId, + set: { + tenantId: entry.tenantId, + deploymentDomain: entry.deploymentDomain, + source: entry.source, + entry: entry.entry, + pin: entry.pin ?? null, + definitionAssetId: entry.definitionAssetId, + sourceRef: entry.sourceRef ?? null, + sourceAuthorityPrincipalId: entry.sourceAuthorityPrincipalId, + recordedAt: new Date(), + }, + }); + }, + + async get(anchorRunId) { + const [row] = await db + .select() + .from(workflowDeploySource) + .where(eq(workflowDeploySource.anchorRunId, anchorRunId)) + .limit(1); + return row ?? null; + }, + }; +} diff --git a/packages/workflow-deploy-source/test/migrations.test.ts b/packages/workflow-deploy-source/test/migrations.test.ts new file mode 100644 index 00000000..3c5babe7 --- /dev/null +++ b/packages/workflow-deploy-source/test/migrations.test.ts @@ -0,0 +1,79 @@ +// DB-gated: runs against its own scratch database, never the +// developer's or the walking-skeleton suite's, mirroring +// packages/run-key-history/test/migrations.test.ts. +import { afterAll, beforeAll, describe, expect, test } from "bun:test"; +import postgres from "postgres"; + +import { e2eDatabaseUrl } from "../../../scripts/e2e/harness"; +import { applyWorkflowDeploySourceMigrations } from "../src/migrations"; + +function scratchUrlFor(e2eUrl: string): string { + const url = new URL(e2eUrl); + const database = url.pathname.replace(/^\//, ""); + url.pathname = `/${database}_workflow_deploy_source_migrations_test`; + return url.toString(); +} + +const databaseUrl = e2eDatabaseUrl(); +const describeIfDb = databaseUrl === undefined ? describe.skip : describe; + +describeIfDb("applyWorkflowDeploySourceMigrations", () => { + const scratchUrl = scratchUrlFor( + databaseUrl ?? "postgres://localhost:5432/unused", + ); + const scratchDatabase = new URL(scratchUrl).pathname.replace(/^\//, ""); + + async function withMaintenance(run: (sql: postgres.Sql) => Promise) { + const maintenanceUrl = new URL(scratchUrl); + maintenanceUrl.pathname = "/postgres"; + const maintenance = postgres(maintenanceUrl.toString(), { + max: 1, + onnotice: () => undefined, + }); + try { + await run(maintenance); + } finally { + await maintenance.end(); + } + } + + beforeAll(async () => { + await withMaintenance(async (sql) => { + await sql.unsafe(`DROP DATABASE IF EXISTS "${scratchDatabase}"`); + await sql.unsafe(`CREATE DATABASE "${scratchDatabase}"`); + }); + }, 20000); + + afterAll(async () => { + await withMaintenance(async (sql) => { + await sql.unsafe(`DROP DATABASE IF EXISTS "${scratchDatabase}"`); + }); + }, 20000); + + test("creates the schema, table, and ledger on first run", async () => { + const report = await applyWorkflowDeploySourceMigrations(scratchUrl); + expect(report.applied).toEqual(["0001_workflow_deploy_source"]); + expect(report.alreadyApplied).toEqual([]); + + const sql = postgres(scratchUrl, { max: 1, onnotice: () => undefined }); + try { + const tables = await sql` + SELECT table_name FROM information_schema.tables + WHERE table_schema = 'workflow_deploy_source' + ORDER BY table_name + `; + expect(tables.map((row) => row["table_name"])).toEqual([ + "workflow_deploy_source", + "workflow_deploy_source_migrations", + ]); + } finally { + await sql.end(); + } + }); + + test("is idempotent: a second run applies nothing new", async () => { + const report = await applyWorkflowDeploySourceMigrations(scratchUrl); + expect(report.applied).toEqual([]); + expect(report.alreadyApplied).toEqual(["0001_workflow_deploy_source"]); + }); +}); diff --git a/packages/workflow-deploy-source/test/record-on-deploy.test.ts b/packages/workflow-deploy-source/test/record-on-deploy.test.ts new file mode 100644 index 00000000..5d8d5415 --- /dev/null +++ b/packages/workflow-deploy-source/test/record-on-deploy.test.ts @@ -0,0 +1,131 @@ +// Pure unit test: proves the decorator records the deploy source AFTER a +// successful deploy, forwards the underlying result untouched, and never +// lets a recording failure fail the deploy call itself -- no DB, no +// SessionService, both are hand-rolled minimal doubles. +import { describe, expect, test } from "bun:test"; +import type { + AdoptingWorkflowDeployer, + DeployWorkflowDefinitionResult, + SessionService, +} from "@intx/hub-sessions"; + +import { withDeploySourceRecording } from "../src/record-on-deploy"; +import type { + WorkflowDeploySourceRecord, + WorkflowDeploySourceStore, +} from "../src/store"; + +function fakeDeployer(): SessionService & AdoptingWorkflowDeployer { + const result: DeployWorkflowDefinitionResult = { + anchorRunId: "run_1", + deploymentAddress: "run_1@tenant1.workbench.dev", + publicKey: "pk_1", + }; + return { + stageWorkflowStep: async () => {}, + deployWorkflowFromSource: async () => result, + deployAdoptedWorkflowFromSource: async () => result, + sendUserMessage: async () => new Uint8Array(), + endSession: async () => {}, + }; +} + +function recordingStore(): WorkflowDeploySourceStore & { + recorded: WorkflowDeploySourceRecord[]; +} { + const recorded: WorkflowDeploySourceRecord[] = []; + return { + recorded, + async record(entry) { + recorded.push(entry); + }, + async get() { + return null; + }, + }; +} + +const baseParams = { + tenantId: "tenant_1", + anchorRunId: "run_1", + deploymentDomain: "tenant1.workbench.dev", + agentAddress: "run_1@tenant1.workbench.dev", + source: { + kind: "asset" as const, + assetId: "asset_1", + package: { format: "source" as const, commitSha: "a".repeat(40) }, + }, + entry: "workflow.ts", + definitionAssetId: "asset_1", + config: { + sessionId: "session_1", + agentId: "agent_1", + tenantId: "tenant_1", + principalId: "principal_1", + agentAddress: "run_1@tenant1.workbench.dev", + systemPrompt: "", + tools: [], + grants: [], + sources: [], + defaultSource: "default", + }, +}; + +describe("withDeploySourceRecording", () => { + test("records the source after deployWorkflowFromSource succeeds", async () => { + const store = recordingStore(); + const wrapped = withDeploySourceRecording(fakeDeployer(), store); + + const result = await wrapped.deployWorkflowFromSource(baseParams); + + expect(result.anchorRunId).toBe("run_1"); + expect(store.recorded).toHaveLength(1); + expect(store.recorded[0]).toEqual({ + anchorRunId: "run_1", + tenantId: "tenant_1", + deploymentDomain: "tenant1.workbench.dev", + source: baseParams.source, + entry: "workflow.ts", + definitionAssetId: "asset_1", + sourceAuthorityPrincipalId: "principal_1", + }); + }); + + test("records the source after deployAdoptedWorkflowFromSource succeeds", async () => { + const store = recordingStore(); + const wrapped = withDeploySourceRecording(fakeDeployer(), store); + + await wrapped.deployAdoptedWorkflowFromSource({ + ...baseParams, + pin: "1.2.3", + sourceRef: "refs/heads/runs/run_1", + }); + + expect(store.recorded).toHaveLength(1); + expect(store.recorded[0]?.pin).toBe("1.2.3"); + expect(store.recorded[0]?.sourceRef).toBe("refs/heads/runs/run_1"); + }); + + test("a recording failure is swallowed, not surfaced as a deploy failure", async () => { + const failingStore: WorkflowDeploySourceStore = { + record: async () => { + throw new Error("db unreachable"); + }, + get: async () => null, + }; + const wrapped = withDeploySourceRecording(fakeDeployer(), failingStore); + + const result = await wrapped.deployWorkflowFromSource(baseParams); + expect(result.anchorRunId).toBe("run_1"); + }); + + test("other SessionService methods pass through unwrapped", async () => { + const store = recordingStore(); + const underlying = fakeDeployer(); + const wrapped = withDeploySourceRecording(underlying, store); + + expect(wrapped.stageWorkflowStep).toBe(underlying.stageWorkflowStep); + expect(wrapped.sendUserMessage).toBe(underlying.sendUserMessage); + expect(wrapped.endSession).toBe(underlying.endSession); + }); +}); diff --git a/packages/workflow-deploy-source/test/store.test.ts b/packages/workflow-deploy-source/test/store.test.ts new file mode 100644 index 00000000..514b5a2e --- /dev/null +++ b/packages/workflow-deploy-source/test/store.test.ts @@ -0,0 +1,232 @@ +// DB-gated: proves `record`'s upsert semantics and the redeploy round trip +// against a real Postgres transaction, mirroring +// packages/run-key-history/test/store.test.ts's scratch-database setup. +import { afterAll, beforeAll, describe, expect, test } from "bun:test"; +import { drizzle } from "drizzle-orm/postgres-js"; +import postgres from "postgres"; + +import { e2eDatabaseUrl } from "../../../scripts/e2e/harness"; +import { applyWorkflowDeploySourceMigrations } from "../src/migrations"; +import { createDrizzleWorkflowDeploySourceStore } from "../src/store"; + +function scratchUrlFor(e2eUrl: string): string { + const url = new URL(e2eUrl); + const database = url.pathname.replace(/^\//, ""); + url.pathname = `/${database}_workflow_deploy_source_store_test`; + return url.toString(); +} + +const databaseUrl = e2eDatabaseUrl(); +const describeIfDb = databaseUrl === undefined ? describe.skip : describe; + +describeIfDb("createDrizzleWorkflowDeploySourceStore", () => { + const scratchUrl = scratchUrlFor( + databaseUrl ?? "postgres://localhost:5432/unused", + ); + const scratchDatabase = new URL(scratchUrl).pathname.replace(/^\//, ""); + + async function withMaintenance(run: (sql: postgres.Sql) => Promise) { + const maintenanceUrl = new URL(scratchUrl); + maintenanceUrl.pathname = "/postgres"; + const maintenance = postgres(maintenanceUrl.toString(), { + max: 1, + onnotice: () => undefined, + }); + try { + await run(maintenance); + } finally { + await maintenance.end(); + } + } + + beforeAll(async () => { + await withMaintenance(async (sql) => { + await sql.unsafe(`DROP DATABASE IF EXISTS "${scratchDatabase}"`); + await sql.unsafe(`CREATE DATABASE "${scratchDatabase}"`); + }); + await applyWorkflowDeploySourceMigrations(scratchUrl); + }, 20000); + + afterAll(async () => { + await withMaintenance(async (sql) => { + await sql.unsafe(`DROP DATABASE IF EXISTS "${scratchDatabase}"`); + }); + }, 20000); + + test("records and reads back an asset-sourced deploy", async () => { + const sql = postgres(scratchUrl, { max: 1, onnotice: () => undefined }); + const db = drizzle(sql); + const store = createDrizzleWorkflowDeploySourceStore(db); + try { + await store.record({ + anchorRunId: "run_asset_1", + tenantId: "tenant_1", + deploymentDomain: "tenant1.workbench.dev", + source: { + kind: "asset", + assetId: "asset_1", + package: { format: "source", commitSha: "a".repeat(40) }, + }, + entry: "workflow.ts", + definitionAssetId: "asset_1", + sourceAuthorityPrincipalId: "principal_1", + }); + + const row = await store.get("run_asset_1"); + expect(row).not.toBeNull(); + expect(row?.source).toEqual({ + kind: "asset", + assetId: "asset_1", + package: { format: "source", commitSha: "a".repeat(40) }, + }); + expect(row?.pin).toBeNull(); + expect(row?.sourceRef).toBeNull(); + } finally { + await sql.end(); + } + }); + + test("a redeploy overwrites the prior record for the same anchor run", async () => { + const sql = postgres(scratchUrl, { max: 1, onnotice: () => undefined }); + const db = drizzle(sql); + const store = createDrizzleWorkflowDeploySourceStore(db); + try { + await store.record({ + anchorRunId: "run_rotate", + tenantId: "tenant_1", + deploymentDomain: "tenant1.workbench.dev", + source: { + kind: "asset", + assetId: "asset_1", + package: { format: "source", commitSha: "a".repeat(40) }, + }, + entry: "workflow.ts", + definitionAssetId: "asset_1", + sourceAuthorityPrincipalId: "principal_1", + }); + await store.record({ + anchorRunId: "run_rotate", + tenantId: "tenant_1", + deploymentDomain: "tenant1.workbench.dev", + source: { + kind: "asset", + assetId: "asset_1", + package: { format: "source", commitSha: "b".repeat(40) }, + }, + entry: "workflow.ts", + definitionAssetId: "asset_1", + sourceAuthorityPrincipalId: "principal_1", + }); + + const row = await store.get("run_rotate"); + expect(row?.source).toEqual({ + kind: "asset", + assetId: "asset_1", + package: { format: "source", commitSha: "b".repeat(40) }, + }); + } finally { + await sql.end(); + } + }); + + // The deliberate proof CL-6581 phase 1 asks for: everything a shared + // placement deploy needs to be reissued survives in Postgres alone, with + // NO input from the sidecar's local `deployment.json`. This test writes a + // record with one connection (standing in for the hub process that + // performed the original deploy), then opens a FRESH connection and store + // instance (standing in for a hub restart with no shared in-memory state) + // and reconstructs the exact `DeployWorkflowFromSourceParams` shape a + // redeploy call needs -- proving the record alone, not any sidecar file, + // is sufficient to redrive the deploy. + test("a redeploy's full source-call intent survives a fresh connection, with no sidecar record involved", async () => { + const writerSql = postgres(scratchUrl, { + max: 1, + onnotice: () => undefined, + }); + try { + const writerStore = createDrizzleWorkflowDeploySourceStore( + drizzle(writerSql), + ); + await writerStore.record({ + anchorRunId: "run_restart_proof", + tenantId: "tenant_1", + deploymentDomain: "tenant1.workbench.dev", + source: { + kind: "asset", + assetId: "asset_native_workflow", + package: { + format: "source", + commitSha: "c".repeat(40), + packageName: "@corbits/example-workflow", + }, + }, + entry: "src/workflow.ts", + definitionAssetId: "asset_native_workflow", + sourceRef: "refs/heads/runs/run_restart_proof", + sourceAuthorityPrincipalId: "principal_seed", + }); + } finally { + await writerSql.end(); + } + + // A fresh process, a fresh connection, a fresh store -- nothing carried + // over from the write above except what landed in Postgres. + const readerSql = postgres(scratchUrl, { + max: 1, + onnotice: () => undefined, + }); + try { + const readerStore = createDrizzleWorkflowDeploySourceStore( + drizzle(readerSql), + ); + const row = await readerStore.get("run_restart_proof"); + expect(row).not.toBeNull(); + if (row === null) return; + + // Everything `DeployWorkflowFromSourceParams` needs beyond a fresh + // `HarnessConfig` (re-resolved from the tenant's live inference + // catalog, never persisted here) is present and round-trips exactly. + const redeployParams = { + tenantId: row.tenantId, + anchorRunId: row.anchorRunId, + deploymentDomain: row.deploymentDomain, + source: row.source, + entry: row.entry, + definitionAssetId: row.definitionAssetId, + ...(row.pin !== null ? { pin: row.pin } : {}), + ...(row.sourceRef !== null ? { sourceRef: row.sourceRef } : {}), + }; + + expect(redeployParams).toEqual({ + tenantId: "tenant_1", + anchorRunId: "run_restart_proof", + deploymentDomain: "tenant1.workbench.dev", + source: { + kind: "asset", + assetId: "asset_native_workflow", + package: { + format: "source", + commitSha: "c".repeat(40), + packageName: "@corbits/example-workflow", + }, + }, + entry: "src/workflow.ts", + definitionAssetId: "asset_native_workflow", + sourceRef: "refs/heads/runs/run_restart_proof", + }); + } finally { + await readerSql.end(); + } + }); + + test("get returns null for an anchor run that was never recorded", async () => { + const sql = postgres(scratchUrl, { max: 1, onnotice: () => undefined }); + const db = drizzle(sql); + const store = createDrizzleWorkflowDeploySourceStore(db); + try { + expect(await store.get("run_never_seen")).toBeNull(); + } finally { + await sql.end(); + } + }); +}); diff --git a/packages/workflow-deploy-source/tsconfig.json b/packages/workflow-deploy-source/tsconfig.json new file mode 100644 index 00000000..e956ddd8 --- /dev/null +++ b/packages/workflow-deploy-source/tsconfig.json @@ -0,0 +1,7 @@ +{ + "extends": "../../tsconfig.base.json", + "compilerOptions": { + "types": ["bun"] + }, + "include": ["src", "test"] +} diff --git a/scripts/checks/no-product-tenancy.ts b/scripts/checks/no-product-tenancy.ts index 2faa2125..0fbd077a 100644 --- a/scripts/checks/no-product-tenancy.ts +++ b/scripts/checks/no-product-tenancy.ts @@ -103,6 +103,20 @@ const ALLOWLIST: readonly { maxOccurrences: 1, tables: ["run_key_history"], }, + { + // A native workflow's deploy source (an npm name@range pin or a + // hub-asset commit) is a real external pin nothing native records. + // RepoStore holds the source bytes; workflow_definition_version holds + // the body projection (wireProjection, grantSnapshot, + // approvedWireHash). Neither stores the deploy PARAMETERS — entry, + // pin, sourceRef, deploymentDomain, and the WorkflowDefinitionSource + // union itself — that select and apply those bytes. This table is + // that missing record, for shared placement (CL-6581 phase 1; + // exclusive placement already has workflow_run_launch_spec). + relPath: "packages/workflow-deploy-source/src/schema.ts", + maxOccurrences: 1, + tables: ["workflow_deploy_source.workflow_deploy_source"], + }, { relPath: "packages/bench/src/schema.ts", maxOccurrences: 1, diff --git a/scripts/db-setup.ts b/scripts/db-setup.ts index d93a92f0..b09ed6ed 100644 --- a/scripts/db-setup.ts +++ b/scripts/db-setup.ts @@ -52,6 +52,7 @@ import { listTaskFoldedRunIds, } from "../packages/tasks/src/migrations"; import { applyRunKeyHistoryMigrations } from "../packages/run-key-history/src/migrations"; +import { applyWorkflowDeploySourceMigrations } from "../packages/workflow-deploy-source/src/migrations"; import { applyInferenceCatalogMigrations } from "../packages/inference-catalog/src/migrations"; const repoRoot = path.resolve(import.meta.dir, ".."); @@ -88,6 +89,10 @@ const INSTALLED_PACKAGE_MIGRATIONS: readonly { { name: "@workbench/access-policy", apply: applyAccessPolicyMigrations }, { name: "@corbits/tasks", apply: applyTasksMigrations }, { name: "@corbits/run-key-history", apply: applyRunKeyHistoryMigrations }, + { + name: "@corbits/workflow-deploy-source", + apply: applyWorkflowDeploySourceMigrations, + }, { name: "@corbits/inference-catalog", apply: applyInferenceCatalogMigrations,