From 088ea954ed8ef6b341c4f8deeefdc17a5757e6d6 Mon Sep 17 00:00:00 2001 From: Sawyer Date: Thu, 17 Sep 2026 16:18:29 -0700 Subject: [PATCH] chore(hub): drop ticket references from comments --- apps/hub/src/mailbox-persist.ts | 4 +-- apps/hub/src/native-connector-registry.ts | 36 ++++++++--------------- apps/hub/test/mailbox-persist.test.ts | 11 ++----- 3 files changed, 18 insertions(+), 33 deletions(-) diff --git a/apps/hub/src/mailbox-persist.ts b/apps/hub/src/mailbox-persist.ts index 53a41e5cf..5f6cae0fd 100644 --- a/apps/hub/src/mailbox-persist.ts +++ b/apps/hub/src/mailbox-persist.ts @@ -43,8 +43,8 @@ const logger = getLogger(["hub", "mailbox-persist"]); /** * Wraps the hub's own `persistMail` (vendor's `baseLookups.persistMail`) * so a run's `agent_session` and event collector exist before that write - * runs — CL-7480: the first inbound mail on a freshly triggered run is - * often the earliest point the run is mail-routable at all, since + * runs: the first inbound mail on a freshly triggered run is often the + * earliest point the run is mail-routable at all, since * `workflow_run.principal_id` only reconciles onto the trigger that just * fired. Resolves the frame's own sender address to its run * (`resolveRoutableAddress`, the same resolver `persistMail` itself diff --git a/apps/hub/src/native-connector-registry.ts b/apps/hub/src/native-connector-registry.ts index d499a39f3..9ea7f3d38 100644 --- a/apps/hub/src/native-connector-registry.ts +++ b/apps/hub/src/native-connector-registry.ts @@ -1,19 +1,10 @@ -// The hub's native connector registry (hub-zero T4, CL-8126): every -// connector and curated MCP preset this build actually ships, built from -// `@corbits/connections`' generic descriptor shape and route factories — a -// hub-local port of the legacy template package's registry, with zero -// import from that package. `@corbits/connections` itself carries no -// default connector set, so the hub composes its own here and passes -// `CONNECTOR_REGISTRY` / `MCP_PRESETS` into the route factories that need -// one (connections, connections/oauth, workflow-connections, mcp-servers, -// the chat orchestrator's connector registry). -// -// Ported one-for-one: descriptor ids, auth kinds, credential plugins, docs -// URLs, `feedsTools` tool packages, probe functions, OAuth configs, icons, -// and the preset list are identical to the legacy source, so the settings -// surface, connect flows, and pinned-package bindings behave exactly as -// before. The one deliberate divergence is documented on -// `chatgptAccountIdFromIdToken` below. +// The hub's native connector registry: every connector and curated MCP +// preset this build ships, built from `@corbits/connections`' generic +// descriptor shape and route factories. `@corbits/connections` itself +// carries no default connector set, so the hub composes its own here and +// passes `CONNECTOR_REGISTRY` / `MCP_PRESETS` into the route factories that +// need one (connections, connections/oauth, workflow-connections, +// mcp-servers, the chat orchestrator's connector registry). // // Server-only, on purpose: the hub (bun) serves this to the settings // surface over HTTP — it never ships in a browser bundle from here. @@ -79,10 +70,9 @@ function chatgptAccountIdFromIdToken(idToken: string): string | undefined { // registry actually has a listing for pulls in only those icons' data, not // the whole ~3000-brand package (CC0-1.0 licensed — see the package's own // LICENSE — so redistributing these marks needs no separate clearance). -// Granola and ScrapeCreators have no simple-icons listing (CL-6215's -// plugins-directory rebuild); OpenAI, xAI, Groq, and Opencode Zen have none -// either (CL-6258's connections logos) — those descriptors carry no `icon`, -// so a caller renders their monochrome initial tile instead. Exa publishes +// Granola, ScrapeCreators, OpenAI, xAI, Groq, and Opencode Zen have no +// simple-icons listing, so those descriptors carry no `icon` and a caller +// renders their monochrome initial tile instead. Exa publishes // its own mark in its official brand kit, used below. Google's mark // here is Gemini's, not the generic Google "G" — the model brand a person // actually recognizes from connecting an AI provider, matching @@ -305,7 +295,7 @@ function inferenceProviderDescriptors(): Record { }, }, }; - // The two loopback OAuth providers (CL-7510). Their authorization + // The two loopback OAuth providers. Their authorization // servers only accept the fixed `http://localhost:` redirect URI // the provider's own CLI registers (`authKind: "oauth-loopback"`), so // `buildAuthorizeUrl` ignores the hub callback URL the generic @@ -604,7 +594,7 @@ export const CONNECTOR_REGISTRY: ConnectorRegistry = createConnectorRegistry({ // token. Absent entirely, github-tools degrades to a lower // unauthenticated rate limit rather than "not connected" — see its // tool.ts. `authKind` stays "api-key" (the PAT paste form is - // always available, CL-6386's guaranteed fallback); the `oauth` + // always available as a guaranteed fallback); the `oauth` // config below is this connector's one exception to "oauth fields // are oauth-pkce/oauth-code only" — a caller checks // `GET /oauth-configured`'s `github` entry to decide whether to @@ -779,7 +769,7 @@ export const MCP_PRESETS: readonly McpPreset[] = [ docsUrl: "https://sumble.com/guides/account-research", }, { - // No simple-icons listing for Canva (CL-6647) — same gap as Granola + // No simple-icons listing for Canva — same gap as Granola // and Sumble above, so this card falls back to the initial-letter // tile rather than risk a hand-traced or doctored mark. slug: "canva", diff --git a/apps/hub/test/mailbox-persist.test.ts b/apps/hub/test/mailbox-persist.test.ts index 43e8081bb..86e4ce847 100644 --- a/apps/hub/test/mailbox-persist.test.ts +++ b/apps/hub/test/mailbox-persist.test.ts @@ -1,11 +1,6 @@ -// CL-7449: proves the real composition -- `createHubSessionLookups`'s -// `persistMail` wrapped by `createMailboxPersist` via -// `createHubMailboxAuthorizeSender` (`../src/mailbox-persist.ts`) -- against -// a real Postgres, matching how -// `createHub` wires them in `../src/index.ts`. DB-gated: skipped when -// DATABASE_URL is unreachable, matching every other suite in this -// directory (`composition.test.ts` boots the whole hub over HTTP; this -// suite exercises the same `persistMail` wiring directly, without a boot). +// DB-gated: skipped when DATABASE_URL is unreachable, matching every other +// suite in this directory (`composition.test.ts` boots the whole hub over +// HTTP; this suite exercises `persistMail` wiring directly, without a boot). import { afterAll, expect, test } from "bun:test"; import { eq } from "drizzle-orm"; import { createDB } from "@intx/db";