Merge pull request #39 from couchbaselabs/feature/issue_924_viewname_special_chars

Fixed Java Core 924: viewname special chars

Author: pasin

src/main/java/com/couchbase/lite/store/ForestDBStore.java

@@ -1047,24 +1047,20 @@ public Status run() {
     }
 
     @Override
-    public ViewStore getViewStorage(String name, boolean create) {
-        try {
-            return new ForestDBViewStore(this, name, create);
-        } catch (CouchbaseLiteException e) {
-            if(e.getCBLStatus().getCode() != Status.NOT_FOUND)
-                Log.e(TAG, "Error in getViewStorage()", e);
-            return null;
-        }
+    public ViewStore getViewStorage(String name, boolean create) throws CouchbaseLiteException {
+        return new ForestDBViewStore(this, name, create);
     }
 
     @Override
     public List<String> getAllViewNames() {
         List<String> result = new ArrayList<String>();
         String[] fileNames = new File(directory).list();
-        for(String filename : fileNames){
-            String viewName = ForestDBViewStore.fileNameToViewName(filename);
-            if(viewName != null)
-                result.add(viewName);
+        for (String filename : fileNames) {
+            try {
+                result.add(ForestDBViewStore.fileNameToViewName(filename));
+            } catch (CouchbaseLiteException e) {
+                Log.w(TAG, "Error in fileNameToViewName(): filename=" + filename, e);
+            }
         }
         return result;
     }
@@ -1311,8 +1307,12 @@ public Action actionToChangeEncryptionKey(final SymmetricKey newKey) {
         // Re-key the views!
         List<String> viewNames = getAllViewNames();
         for (String viewName : viewNames) {
-            ForestDBViewStore viewStorage = (ForestDBViewStore) getViewStorage(viewName, true);
-            action.add(viewStorage.getActionToChangeEncryptionKey());
+            try {
+                ForestDBViewStore viewStorage = (ForestDBViewStore) getViewStorage(viewName, true);
+                action.add(viewStorage.getActionToChangeEncryptionKey());
+            } catch (CouchbaseLiteException ex) {
+                Log.w(TAG, "Error in getViewStorage() viewName=" + viewName, ex);
+            }
         }
 
         // Re-key the database:

src/main/java/com/couchbase/lite/store/ForestDBViewStore.java

@@ -39,11 +39,13 @@
 import com.couchbase.lite.support.action.ActionException;
 import com.couchbase.lite.support.security.SymmetricKey;
 import com.couchbase.lite.util.Log;
-import com.fasterxml.jackson.core.JsonProcessingException;
 
 import java.io.File;
 import java.io.IOException;
+import java.io.UnsupportedEncodingException;
 import java.math.BigInteger;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -699,23 +701,53 @@ public void execute() throws ActionException {
     // Internal (Protected/Private) Static Methods
     ///////////////////////////////////////////////////////////////////////////
 
-    protected static String fileNameToViewName(String fileName) {
+    protected static String fileNameToViewName(String fileName) throws CouchbaseLiteException {
         if (!fileName.endsWith(kViewIndexPathExtension))
-            return null;
+            throw new CouchbaseLiteException(Status.BAD_PARAM);
         if (fileName.startsWith("."))
-            return null;
+            throw new CouchbaseLiteException(Status.BAD_PARAM);
+
         String viewName = fileName.substring(0, fileName.indexOf("."));
-        viewName = viewName.replaceAll(":", "/");
+        viewName = isWindows() ? unescapeViewNameWindows(viewName) : viewName.replaceAll(":", "/");
         return viewName;
     }
 
-    private static String viewNameToFileName(String viewName) {
+    private static String viewNameToFileName(String viewName) throws CouchbaseLiteException {
         if (viewName.startsWith(".") || viewName.indexOf(":") > 0)
-            return null;
-        viewName = viewName.replaceAll("/", ":");
+            throw new CouchbaseLiteException(Status.BAD_PARAM);
+
+        viewName = isWindows() ? escapeViewNameWindows(viewName) : viewName.replaceAll("/", ":");
+
         return viewName + "." + kViewIndexPathExtension;
     }
 
+    private static String escapeViewNameWindows(String viewName)throws CouchbaseLiteException {
+        try {
+            viewName = URLEncoder.encode(viewName, "UTF-8");
+        } catch (UnsupportedEncodingException e) {
+            Log.w(TAG, "Error to url decode: " + viewName, e);
+            throw new CouchbaseLiteException(e, Status.BAD_ENCODING);
+        }
+        viewName = viewName.replaceAll("\\*", "%2A");
+        return viewName;
+    }
+
+    private static String unescapeViewNameWindows(String viewName)throws CouchbaseLiteException {
+        viewName = viewName.replaceAll("%2A", "*");
+        try {
+            viewName = URLDecoder.decode(viewName, "UTF-8");
+        } catch (UnsupportedEncodingException e) {
+            Log.w(TAG, "Error to url decode: " + viewName, e);
+            throw new CouchbaseLiteException(e, Status.BAD_ENCODING);
+        }
+        return viewName;
+    }
+    private static String OS = System.getProperty("os.name").toLowerCase();
+
+    private static boolean isWindows(){
+        return (OS.indexOf("win") >= 0);
+    }
+
     /**
      * Are key1 and key2 grouped together at this groupLevel?
      */