Fix linter issues and move example workflow

Lint fixes:
- Remove unused jsMethodPattern variable in javascript.go
- Simplify nil checks in patterns_test.go and remediation_test.go

Configuration:
- Add .golangci.yml with test file exclusions for errcheck
- Move example workflow to examples/ to prevent it running on this repo

Author: thebenignhacker

.golangci.yml

@@ -0,0 +1,37 @@
+# golangci-lint configuration
+# https://golangci-lint.run/usage/configuration/
+
+run:
+  timeout: 5m
+  tests: true
+
+linters:
+  enable:
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+
+linters-settings:
+  errcheck:
+    # Don't check for unchecked errors in test files for setup code
+    exclude-functions:
+      - os.MkdirAll
+      - os.WriteFile
+      - os.RemoveAll
+      - (io.Closer).Close
+      - (*os.File).Close
+      - (net/http.ResponseWriter).Write
+      - (*encoding/json.Encoder).Encode
+
+issues:
+  # Exclude some linters from running on tests files
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - errcheck
+    - path: testdata/
+      linters:
+        - errcheck

.github/workflows/example-cryptodeps.yml examples/github-action-workflow.yml.github/workflows/example-cryptodeps.yml renamed to examples/github-action-workflow.yml

@@ -31,9 +31,8 @@ var (
 	importDynPattern  = regexp.MustCompile(`import\s*\(\s*['"]([^'"]+)['"]\s*\)`)
 
 	// Function detection patterns
-	jsFuncDeclPattern   = regexp.MustCompile(`(?:async\s+)?function\s+(\w+)\s*\(`)
-	jsMethodPattern     = regexp.MustCompile(`(\w+)\s*\([^)]*\)\s*{`)
-	jsArrowFuncPattern  = regexp.MustCompile(`(?:const|let|var)\s+(\w+)\s*=\s*(?:async\s*)?\([^)]*\)\s*=>`)
+	jsFuncDeclPattern  = regexp.MustCompile(`(?:async\s+)?function\s+(\w+)\s*\(`)
+	jsArrowFuncPattern = regexp.MustCompile(`(?:const|let|var)\s+(\w+)\s*=\s*(?:async\s*)?\([^)]*\)\s*=>`)
 	jsClassMethodPattern = regexp.MustCompile(`(?:async\s+)?(\w+)\s*\([^)]*\)\s*{`)
 	jsExportPattern     = regexp.MustCompile(`^(?:export\s+(?:default\s+)?(?:async\s+)?(?:function|class|const|let|var)\s+(\w+)|module\.exports\s*[.=]|exports\.(\w+))`)
 	jsClassPattern      = regexp.MustCompile(`class\s+(\w+)`)

internal/analyzer/ast/javascript.go

@@ -42,7 +42,7 @@ func TestGetPatternsForEcosystem(t *testing.T) {
 
 func TestGetPatternsForUnknownEcosystem(t *testing.T) {
 	patterns := GetPatternsForEcosystem("unknown")
-	if patterns != nil && len(patterns) > 0 {
+	if len(patterns) > 0 {
 		t.Errorf("GetPatternsForEcosystem(unknown) = %v, want empty/nil", patterns)
 	}
 }

pkg/crypto/patterns_test.go

@@ -219,7 +219,7 @@ func TestGetLibraryRecommendations(t *testing.T) {
 func TestGetLibraryRecommendationsUnknown(t *testing.T) {
 	libs := GetLibraryRecommendations("UNKNOWN_ALGO", types.EcosystemGo)
 	// Should return nil or empty for unknown algorithms
-	if libs != nil && len(libs) > 0 {
+	if len(libs) > 0 {
 		t.Errorf("GetLibraryRecommendations(unknown) = %v, want nil/empty", libs)
 	}
 }