Rule indent: Change acceptable values

`rule-indent` option now accepts only these kinds of values:
    - `{Number}` of spaces;
    - `{String}` of whitespaces and tabs. If there is any other character in the
      string, the value will not be set.

Author: tonyganch

.csscomb.json

@@ -13,7 +13,7 @@
     "eof-newline": true,
     "leading-zero": false,
     "remove-empty-rulesets": true,
-    "rule-indent": true,
+    "rule-indent": "    ",
     "stick-brace": "\n",
     "strip-spaces": true,
     "unitless-zero": true,

README.md

@@ -157,7 +157,7 @@ Example configuration:
     "eof-newline": true,
     "leading-zero": false,
     "remove-empty-rulesets": true,
-    "rule-indent": true,
+    "rule-indent": "    ",
     "stick-brace": true,
     "strip-spaces": true,
     "unitless-zero": true,
@@ -511,10 +511,10 @@ Example: `{ "remove-empty-rulesets": true }` - remove rulesets that have no decl
 
 **Note**: better to use with [block-indent](#block-indent)
 
-Available values:
-  * `{Boolean}` `true` (means 4 spaces)
-  * `{Number}` of spaces
-  * `{String}` of whitespace characters (`/[ \t]+/`)
+Acceptable values:
+  * `{Number}` of spaces;
+  * `{String}` of whitespaces or tabs. If there is any other character in the
+    string, the value will not be set.
 
 Example: `{ "rule-indent": 2 }`
 
@@ -528,6 +528,19 @@ a {
   margin:0 }
 ```
 
+Example: `{ "rule-indent": "  " }`
+
+```css
+/* before */
+a { color:red; margin:0 }
+
+/* after */
+a {
+  color:red;
+  margin:0 }
+```
+
+
 ### sort-order
 
 **Note**: you can use an example of [.csscomb.json](https://github.com/csscomb/csscomb.js/blob/master/.csscomb.json) to set your own sort order

lib/options/rule-indent.js

@@ -3,15 +3,18 @@ module.exports = {
     /**
      * Sets handler value.
      *
-     * @param {String|Number|Boolean} value Option value
+     * @param {String|Number} value Option value
      * @returns {Object|undefined}
      */
     setValue: function(value) {
         delete this._value;
-        if (value === true) this._value = '    ';
-        if (typeof value === 'number' && value === Math.abs(Math.round(value)))
+
+        if (typeof value === 'number' && value === Math.abs(Math.round(value))) {
             this._value = new Array(value + 1).join(' ');
-        if (typeof value === 'string' && value.match(/^[ \t]+$/)) this._value = value;
+        } else if (typeof value === 'string' && value.match(/^[ \t]+$/)) {
+            this._value = value;
+        }
+
         if (typeof this._value === 'string') return this;
     },
 

test/rule-indent.js

@@ -3,37 +3,31 @@ var assert = require('assert');
 
 describe('options/rule-indent', function() {
     var comb;
+
     beforeEach(function() {
         comb = new Comb();
     });
+
     it('Invalid Number value should not change rule indent', function() {
+        var input = 'a {\n color: red }';
         comb.configure({ 'rule-indent': 3.5 });
-        assert.equal(
-            comb.processString('a {\n color: red }'),
-            'a {\n color: red }'
-        );
+        assert.equal(comb.processString(input), input);
     });
+
     it('Invalid String value should not change rule indent', function() {
+        var input = 'a {\n color: red }';
         comb.configure({ 'rule-indent': 'foobar' });
-        assert.equal(
-            comb.processString('a {\n color: red }'),
-            'a {\n color: red }'
-        );
-    });
-    it('True Boolean value should set 4 spaces indent', function() {
-        comb.configure({ 'rule-indent': true });
-        assert.equal(
-            comb.processString('a {\n color: red }'),
-            'a {\n    color: red }'
-        );
+        assert.equal(comb.processString(input), input);
     });
+
     it('Valid Number value should set equal space indent', function() {
         comb.configure({ 'rule-indent': 3 });
         assert.equal(
             comb.processString('a {\n color: red }'),
             'a {\n   color: red }'
         );
     });
+
     it('Valid String value should set equal indent', function() {
         comb.configure({ 'rule-indent': '\t' });
         assert.equal(
@@ -49,8 +43,9 @@ describe('options/rule-indent', function() {
             'a { /* foo */\n\tcolor:red; /* bar */\n\n\tbackground: #fff\n}\n'
         );
     });
+
     it('Valid value should ignore empty blocks', function() {
-        comb.configure({ 'rule-indent': true });
+        comb.configure({ 'rule-indent': '  ' });
         assert.equal(
             comb.processString('a {}'),
             'a {}'