Skip to content

Commit a01bd72

Browse files
committed
Fixed an issue with unitless-zero and percents
1 parent bdc2d36 commit a01bd72

2 files changed

Lines changed: 15 additions & 4 deletions

File tree

lib/options/unitless-zero.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,11 @@ module.exports = {
4141
var result = null;
4242

4343
// If we see a zero with unit and it is not degree, then we don’t have an option
44-
if (nodeType === 'percentage' || nodeType === 'dimension') {
45-
if (node[0][1] === '0' && node[1][1] !== 'deg') {
46-
result = false;
47-
}
44+
if (
45+
nodeType === 'percentage' && node[0][1] === '0' ||
46+
nodeType === 'dimension' && node[0][1] === '0' && node[1][1] !== 'deg'
47+
) {
48+
result = false;
4849
}
4950

5051
// If we see a zero and previous node is not percentage or dimension, then we have an option

test/unitless-zero.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,14 @@ describe('options/unitless-zero', function() {
105105
{}
106106
);
107107
});
108+
109+
it('Should detect unitless zero option with percents', function() {
110+
should_detect(
111+
['unitless-zero'],
112+
'a { padding: 0% 0 0 }',
113+
{
114+
'unitless-zero': true
115+
}
116+
);
117+
});
108118
});

0 commit comments

Comments
 (0)