Gonzales 3.0: Update unitless-zero option

Author: tonyganch

lib/options/unitless-zero.js

@@ -7,17 +7,27 @@ module.exports = {
 
     /**
      * Processes tree node.
-     * @param {String} nodeType
+     *
      * @param {node} node
      */
-    process: function(nodeType, node) {
-        if (nodeType === 'value' || nodeType === 'braces') {
-            node.forEach(function(child, index) {
-                if (
-                    (child[0] === 'percentage' ||
-                    child[0] === 'dimension' && ['cm', 'em', 'ex', 'pt', 'px'].indexOf(child[2][1]) !== -1) &&
-                        child[1][1] === '0') {
-                    node[index] = child[1];
+    process: function(node) {
+        var UNITS = ['cm', 'em', 'ex', 'pt', 'px'];
+
+        if (node.is('value') || node.is('braces')) {
+            node.forEach(function(child) {
+                if (typeof child === 'string') return;
+
+                if (child.is('dimension')) {
+                    var unit = child.get(1).content;
+                    if (child.get(0).content[0] === '0' && UNITS.indexOf(unit) !== -1) {
+                        child.content.splice(1, 1);
+                    }
+                } else if (child.is('percentage')) {
+                    var number = child.get(0).content;
+                    if (number[0] === '0') {
+                        child.type = 'number';
+                        child.content = number;
+                    }
                 }
             });
         }

test/options/unitless-zero/test.js

@@ -1,6 +1,6 @@
 var assert = require('assert');
 
-describe.skip('options/unitless-zero', function() {
+describe('options/unitless-zero', function() {
     it('Should remove units in zero-valued dimensions', function() {
         this.comb.configure({ 'unitless-zero': true });
         assert.equal(
@@ -35,7 +35,7 @@ describe.skip('options/unitless-zero', function() {
         );
     });
 
-    it('Should detect unitless zero option', function() {
+    it.skip('Should detect unitless zero option', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { width: 0 }',
@@ -45,7 +45,7 @@ describe.skip('options/unitless-zero', function() {
         );
     });
 
-    it('Should detect zero with unit', function() {
+    it.skip('Should detect zero with unit', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { width: 0px }',
@@ -55,7 +55,7 @@ describe.skip('options/unitless-zero', function() {
         );
     });
 
-    it('Should detect unitless zero option with multiple values', function() {
+    it.skip('Should detect unitless zero option with multiple values', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { padding: 0px 0 0 }',
@@ -65,7 +65,7 @@ describe.skip('options/unitless-zero', function() {
         );
     });
 
-    it('Should detect zero with unit and multiple values', function() {
+    it.skip('Should detect zero with unit and multiple values', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { padding: 0px 0 0em }',
@@ -75,23 +75,23 @@ describe.skip('options/unitless-zero', function() {
         );
     });
 
-    it('Shouldn’t detect unitless zero option if there is no unit', function() {
+    it.skip('Shouldn’t detect unitless zero option if there is no unit', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { color: red }',
             {}
         );
     });
 
-    it('Shouldn’t detect unitless zero option if there is `deg` unit', function() {
+    it.skip('Shouldn’t detect unitless zero option if there is `deg` unit', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { transform: rotate(0deg) }',
             {}
         );
     });
 
-    it('Should detect unitless zero option with percents', function() {
+    it.skip('Should detect unitless zero option with percents', function() {
         this.shouldDetect(
             ['unitless-zero'],
             'a { padding: 0% 0 0 }',