Eurostat Data Import - Death by week and sex & Divorce indicators#2039
Eurostat Data Import - Death by week and sex & Divorce indicators#2039pravnkumar-cloudsufi wants to merge 13 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces two new Eurostat data imports for weekly deaths and divorce indicators, providing documentation, configuration, and automation scripts. The review identifies several critical issues, including incorrect file paths in the download scripts and missing output columns required for data consistency. Suggestions were also provided to use ISO 8601 week formats for dates to prevent collisions, standardize ratio mappings, and correct markdown formatting in the README files.
372f107 to
9200997
Compare
|
The pull request adds two new Eurostat imports: 'Deaths by week and sex' and 'Divorce indicators'. The structure of the files, including the metadata, PV maps, and run scripts, is consistent with the existing import patterns in the repository. The configuration files and manifests appear to be correctly set up for the |
06b0d2a to
63197a5
Compare
|
Hello @pravnkumar-cloudsufi, thank you for reaching out. I have reviewed the pull request again, and the implementation for both 'Deaths by week and sex' and 'Divorce indicators' remains consistent with the existing import patterns in the repository. The configuration files, manifests, and run scripts are correctly set up for the |
|
Hello @pravnkumar-cloudsufi, thank you for the follow-up. I have reviewed the pull request once more and everything remains consistent with the repository's existing import patterns. The configuration files, manifests, and run scripts are correctly set up for the |
…ion on 1 january by age and sex
1cbd354 to
400b96d
Compare
|
Hello @pravnkumar-cloudsufi, thank you for the tag. As I have previously noted, the technical implementation for both imports is consistent with the repository's patterns and all automated checks have passed. The pull request is technically ready for merge. As you mentioned, the next step is to obtain an approving review from a maintainer with write access to proceed. I have no further technical issues to identify. |
PR Checklist: https://drive.google.com/corp/drive/folders/19uraIXjS3R5bE7_NK8Xl_keFZCZspD5i?resourcekey=0-bEZP1Iy-DmoyBOK3Bmw6yQ
Import Name:
Death by week and sex - EuroStat_Deaths_by_week_and_sex
Divorce indicators - EuroStat_Divorce_Indicators