From 2bd7ca65d1b16b6d7a96ec7dc6aeca23f7030762 Mon Sep 17 00:00:00 2001
From: yaojin <yaojin@58.com>
Date: Wed, 5 Aug 2026 19:13:29 +0800
Subject: [PATCH] fix(security): isolate HTML preview origin

---
 .../src/components/WorkspaceOperationPanel.tsx   |  4 +++-
 .../tests/htmlPreviewSandboxContract.test.mjs    | 16 ++++++++++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 frontend/tests/htmlPreviewSandboxContract.test.mjs

diff --git a/frontend/src/components/WorkspaceOperationPanel.tsx b/frontend/src/components/WorkspaceOperationPanel.tsx
index 23f162656..a299a0897 100644
--- a/frontend/src/components/WorkspaceOperationPanel.tsx
+++ b/frontend/src/components/WorkspaceOperationPanel.tsx
@@ -368,11 +368,13 @@ function HtmlPreviewFrame({
         if (fitRafRef.current != null) cancelAnimationFrame(fitRafRef.current);
     }, []);
 
+    // Keep untrusted agent HTML in an opaque origin: combining scripts and same-origin
+    // would let it access the application's storage and authenticated browser state.
     return (
         <div className="workspace-op-html-fit" ref={containerRef}>
             <iframe
                 ref={frameRef}
-                sandbox="allow-same-origin allow-scripts allow-forms allow-modals allow-popups allow-downloads allow-pointer-lock allow-top-navigation-by-user-activation"
+                sandbox="allow-scripts allow-forms allow-modals allow-popups allow-downloads allow-pointer-lock allow-top-navigation-by-user-activation"
                 src={src}
                 srcDoc={src ? undefined : renderContent}
                 title={title}
diff --git a/frontend/tests/htmlPreviewSandboxContract.test.mjs b/frontend/tests/htmlPreviewSandboxContract.test.mjs
new file mode 100644
index 000000000..94013f65f
--- /dev/null
+++ b/frontend/tests/htmlPreviewSandboxContract.test.mjs
@@ -0,0 +1,16 @@
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import test from 'node:test';
+
+const workspacePanel = readFileSync(
+  new URL('../src/components/WorkspaceOperationPanel.tsx', import.meta.url),
+  'utf8',
+);
+
+test('HTML preview keeps agent-generated scripts in an opaque-origin sandbox', () => {
+  const sandboxMatch = workspacePanel.match(/sandbox="([^"]+)"/);
+
+  assert.ok(sandboxMatch, 'HTML preview iframe must declare a sandbox');
+  assert.match(sandboxMatch[1], /\ballow-scripts\b/);
+  assert.doesNotMatch(sandboxMatch[1], /\ballow-same-origin\b/);
+});