Weird results for Option, Result, anonymous types

[cmeeren]

Consider this:

let data = {| Data = "This is a test"; Sub = {| Foo = Ok 1; Bar = [Some 2] |} |}
Log.Information("Data: {@Data}", data)

I get this:

{"Data": "This is a test", "Sub": {"Bar": [{"Value": 2, "$type": "Some"}], "Foo": {"ResultValue": 1, "$type": "Ok"}, "$type": "<>f__AnonymousType2950936943`2"}, "$type": "<>f__AnonymousType2576086083`2"}

There are several issues:

• "$type": "Some" for Option seems weird
• "$type": "Ok" for Result seems weird
• "$type": "<>f__AnonymousType..." should not be there

Ideally, IMHO, for unions, you'd use a format like https://github.com/Tarmil/FSharp.SystemTextJson with union encoding set to

JsonUnionEncoding.Default
||| JsonUnionEncoding.InternalTag
||| JsonUnionEncoding.NamedFields
// And perhaps also this
||| JsonUnionEncoding.UnwrapFieldlessTags

I would therefore want something like this:

{"Data": "This is a test", "Sub": {"Bar": [2], "Foo": {"Case": "Ok", "ResultValue": 1}}}

I understand that this package is old and not actively maintained. I may end up writing my own library to destructure F# types.

[nblumhardt]

Some updates here, or a new library, would probably both be well-received. There's an open PR that seems to have similar goals, but it's a bit light on details for me to be able to contribute a review (I'm also not sure whether the added dependency is appropriate for all F# consumers).

If you're keen to push this library forward I can help keep the build rolling etc.

I think the main consideration here would just be to show/describe the changes in enough detail that those already using this library can assess potential impact/breakage in their existing systems.

[cmeeren]

After some experimentation, I see that serilog/serilog#1675 solves my problems for destructuring F# types (and everything else). If I release anything, it'll be a new library with that.

[sungam3r]

@cmeeren Is this issue still actual?

[cmeeren]

I haven't used this library for a long time now, but since it's still open I would assume so.

[github-actions]

This issue was marked as stale since it has not been active for a long time

[github-actions]

This issue was marked as stale since it has not been active for a long time