fix(auth): update getRecallerId to cast ID to int

also add test for returning integer ID from remember cookie

Author: hasbi-ashshidiq23

.github/workflows/pull-request-check.yml

@@ -9,20 +9,23 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v3
 
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.2'
+          tools: composer
+          coverage: none
+
       - name: Cache Composer dependencies
         uses: actions/cache@v3
         with:
           path: /tmp/composer-cache
           key: ${{ runner.os }}-${{ hashFiles('composer.lock') }}
 
       - name: Installing dependencies
-        uses: php-actions/composer@v6
-        with:
-          php_version: 8.2
+        env:
+          COMPOSER_CACHE_DIR: /tmp/composer-cache
+        run: composer install --no-interaction --no-progress --prefer-dist
 
       - name: Running unit test
-        uses: php-actions/phpunit@v3
-        with:
-          version: 9.6
-          php_version: 8.2
-          configuration: phpunit.xml
+        run: vendor/bin/phpunit --configuration phpunit.xml

src/Illuminate/Auth/Guard.php

@@ -149,7 +149,6 @@ public function user()
 		// pull the user data on that cookie which serves as a remember cookie on
 		// the application. Once we have a user we can return it to the caller.
 		$recaller = $this->getRecaller();
-
 		if (is_null($user) && ! is_null($recaller))
 		{
 			$user = $this->getUserByRecaller($recaller);
@@ -210,15 +209,14 @@ protected function getRecaller()
 	/**
 	 * Get the user ID from the recaller cookie.
 	 *
-	 * @return string
+	 * @return int
 	 */
-	protected function getRecallerId()
-	{
-		if ($this->validRecaller($recaller = $this->getRecaller()))
-		{
-			return head(explode('|', $recaller));
-		}
-	}
+    protected function getRecallerId()
+    {
+        if ($this->validRecaller($recaller = $this->getRecaller())) {
+            return (int) head(explode('|', $recaller));
+        }
+    }
 
 	/**
 	 * Determine if the recaller cookie is in a valid format.

tests/Auth/AuthGuardTest.php

@@ -374,4 +374,25 @@ public function testUserUsesRememberCookieIfItExists()
 		$this->assertEquals($user->reveal(), $guard->user());
 		$this->assertTrue($guard->viaRemember());
 	}
+
+    public function testGetIdWhenRememberCookieExistsWillReturnIntegerIdFromCookieValue()
+    {
+        $request = Request::create('/', 'GET', [], [
+            'remember_82e5d2c56bdd0811318f0cf078b78bfc' => '123|recaller'
+        ]);
+
+        $this->session->get('login_82e5d2c56bdd0811318f0cf078b78bfc', Argument::any())->will(function ($args) {
+            return $args[1];
+        });
+
+        $guard = new Guard(
+            $this->userProvider->reveal(),
+            $this->session->reveal(),
+            $request
+        );
+
+        $this->assertNotNull($guard->id());
+        $this->assertIsInt($guard->id());
+        $this->assertSame(123, $guard->id());
+    }
 }