Skip to content

Commit 8e07da1

Browse files
committed
fix: fix YAML syntax error in workflow file
- Use heredoc syntax for release notes instead of quoted multi-line string - This avoids YAML parsing issues with special characters - Use --notes-file instead of --notes parameter - Properly escape backslashes in Dockerfile example
1 parent 1f7dc35 commit 8e07da1

1 file changed

Lines changed: 16 additions & 11 deletions

File tree

.github/workflows/publish-to-releases.yml

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -134,30 +134,35 @@ jobs:
134134
135135
echo "Creating release: $RELEASE_TAG"
136136
137-
# Create release dengan artifacts
138-
gh release create "$RELEASE_TAG" \
139-
--title "$RELEASE_NAME" \
140-
--notes "Pre-compiled gRPC extension for PHP ${PHP_VERSION}
137+
# Create release notes file
138+
cat > /tmp/release_notes.txt << 'NOTES'
139+
Pre-compiled gRPC extension for PHP ${PHP_VERSION}
141140

142141
gRPC Version: ${GRPC_VERSION}
143142
PHP Version: ${PHP_VERSION}
144143
Built on: Ubuntu 22.04
145144
Architectures: AMD64, ARM64
146145

147-
Usage in Dockerfile:
146+
## Usage in Dockerfile:
148147

149148
FROM php:${PHP_VERSION}-fpm
150149

151-
RUN curl -L -o /tmp/grpc.so \\
152-
https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-amd64.so && \\
153-
mv /tmp/grpc.so /usr/local/lib/php/extensions/no-debug-non-zts-20220829/grpc.so && \\
154-
docker-php-ext-enable grpc && \\
150+
RUN curl -L -o /tmp/grpc.so \
151+
https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-amd64.so && \
152+
mv /tmp/grpc.so /usr/local/lib/php/extensions/no-debug-non-zts-20220829/grpc.so && \
153+
docker-php-ext-enable grpc && \
155154
rm -rf /tmp/*
156155

157-
Available Downloads:
156+
## Available Downloads:
157+
158158
- grpc-amd64.so: https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-amd64.so
159159
- grpc-arm64.so: https://github.com/${{ github.repository }}/releases/download/${RELEASE_TAG}/grpc-arm64.so
160-
" \
160+
NOTES
161+
162+
# Create release dengan artifacts
163+
gh release create "$RELEASE_TAG" \
164+
--title "$RELEASE_NAME" \
165+
--notes-file /tmp/release_notes.txt \
161166
artifacts/grpc-amd64.so \
162167
artifacts/grpc-arm64.so
163168

0 commit comments

Comments
 (0)