Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Commit deaac5d

Browse files
committed
hack/make.sh remove "latest" symlink
This symlink was added in d427534, to allow finding the path to the latest built binary, because at the time, those paths were prefixed with the version or commit (e.g. `bundles/1.5.0-dev`). Commit bac2447 removed the version-prefix in paths, but kept the old symlink for backward compatiblity. However, many things were moved since then (e.g. paths were renamed to `binary-daemon`, and various other changes). With the symlink pointing to the symlink's parent directory, following the symlink may result into an infinite recursion, which can happen if scripts using wildcards / globbing to find files. With this symlink no longer serving a real purpose, we can probably safely remove this symlink now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit dde1fd78c7c9a142a4099917198e69d88d34d088) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: bb53ea71cb2b6cc2008b5686ac8c12d0a13f9ca5 Component: engine
1 parent ca10879 commit deaac5d

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

components/engine/hack/make.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,6 @@ main() {
179179
fi
180180
mkdir -p bundles
181181

182-
# Windows and symlinks don't get along well
183-
if [ "$(go env GOHOSTOS)" != 'windows' ]; then
184-
rm -f bundles/latest
185-
# preserve latest symlink for backward compatibility
186-
ln -sf . bundles/latest
187-
fi
188-
189182
if [ $# -lt 1 ]; then
190183
bundles=(${DEFAULT_BUNDLES[@]})
191184
else

0 commit comments

Comments
 (0)