Fix hanging on setRawMode, 4.1.0-beta.4

Author: doesdev

lib/cli-char-supported.js

@@ -7,19 +7,22 @@ const xterm = process.env.TERM === 'xterm-256color'
 const charOffset = appleTerm || xterm ? -1 : 0
 
 const checkChar = (char) => new Promise((resolve, reject) => {
-  if (!(process.stdin.isTTY && process.stdin.isTTY)) return resolve(false)
-  setTimeout(() => resolve(false), 250)
+  if (!process.stdin.isTTY) return resolve(false)
   let clean = false
 
   const expect = char.length + 1
   const rawMode = process.stdin.isRaw
-  const cleanup = (supported) => {
+  const cleanup = (supported, force) => {
     if (clean) return
 
     clean = true
 
     process.stdin.removeListener('data', checker)
-    process.stdin.setRawMode(rawMode)
+
+    if (!force) {
+      process.stdin.setRawMode(rawMode)
+    }
+
     process.stdin.unref()
     clearTimeout(timeout)
 
@@ -34,14 +37,15 @@ const checkChar = (char) => new Promise((resolve, reject) => {
     return cleanup(val === expect || ((val + charOffset) === expect))
   }
 
+  const timeout = setTimeout(() => cleanup(false, true), 500)
+
   readline.clearLine(process.stdout, 0)
   readline.cursorTo(process.stdout, 0)
 
   process.stdin.setRawMode(true)
   process.stdin.on('data', checker)
   process.stdout.write(char)
   process.stdout.write(scanner)
-  const timeout = setTimeout(() => cleanup(false), 500)
 })
 
 module.exports = { checkChar, charOffset: Math.abs(charOffset) }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "mvt",
-  "version": "4.1.0-beta.3",
+  "version": "4.1.0-beta.4",
   "description": "Minimum Viable Testing framework",
   "engines": {
     "node": ">=8.0.0"