Skip to content

Commit e9d8ba0

Browse files
Use Assert.Inconclusive for emulator acquisition failures
Emulator acquisition failures are infrastructure issues, not test failures. Using Assert.Inconclusive instead of Assert.IsTrue marks these as skipped/inconclusive rather than turning the build red. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent c4dbc85 commit e9d8ba0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,9 @@ public static void RestartDevice ()
174174
// shell out to msbuild and start the emulator again
175175
var dotnet = new DotNetCLI (Path.Combine (XABuildPaths.TopDirectory, "src", "Xamarin.Android.Build.Tasks", "Tests", "Xamarin.Android.Build.Tests", "Emulator.csproj"));
176176
dotnet.ProjectDirectory = XABuildPaths.TestAssemblyOutputDirectory;
177-
Assert.IsTrue (dotnet.Build ("AcquireAndroidTarget", parameters: new string[] { "TestAvdForceCreation=false", $"Configuration={XABuildPaths.Configuration}" }), "Failed to acquire emulator.");
177+
if (!dotnet.Build ("AcquireAndroidTarget", parameters: new string[] { "TestAvdForceCreation=false", $"Configuration={XABuildPaths.Configuration}" })) {
178+
Assert.Inconclusive ("Failed to acquire emulator.");
179+
}
178180
WaitFor ((int)TimeSpan.FromSeconds (5).TotalMilliseconds);
179181
}
180182

0 commit comments

Comments
 (0)