The full name of a command is generated now in 'cli_register_command' rather than on the fly

Note that the 'cli->commandname' structure member no longer exists

Author: Rob Sanders

libcli.h

@@ -71,7 +71,7 @@ struct cli_def {
   /* internal buffers */
   void *conn;
   void *service;
-  char *commandname;  // temporary buffer for cli_command_name() to prevent leak
+//  char *commandname;  // temporary buffer for cli_command_name() to prevent leak
   char *buffer;
   unsigned buf_size;
   struct timeval timeout_tm;
@@ -102,6 +102,7 @@ enum command_types {
 
 struct cli_command {
   char *command;
+  char *full_command_name;
   int (*callback)(struct cli_def *, const char *, char **, int);
   unsigned int unique_len;
   char *help;

libcli.spec

@@ -67,6 +67,11 @@ rm -rf $RPM_BUILD_ROOT
 %defattr(-, root, root)
 
 %changelog
+* Wed Jan 27 2021 Rob Sa ders <rsanders@forcepoint.com> 1.10.5
+- Fix possible error where cli_command_name() returns a NULL by
+  generating full command name when a command is registered. 
+  Note - removed cli->commandname member
+
 * Thu Jan 14 2021 Rob Sanders <rsanders@forcepoint.com> 1.10.5
 - Fix issue where the help for 'long command name' winds up running into
   the actual help text w/o any spaces.  Now a long command will be on a line