Issue #2898258 followup: Improve the update hook by copying the one from core.

Author: bojanz

modules/product/commerce_product.post_update.php

@@ -5,6 +5,8 @@
  * Post update functions for Product.
  */
 
+use Drupal\Core\Entity\Entity\EntityFormDisplay;
+
 /**
  * Revert the Products view because of the updated permission.
  */
@@ -102,33 +104,19 @@ function commerce_product_post_update_3() {
 }
 
 /**
- * Revert the default product form display.
+ * Expose the status field on every product form.
  */
 function commerce_product_post_update_4() {
-  /** @var \Drupal\commerce\Config\ConfigUpdaterInterface $config_updater */
-  $config_updater = \Drupal::service('commerce.config_updater');
-
-  $views = [
-    'core.entity_form_display.commerce_product.default.default',
-  ];
-  $result = $config_updater->revert($views, TRUE);
-
-  $success_results = $result->getSucceeded();
-  $failure_results = $result->getFailed();
-  $message = '';
-  if ($success_results) {
-    $message = t('Succeeded:') . '<br>';
-    foreach ($success_results as $success_message) {
-      $message .= $success_message . '<br>';
-    }
-    $message .= '<br>';
-  }
-  if ($failure_results) {
-    $message .= t('Failed:') . '<br>';
-    foreach ($failure_results as $failure_message) {
-      $message .= $failure_message . '<br>';
-    }
+  $query = \Drupal::entityQuery('entity_form_display')->condition('targetEntityType', 'commerce_product');
+  $ids = $query->execute();
+  $form_displays = EntityFormDisplay::loadMultiple($ids);
+  foreach ($form_displays as $id => $form_display) {
+    /** @var \Drupal\Core\Entity\Display\EntityDisplayInterface $form_display */
+    $form_display->setComponent('status', [
+      'type' => 'boolean_checkbox',
+      'settings' => [
+        'display_label' => TRUE,
+      ],
+    ])->save();
   }
-
-  return $message;
 }