[Chore] De-duplicate shared helpers between testnet-load.sh and testnet-load-v2.sh

[collinsezedike]

Summary

scripts/testnet-load.sh and scripts/testnet-load-v2.sh duplicate roughly 80 lines of near-identical helper code: log/log_success/log_error, get_time/elapsed_time/avg_time, gen_key, balance, and invoke_contract. Both scripts were written independently (v1's load test, then v2's mirroring its structure) and the shared parts were never factored out.

Scope

• Extract the common helpers into a shared file, e.g. scripts/lib/load-test-common.sh, sourced by both testnet-load.sh and testnet-load-v2.sh.
• No behavior change: both scripts should produce identical output/results before and after, just with the duplicated code removed from each in favor of one shared source.
• Keep whatever's genuinely script-specific (contract-specific parameters, phase logic, the v2 script's network_id/json_field/commitment-computation helpers) where it is; only extract what's actually identical between the two.
• Update shellcheck scripts/*.sh (CI) to still pass; a sourced lib file under scripts/lib/ may need its own shellcheck pass or an explicit include in the CI glob, check this before assuming it's covered automatically.

Proposed approach

Diff the two scripts to confirm the exact set of duplicated functions, move them verbatim into the new shared file, then replace each script's own copy with a source line near the top (using the same CONTRACT_DIR-relative pattern both scripts already use for WASM_PATH).

[olathedev]

Hello maintainer, I’d like to work on this issue. I’m comfortable working with shell scripts and refactoring shared logic without changing existing behavior.

I’d extract the genuinely duplicated helpers into a shared library, update both scripts to source it, and verify the scripts and ShellCheck still pass without affecting their existing output or behavior.

[collinsezedike]

Good plan. One thing the issue flags, I'd want to confirm you've thought through it. CI runs shellcheck scripts/*.sh. That glob won't automatically pick up a new file under scripts/lib/. Are you planning to put the shared file directly in scripts/ instead, or update the CI glob/workflow to include the lib directory?

Also curious, have you done a similar shared-helper extraction across bash scripts before? Anything you'd watch for around set -euo pipefail behavior or variable scoping when sourcing one script from another?

[grantfox-oss]

🦊 GrantFox — @olathedev has been assigned to this issue as part of the Third Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #97)
2. Your PR will be reviewed by the drydocs maintainers

Good luck! Track your progress on GrantFox.

[collinsezedike]

Hey @olathedev, checking in, no rush. Following up on the shellcheck-glob question from before, let me know what you decided and if you're still good to proceed.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!

@olathedev's PR #110 was approved and merged by @collinsezedike.

🏆 @olathedev: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (392 total points). Track your full progress on GrantFox.

👏 Great work, @olathedev! Keep contributing to drydocs.