Skip to content

Validate any spawned commit transaction prior adding them to the wallet #1050

Description

@frolosofsky

As has been described in the #996 (comment), node could keep invalid spawned finalizer commit transactions in the wallet because there's a lack of validation of them prior adding to the wallet.

This could be fixed in a similar way as #1040 does it for deposit transactions. @kostyantyn also came with a proposal to use ContextualCheck: #1040 (comment). 3rd option is to apply the full transaction validation path.

User-driven commits (definitely must be fixed):

System-driven commits (needs more investigation):

  • vote
  • slash

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA problem of existing functionalitywallet

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions