Enable native input for internal builds#8588
Draft
malmstein wants to merge 1 commit into
Draft
Conversation
Flip the nativeInputField feature flag default to INTERNAL and remove the now-redundant user toggle from AI Features settings. Widget visibility is driven by the feature flag, with the existing observer API in DuckChat backed by the cached flag value so all consumers (omnibar, NTP, system search, native and contextual input managers, JS helper) pick it up unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1214735022214304?focus=true
Description
Flips the
nativeInputFieldfeature flag default fromFALSEtoINTERNALso internal builds get the native input widget automatically, and removes the now-redundant "Native Input Field" user toggle from AI Features settings. The widget is now shown purely based on the feature flag.Implementation notes:
RealDuckChatcachesduckChatFeature.nativeInputField().isEnabled()in aMutableStateFlowpopulated fromcacheConfig(). The existingobserveNativeInputFieldUserSettingEnabled()API stays onDuckChatand emits from that flow, so all consumers (omnibar layout, NTP, system search, native input manager, contextual native input manager, JS helper,cacheUserSettings) keep working without call-site changes.DuckChatInternal/repository/data store, observe + read methods removed from repository/data store, preference key removed.DuckChatJSHelper'sSUPPORTS_NATIVE_CHAT_INPUT/SUPPORTS_NATIVE_PROMPTnow read the feature flag directly.Steps to test this PR
Internal build
./gradlew :app:installInternalDebug)Play build (flag off by default)
./gradlew :app:installPlayDebug)aiChat / nativeInputFieldto enabled via the feature flags debug screen and relaunch — confirm the native input widget now appearsUI changes
Note
Medium Risk
Changes how the native Duck.ai input is enabled by removing persisted user settings and switching gating to a remote feature flag, which could alter behavior for users/build variants if the flag state is misconfigured.
Overview
Enables Duck.ai native input for internal builds by default by changing
nativeInputField’s default toggle value toINTERNALand treating it as a capability/feature flag rather than a user preference.Removes the “Native Input Field” setting from AI Features settings (UI, strings, ViewModel wiring) and deletes the associated repository/data-store plumbing and preference key;
RealDuckChatnow caches the flag in-memory and exposes it via the existingobserveNativeInputFieldUserSettingEnabled()API to avoid call-site changes.Updates
DuckChatJSHelperto reportSUPPORTS_NATIVE_CHAT_INPUT/SUPPORTS_NATIVE_PROMPTdirectly from thenativeInputFieldfeature flag, and adjusts tests to reflect the new flag-driven behavior.Reviewed by Cursor Bugbot for commit 2151b75. Bugbot is set up for automated code reviews on this repo. Configure here.