We obviously use pointers types a lot in the C++ code. For example we do
auto x_ptr = graph.emplace_node<BinaryNode>();
IMO we should be using qualified auto in these places
auto* x_ptr = graph.emplace_node<BinaryNode>();
for readability.
Obviously there is a semantic difference if later we need to do say decltype(auto) but in most places we never inspect the auto and the latter conveys more meaning.
See
We obviously use pointers types a lot in the C++ code. For example we do
auto x_ptr = graph.emplace_node<BinaryNode>();IMO we should be using qualified
autoin these placesauto* x_ptr = graph.emplace_node<BinaryNode>();for readability.
Obviously there is a semantic difference if later we need to do say
decltype(auto)but in most places we never inspect theautoand the latter conveys more meaning.See