Skip to content

Commit 204717c

Browse files
committed
[GEF] Remove obsolete EditPartVisitor
The `EditPartVisitor` is only used within the `MenuObjectEditPart` to refresh all other `MenuObjectEditPart`s. Rather than using a visitor, we can simply iterate over the edit-part registry.
1 parent 157c760 commit 204717c

3 files changed

Lines changed: 4 additions & 65 deletions

File tree

org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/core/EditPart.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
*******************************************************************************/
1313
package org.eclipse.wb.gef.core;
1414

15-
import org.eclipse.wb.internal.gef.core.EditPartVisitor;
16-
1715
import org.eclipse.gef.EditPolicy;
1816
import org.eclipse.gef.Request;
1917
import org.eclipse.gef.commands.Command;
@@ -68,23 +66,6 @@ protected List<?> getModelChildren() {
6866
return Collections.EMPTY_LIST;
6967
}
7068

71-
////////////////////////////////////////////////////////////////////////////
72-
//
73-
// Visiting
74-
//
75-
////////////////////////////////////////////////////////////////////////////
76-
/**
77-
* Visits this {@link EditPart} and its children using given {@link EditPartVisitor}.
78-
*/
79-
public final void accept(EditPartVisitor visitor) {
80-
if (visitor.visit(this)) {
81-
for (EditPart childPart : (List<EditPart>) getChildren()) {
82-
childPart.accept(visitor);
83-
}
84-
visitor.endVisit(this);
85-
}
86-
}
87-
8869
////////////////////////////////////////////////////////////////////////////
8970
//
9071
// EditPart

org.eclipse.wb.core/src-gef/org/eclipse/wb/internal/gef/core/EditPartVisitor.java

Lines changed: 0 additions & 36 deletions
This file was deleted.

org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/part/menu/MenuObjectEditPart.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.eclipse.wb.internal.core.model.menu.IMenuObjectInfo;
2121
import org.eclipse.wb.internal.core.model.menu.IMenuObjectListener;
2222
import org.eclipse.wb.internal.core.model.menu.MenuObjectInfoUtils;
23-
import org.eclipse.wb.internal.gef.core.EditPartVisitor;
2423
import org.eclipse.wb.internal.gef.core.IActiveToolListener;
2524

2625
import org.eclipse.gef.EditPart;
@@ -206,16 +205,11 @@ public EditPart getTargetEditPart(org.eclipse.gef.Request request) {
206205
public void run() {
207206
try {
208207
MenuObjectInfoUtils.m_selectingObject = m_object;
209-
((org.eclipse.wb.gef.core.EditPart)getViewer().getRootEditPart()).accept(new EditPartVisitor() {
210-
@Override
211-
public boolean visit(EditPart editPart) {
212-
if (editPart instanceof MenuObjectEditPart) {
213-
editPart.refresh();
214-
return false;
215-
}
216-
return true;
208+
for (EditPart editPart : getViewer().getEditPartRegistry().values()) {
209+
if (editPart instanceof MenuObjectEditPart) {
210+
editPart.refresh();
217211
}
218-
});
212+
}
219213
} finally {
220214
MenuObjectInfoUtils.m_selectingObject = null;
221215
}

0 commit comments

Comments
 (0)