USE_CUTOFF selects the inverse of documented behavior on Radarr, Whisparr, and Readarr

[egg82]

USE_CUTOFF selects the inverse of what's documented on Radarr, Whisparr, and Readarr. README:292 describes it as "Select for items that do not meet their profile cutoff", but on these three the filter skips exactly the upgradable items and searches the ones already at cutoff. Sonarr and Lidarr are correct, which is what makes the other three unambiguous.

Radarr (RadarrUpdater.java:123) and Whisparr (WhisparrUpdater.java:123), identical:

if (useCutoff && (movieFile == null || movieFile.qualityCutoffNotMet())) {
    // ...skips
    logger.info("Skipping movie {} (\"{}\") because it meets the quality cutoff", ...);

The skip fires when qualityCutoffNotMet() is true, and the log line reports the opposite of the condition that fired — so the logs actively mislead anyone debugging it. The movieFile == null clause compounds it: with MISSING_STATUS=missing, :102 skips everything with a file and :123 skips everything left, so the selection is empty.

Compare Sonarr (SonarrUpdater.java:145-163), which computes cutoffMet and skips on that.

Readarr (ReadarrUpdater.java:158-165) is inverted by a stray negation instead — if (!b.qualityCutoffNotMet()).

Fix on Radarr/Whisparr: skip only when the movie has a file and its cutoff is met — useCutoff && movieFile != null && !movieFile.qualityCutoffNotMet() — which also removes the empty-set interaction.

Read from source; not run.

---

Found with Claude Code.

[egg82]

Correcting an error in how I originally filed this: I wrote that the Readarr fix was "just dropping the stray negation, matching LidarrUpdater.java:162". Dropping the negation does fix the inversion, but it does not reach parity with Lidarr and I shouldnt have implied it did — BookFileResource carries path/size/quality, so it only exists for files that exist, and there is no null case corresponding to Lidarrs trackFile == null. An author with a wholly missing book returns fewer resources, cutoffMet stays true, and the author is skipped. Body updated.

[egg82]

Still nailing down this "bug hunting" skill. In hindsight fetcharr wasn't a good repo to throw claude at to work on this concept but here we are. At least the issue is real.