feat(newsletters): newsletter entities + renderer (Wave 3, Spring - partial)#63
Open
mpge wants to merge 1 commit into
Open
feat(newsletters): newsletter entities + renderer (Wave 3, Spring - partial)#63mpge wants to merge 1 commit into
mpge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 3 partial port of the newsletter engine to Spring Boot / JPA. Entities + renderer + themes. DB-bound services are a follow-up.
dev/escalated/models/newsletter/Contact.marketingOptOutAtfield addedservices/newsletter/NewsletterRenderer.java— full renderer (Markdown → theme → click rewrite → pixel injection)resources/templates/escalated/newsletter_themes/using{{key}}/{{{key}}}substitutionArchitecture notes
spring.jpa.hibernate.ddl-auto=update, or hosts using a migration tool generate the SQL from these@Entityclasses.NewsletterRenderer.Options.markdownToHtml(recommended:flexmark-javaorcommonmark-java).{{key}}/{{{key}}}substitution — no Thymeleaf dependency for the renderer (themes still live underresources/templates/so Thymeleaf-using hosts can re-render through their own view layer).BaseEntityforid/createdAt/updatedAt(NewsletterDelivery does not extend it because it omitsupdatedAtfor write-volume reasons).Out of scope / follow-ups
JpaRepositorys@Scheduledtask for the dispatcher tickReviewer notes