Skip to content

Commit 90101e1

Browse files
committed
chore(config): switch nodeModulesDir from auto to manual for pnpm
1 parent ae8a203 commit 90101e1

8 files changed

Lines changed: 987 additions & 1326 deletions

File tree

.claude/skills/javascript-practices/references/rules.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ Correct:
801801
```json
802802
// Root deno.json
803803
{
804-
"nodeModulesDir": "auto",
804+
"nodeModulesDir": "manual",
805805
"workspace": ["./apps/webclient"],
806806
"compilerOptions": {
807807
"jsx": "react-jsx",
@@ -825,7 +825,7 @@ Incorrect:
825825
// apps/webclient/deno.json - workspace member with root-only keys
826826
{
827827
"name": "@aya/webclient",
828-
"nodeModulesDir": "auto",
828+
"nodeModulesDir": "manual",
829829
"compilerOptions": { "jsx": "react-jsx" }
830830
}
831831
```

.claude/skills/tooling-standards/references/rules.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ package to wire up the graph.
8888

8989
```json
9090
{
91-
"nodeModulesDir": "auto",
91+
"nodeModulesDir": "manual",
9292
"lint": { "rules": { "tags": ["recommended"] } },
9393
"exclude": [".git", "node_modules/", "etc/templates/"]
9494
}

deno.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
2-
"nodeModulesDir": "auto",
2+
"nodeModulesDir": "manual",
3+
"lock": false,
34
"unstable": [
45
"bundle",
56
"sloppy-imports",

etc/adrs/0002-bundler-external-import-specifiers.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ await bundleServerComponents(
101101
);
102102
```
103103

104-
Deno's native resolution with `nodeModulesDir: "auto"` handles npm package
104+
Deno's native resolution with `nodeModulesDir: "manual"` handles npm package
105105
resolution from `node_modules`.
106106

107107
### Client Bundling with Import Map Resolver
@@ -146,11 +146,11 @@ project/
146146
│ └── lodash/ ← lodash resolves here
147147
├── dist/
148148
│ └── bundle.js ← bundled code with bare imports
149-
├── deno.json ← nodeModulesDir: "auto" for Deno
149+
├── deno.json ← nodeModulesDir: "manual" for Deno
150150
└── package.json ← dependencies for npm/bun
151151
```
152152

153-
**Deno**: With `"nodeModulesDir": "auto"` in `deno.json`, Deno creates
153+
**Deno**: With `"nodeModulesDir": "manual"` in `deno.json`, PNPM creates
154154
`node_modules` from JSR/npm dependencies and uses it for resolution.
155155

156156
**Node.js**: Standard `node_modules` resolution per Node.js module algorithm.

pkg/@eserstack/laroux-server/adapters/react/ssr-renderer.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
*/
1515

1616
import { cloneElement, createElement, Fragment, Suspense } from "react";
17-
// @ts-ignore - react-dom/server types
1817
import { renderToReadableStream } from "react-dom/server";
1918
import {
2019
isClientReference,
@@ -678,7 +677,7 @@ export async function renderSSR(
678677

679678
// Render to HTML using React's renderToReadableStream
680679
const stream = await renderToReadableStream(processedElement, {
681-
onError: (error: Error) => {
680+
onError: (error: unknown) => {
682681
ssrLogger.error("SSR render error:", error);
683682
},
684683
});

pkg/@eserstack/laroux-server/deno.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55
"@std/assert": "jsr:@std/assert@^1.0.16",
66
"@std/cli": "jsr:@std/cli@^1.0.25",
77
"@std/media-types": "jsr:@std/media-types@^1.1.0",
8-
"@std/path": "jsr:@std/path@^1.1.4",
9-
"react": "npm:react@^19.2.3",
10-
"react/jsx-runtime": "npm:react@^19.2.3/jsx-runtime",
11-
"react-dom/server": "npm:react-dom@^19.2.3/server"
8+
"@std/path": "jsr:@std/path@^1.1.4"
129
},
1310
"exports": {
1411
".": "./main.ts",

pkg/@eserstack/laroux-server/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
},
3131
"devDependencies": {
3232
"@std/assert": "npm:@jsr/std__assert@^1.0.16",
33+
"@types/react-dom": "^19.0.0",
3334
"esbuild": "^0.28.0"
3435
}
3536
}

0 commit comments

Comments
 (0)