reserve the String Length in urlDecode to avoid String Reallocations

Lan-Hekary · Lan-Hekary · commit 9ae9c5b633b1 · 2024-04-14T20:19:15.000+02:00
diff --git a/libraries/ESP8266WebServer/src/Parsing-impl.h b/libraries/ESP8266WebServer/src/Parsing-impl.h
@@ -514,6 +514,7 @@ String ESP8266WebServerTemplate<ServerType>::urlDecode(const String& text)
   char temp[] = "0x00";
   unsigned int len = text.length();
   unsigned int i = 0;
+  decoded.reserve(len - (std::count(text.begin(), text.end(), '%') * 2));
   while (i < len)
   {
     char decodedChar;

Original file line number	Diff line number	Diff line change
`@@ -514,6 +514,7 @@ String ESP8266WebServerTemplate<ServerType>::urlDecode(const String& text)`
`514`	`514`	`char temp[] = "0x00";`
`515`	`515`	`unsigned int len = text.length();`
`516`	`516`	`unsigned int i = 0;`
	`517`	`+ decoded.reserve(len - (std::count(text.begin(), text.end(), '%') * 2));`
`517`	`518`	`while (i < len)`
`518`	`519`	`{`
`519`	`520`	`char decodedChar;`