Skip to content

Commit ff0642d

Browse files
committed
Update smoke and snapshot to pass
1 parent 68890dd commit ff0642d

3 files changed

Lines changed: 84 additions & 70 deletions

File tree

test/analyzers/gigasecond/__snapshots__/snapshot.ts.snap

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4202,18 +4202,28 @@ exports[`When running analysis on gigasecond fixtures and expecting it to disapp
42024202
IsolatedAnalyzerOutput {
42034203
"comments": Array [
42044204
CommentImpl {
4205-
"externalTemplate": "javascript.generic.prefer_const_over_let_and_var",
4206-
"message": "Instead of \`let gigasecondAnniversary\`, consider using \`const\`.
4205+
"externalTemplate": "javascript.gigasecond.prefer_top_level_constant",
4206+
"message": "Your solution current has a magic number, or rather a magic expression. Consider
4207+
extracting the gigasecond number into a top-level constant, so that you may
4208+
remember what it represents if you ever come back to this code.
42074209

4208-
\`const\` is a signal that the identifier won't be reassigned, which SHOULD be
4209-
true for this top-level constant. (Not to be confused with _immutable values_).",
4210-
"template": "Instead of \`%{kind} %{name}\`, consider using \`const\`.
4210+
\`\`\`javascript
4211+
const GIGASECOND_IN_MS = 1e12
42114212

4212-
\`const\` is a signal that the identifier won't be reassigned, which SHOULD be
4213-
true for this top-level constant. (Not to be confused with _immutable values_).",
4213+
export const gigasecond = (...)
4214+
\`\`\`",
4215+
"template": "Your solution current has a magic number, or rather a magic expression. Consider
4216+
extracting the gigasecond number into a top-level constant, so that you may
4217+
remember what it represents if you ever come back to this code.
4218+
4219+
\`\`\`javascript
4220+
const %{name} = %{value}
4221+
4222+
export const gigasecond = (...)
4223+
\`\`\`",
42144224
"variables": Object {
4215-
"kind": "let",
4216-
"name": "gigasecondAnniversary",
4225+
"name": "GIGASECOND_IN_MS",
4226+
"value": "1e12",
42174227
},
42184228
},
42194229
CommentImpl {

0 commit comments

Comments
 (0)