Copr builds single .src.rpm for all OS versions, even if they need to differ

[adelton]

I my .spec file I had to add a conditional

 Patch5: edgetx-simulator-name.patch
 Patch6: build-simulator.sh.patch
+%if 0%{?fedora} >= 43
 Patch7: edgetx-miniz.patch
+%endif

to be able to build the rpm both on Fedora 42- and Fedora 43+.

However, https://copr.fedorainfracloud.org/coprs/adelton/edgetx-companion-2.11/build/9911873/ then failed on fedora-43-x86_64 with

RPM build errors:
error: Bad file: /builddir/build/SOURCES/edgetx-miniz.patch: No such file or directory
    Bad file: /builddir/build/SOURCES/edgetx-miniz.patch: No such file or directory

Looking at Source build logs, the .src.rpm was built only once, on Fedora 42, which is likely the reason the edgetx-miniz.patch did not get included.

I use the make_srpm mechanism to build the .src.rpm. How do I make copr to build separate .src.rpm on each target OS / Fedora version?

[FrostyX]

Hello @adelton,
thank you for the report.

I think this is #1315 ... which had some recent comments by @praiskup so fingers crossed.

The workaround for the time being could be using Custom source method instead of make_srpm.

[praiskup]

The workaround for the time being could be using Custom source method instead of make_srpm.

Indeed, that could help, at least if - by chance - any of the available chroots allow you to create a source RPM that wraps "a complete set of sources" in the resulting source RPM (we are talking about the "proxy dist-git" instance, we really just need to "transport" sources from a builder machine into Copr's dist-git cache).

I use the make_srpm mechanism to build the .src.rpm. How do I make copr to build separate .src.rpm on each target OS / Fedora version?

Well, long term vision is to avoid generating source RPMs. Generating srpms is not a generally "safe" operation, and then - the resulting artifact is architecture specific. Something like release-engineering/dist-git#72 would be much better for our purposes.

[adelton]

The problem with both #1315 (Allow choosing chroot where the imported src.rpm sources are built) and the Custom source method seems to be that they somehow assume that the user wants to select or specify the chroot, and I assume one chroot.

In my case I don't care. Or rather, I don't really want to be in the business of specifying the chroot. Currently the https://copr.fedorainfracloud.org/coprs/adelton/edgetx-companion-2.11 has Fedora 41 to Fedora rawhide specified (granted, we could drop the 41 now that it has been EOL) as chroot and resulting repo and the Follow Fedora branching option is enabled so it will get Fedora 44 eventually, and I don't (want to) deal with Copr manually -- the builds get triggered by a webhook from GitHub.

Is it some data model which forces only one .src.rpm per build, or what does prevent the .src.rpm to be built in every chroot in which the the binary rpm will be run, no matter how many of those chroots there are?

[adelton]

I went with the conditional %if ... %endif around the Patchx element because I quite like to keep the %autosetup approach.

I could of course just have all patches in all .src.rpms and be conditional about their use but then I'd need to repeat the list with %patch, or come up with some %autopatch arithmetics ...

[praiskup]

In my case I don't care. Or rather, I don't really want to be in the business of specifying the chroot.

I understand the perspective and agree, but unfortunately, there is only one source RPM that is sent to and imported by copr-dist-git. Given this limitation, we can only consider workarounds. Since make srpm is under your control, could you use the rpmbuild option --define fedora 43?

[adelton]

That worked:

• adelton/edgetx-fedora@fdf26b0
• https://copr.fedorainfracloud.org/coprs/adelton/edgetx-companion-2.11/build/9914487/

Thanks for the hint.