Skip to content

Commit dc447bd

Browse files
committed
address PR feedback
1 parent 1b05fb2 commit dc447bd

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

src/app/firebase-namespace.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,6 @@ export class FirebaseNamespace {
279279
return Object.assign(fn, { AppCheck: appCheck });
280280
}
281281

282-
283-
284282
// TODO: Change the return types to app.App in the following methods.
285283

286284
/**
@@ -399,8 +397,6 @@ function extendApp(app: AppCore): App {
399397
return fn(app);
400398
};
401399

402-
403-
404400
(result as any).__extended = true;
405401
return result;
406402
}

src/phone-number-verification/token-verifier.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ export class PhoneNumberTokenVerifier {
3131

3232
constructor(
3333
jwksUrl: string,
34-
private issuer: string,
35-
private tokenInfo: FirebasePhoneNumberTokenInfo,
34+
private readonly issuer: string,
35+
private readonly tokenInfo: FirebasePhoneNumberTokenInfo,
3636
private readonly app: App
3737
) {
3838

0 commit comments

Comments
 (0)