Skip to content

Commit 2a0a8c7

Browse files
committed
Use CSS transitions for the Home page animations.
1 parent 191ff2e commit 2a0a8c7

2 files changed

Lines changed: 11 additions & 14 deletions

File tree

src/components/app/Home.css

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,18 +172,23 @@
172172

173173
/* Only show the home transition when reduced motion is not preferred */
174174
@media (prefers-reduced-motion: no-preference) {
175-
.homeTransition-enter {
175+
.homeTransition-preEnter {
176176
opacity: 0.1;
177177
transform: translateX(100px);
178178
}
179179

180-
.homeTransition-enter.homeTransition-enter-active {
180+
.homeTransition-entering {
181181
opacity: 1;
182182
transform: translateX(0);
183183
transition:
184184
opacity 300ms ease-out,
185185
transform 300ms ease-out;
186186
}
187+
188+
.homeTransition-entered {
189+
opacity: 1;
190+
transform: translateX(0);
191+
}
187192
}
188193

189194
.homeSectionUploadFromFileInput {

src/components/app/Home.tsx

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {
1616
triggerLoadingFromUrl,
1717
} from 'firefox-profiler/actions/receive-profile';
1818
import type { BrowserConnection } from 'firefox-profiler/app-logic/browser-connection';
19-
import { CSSTransition, TransitionGroup } from 'react-transition-group';
2019
import {
2120
queryIsMenuButtonEnabled,
2221
enableMenuButton,
@@ -182,15 +181,8 @@ function DocsButton() {
182181
);
183182
}
184183

185-
function InstructionTransition(props: { children: React.ReactNode }) {
186-
return (
187-
<CSSTransition
188-
{...props}
189-
classNames="homeTransition"
190-
timeout={300}
191-
exit={false}
192-
/>
193-
);
184+
function InstructionTransition({ children }: { children: React.ReactNode }) {
185+
return <div className="homeTransition-entered">{children}</div>;
194186
}
195187

196188
type OwnHomeProps = {
@@ -590,9 +582,9 @@ class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
590582
faster.
591583
</p>
592584
</Localized>
593-
<TransitionGroup className="homeInstructionsTransitionGroup">
585+
<div className="homeInstructionsTransitionGroup">
594586
{this._renderInstructions()}
595-
</TransitionGroup>
587+
</div>
596588
<section className="homeAdditionalContent">
597589
{/* Grid container: homeAdditionalContent */}
598590
<h2 className="homeAdditionalContentTitle protocol-display-xs">

0 commit comments

Comments
 (0)