Skip to content

Incorrect <link rel="canonical" ...> in documentation #31

Description

@maxnikulin

HTML markup on documentation pages contains incorrect <link rel="canonical" ...> elements:

curl -s  'https://firewalld.org/documentation/' | grep 'link rel="canonical"'
  <link rel="canonical" href="/documentation/">
<link rel="canonical" href="firewalld.github.io/documentation/" />
  1. There should be just one canonical link.
  2. Second link is treated as relative to https://firewalld.org/documentation/, so https://firewalld.org/documentation/firewalld.github.io/documentation/ is certainly an error. Likely, having a dedicated domain, you do not want to consider github.io is the primary location.

Perhaps the theme used to generate documentation should be fixed to avoid github.io links.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions