From 0f2c7ebf176202804f44b0e0ab7b58c08e0ac7fc Mon Sep 17 00:00:00 2001 From: Ilja <2098356+iljah@users.noreply.github.com> Date: Tue, 23 Jun 2026 11:26:10 +0000 Subject: [PATCH 1/2] Remove hidden open warning from vlsv_reader_parallel.h --- vlsv_reader_parallel.h | 1 + 1 file changed, 1 insertion(+) diff --git a/vlsv_reader_parallel.h b/vlsv_reader_parallel.h index 98a7754..a855e1c 100644 --- a/vlsv_reader_parallel.h +++ b/vlsv_reader_parallel.h @@ -42,6 +42,7 @@ namespace vlsv { uint64_t getBytesRead(); double getReadTime() const; bool getUniqueAttributeValues(const std::string& tagName,const std::string& attribName,std::set& output) const; + using Reader::open; bool open(const std::string& fname,MPI_Comm comm,const int& masterRank,MPI_Info mpiInfo=MPI_INFO_NULL); bool readArrayMaster(const std::string& tagName,const std::list >& attribs, const uint64_t& begin,const uint64_t& amount,char* buffer); From daad720da4cc8a8abb11b274a4564482bf231bae Mon Sep 17 00:00:00 2001 From: Ilja <2098356+iljah@users.noreply.github.com> Date: Fri, 24 Jul 2026 07:13:16 +0000 Subject: [PATCH 2/2] Add comments to vlsv_reader_parallel.h --- vlsv_reader_parallel.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vlsv_reader_parallel.h b/vlsv_reader_parallel.h index a855e1c..aaca094 100644 --- a/vlsv_reader_parallel.h +++ b/vlsv_reader_parallel.h @@ -42,11 +42,11 @@ namespace vlsv { uint64_t getBytesRead(); double getReadTime() const; bool getUniqueAttributeValues(const std::string& tagName,const std::string& attribName,std::set& output) const; - using Reader::open; + using Reader::open; // make inherited open accessible bool open(const std::string& fname,MPI_Comm comm,const int& masterRank,MPI_Info mpiInfo=MPI_INFO_NULL); bool readArrayMaster(const std::string& tagName,const std::list >& attribs, const uint64_t& begin,const uint64_t& amount,char* buffer); - using Reader::readArray; + using Reader::readArray; // make inherited readArray accessible bool readArray(const std::string& tagName,const std::list >& attribs, const uint64_t& begin,const uint64_t& amount,char* buffer);