Skip to content

Commit 590bd2a

Browse files
avasummergregkh
authored andcommitted
ALSA: wavefront: Clear substream pointers on close
commit e11c5c1 upstream. Clear substream pointers in close functions to avoid leaving dangling pointers, helping to improve code safety and prevents potential issues. Reported-by: Yuhao Jiang <danisjiang@gmail.com> Reported-by: Junrui Luo <moonafterrain@outlook.com> Fixes: 1da177e ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Junrui Luo <moonafterrain@outlook.com> Link: https://patch.msgid.link/SYBPR01MB7881DF762CAB45EE42F6D812AFC2A@SYBPR01MB7881.ausprd01.prod.outlook.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 343fa98 commit 590bd2a

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

sound/isa/wavefront/wavefront_midi.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ static int snd_wavefront_midi_input_close(struct snd_rawmidi_substream *substrea
278278
return -EIO;
279279

280280
guard(spinlock_irqsave)(&midi->open);
281+
midi->substream_input[mpu] = NULL;
281282
midi->mode[mpu] &= ~MPU401_MODE_INPUT;
282283

283284
return 0;
@@ -300,6 +301,7 @@ static int snd_wavefront_midi_output_close(struct snd_rawmidi_substream *substre
300301
return -EIO;
301302

302303
guard(spinlock_irqsave)(&midi->open);
304+
midi->substream_output[mpu] = NULL;
303305
midi->mode[mpu] &= ~MPU401_MODE_OUTPUT;
304306
return 0;
305307
}

0 commit comments

Comments
 (0)