Skip to content

Commit 828b59f

Browse files
Maximilian Immanuel Brandtnergregkh
authored andcommitted
virtio_console: fix order of fields cols and rows
commit 5326ab7 upstream. According to section 5.3.6.2 (Multiport Device Operation) of the virtio spec(version 1.2) a control buffer with the event VIRTIO_CONSOLE_RESIZE is followed by a virtio_console_resize struct containing cols then rows. The kernel implements this the wrong way around (rows then cols) resulting in the two values being swapped. Signed-off-by: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com> Message-Id: <20250324144300.905535-1-maxbr@linux.ibm.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Cc: Filip Hejsek <filip.hejsek@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1b9c118 commit 828b59f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/char/virtio_console.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1579,8 +1579,8 @@ static void handle_control_message(struct virtio_device *vdev,
15791579
break;
15801580
case VIRTIO_CONSOLE_RESIZE: {
15811581
struct {
1582-
__virtio16 rows;
15831582
__virtio16 cols;
1583+
__virtio16 rows;
15841584
} size;
15851585

15861586
if (!is_console_port(port))

0 commit comments

Comments
 (0)