chore: update to latest eslint

Author: Tom Kirkpatrick

.eslintrc

@@ -1,4 +1,7 @@
 {
   "extends": "fullcube",
-  "root": true
+  "root": true,
+  "rules": {
+    "no-process-env": 0
+  }
 }

lib/index.js

@@ -1,4 +1,3 @@
-/* eslint filenames/match-regex: 0 */
 'use strict'
 
 const debug = require('debug')('loopback:component:ping')

lib/setup-model.js

@@ -1,13 +1,15 @@
-/* eslint global-require: 0 */
+'use strict'
+
 const debug = require('debug')('loopback:component:ping')
 const modelDefinition = require('./models/ping.json')
+const ping = require('./models/ping')
 
 // Remove properties that will confuse LB
 function getModelSettings(def) {
   const settings = {}
 
   for (const s in def) {
-    if (def.hasOwnProperty(s)) {
+    if (Object.prototype.hasOwnProperty.call(def, s)) {
       if (s !== 'name' || s !== 'properties') {
         settings[s] = def[s]
       }
@@ -35,7 +37,8 @@ module.exports = function setupModelFn(app, options) {
 
   if (typeof options.modelName !== 'undefined') {
     debug(`Overwriting model name to ${options.modelName} (default = Ping)`)
-    modelDefinition.name = modelDefinition.plural = options.modelName
+    modelDefinition.name = options.modelName
+    modelDefinition.plural = options.modelName
   }
 
   const ds = app.loopback.createDataSource('transient', { connector: 'transient' })
@@ -45,7 +48,7 @@ module.exports = function setupModelFn(app, options) {
     getModelSettings(modelDefinition)
   )
 
-  const Model = require('./models/ping')(newModel, options)
+  const Model = ping(newModel, options)
 
   app.model(Model)
 }

package.json

@@ -32,8 +32,7 @@
     "conventional-commit-types": "^2.1.0",
     "cors": "^2.8.3",
     "coveralls": "^2.13.0",
-    "eslint": "^3.19.0",
-    "eslint-config-fullcube": "^1.0.46",
+    "eslint-config-fullcube": "^2.0.2",
     "loopback": "^3.6.0",
     "loopback-boot": "^2.24.0",
     "loopback-component-explorer": "^4.2.0",

test/test.js

@@ -3,11 +3,11 @@
 const path = require('path')
 const chai = require('chai')
 
-const expect = chai.expect
+const { expect } = chai
 
 const TEST_APP = path.join(__dirname, 'test-server')
 const app = require(path.join(TEST_APP, 'server/server.js'))
-const Ping = app.models.Ping
+const Ping = app.loopback.getModel('Ping')
 
 describe('Component Initialization', function() {