Fix CA errors.

Author: grokys

src/GitHub.InlineReviews/Services/CommentService.cs

@@ -1,4 +1,5 @@
 using System.ComponentModel.Composition;
+using System.Globalization;
 using System.Windows.Forms;
 
 namespace GitHub.InlineReviews.Services
@@ -9,11 +10,17 @@ public class CommentService:ICommentService
     {
         public bool ConfirmCommentDelete()
         {
+            var options = CultureInfo.CurrentUICulture.TextInfo.IsRightToLeft ?
+                MessageBoxOptions.RtlReading | MessageBoxOptions.RightAlign :
+                0;
+
             return MessageBox.Show(
                 VisualStudio.UI.Resources.DeleteCommentConfirmation,
                 VisualStudio.UI.Resources.DeleteCommentConfirmationCaption,
                 MessageBoxButtons.YesNo,
-                MessageBoxIcon.Question) == DialogResult.Yes;
+                MessageBoxIcon.Question,
+                MessageBoxDefaultButton.Button1,
+                options) == DialogResult.Yes;
         }
     }
 }

src/GitHub.TeamFoundation.14/Services/TeamExplorerServices.cs

@@ -1,5 +1,6 @@
 using System;
 using System.ComponentModel.Composition;
+using System.Diagnostics.CodeAnalysis;
 using System.Windows.Input;
 using GitHub.Extensions;
 using GitHub.VisualStudio.TeamExplorer.Sync;
@@ -19,7 +20,7 @@ public class TeamExplorerServices : ITeamExplorerServices
         /// that instances of this type cannot be created if the TeamFoundation dlls are not available
         /// (otherwise we'll have multiple instances of ITeamExplorerServices exports, and that would be Bad(tm))
         /// </summary>
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields")]
+        [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields")]
         ITeamExplorerNotificationManager manager;
 
         [ImportingConstructor]
@@ -31,14 +32,14 @@ public TeamExplorerServices(IGitHubServiceProvider serviceProvider)
         public void ShowConnectPage()
         {
             var te = serviceProvider.TryGetService<ITeamExplorer>();
-            var foo = te.NavigateToPage(new Guid(TeamExplorerPageIds.Connect), null);
+            te.NavigateToPage(new Guid(TeamExplorerPageIds.Connect), null);
         }
 
         public void ShowPublishSection()
         {
             var te = serviceProvider.TryGetService<ITeamExplorer>();
-            var foo = te.NavigateToPage(new Guid(TeamExplorerPageIds.GitCommits), null);
-            var publish = foo?.GetSection(new Guid(GitHubPublishSection.GitHubPublishSectionId)) as GitHubPublishSection;
+            var page = te.NavigateToPage(new Guid(TeamExplorerPageIds.GitCommits), null);
+            var publish = page?.GetSection(new Guid(GitHubPublishSection.GitHubPublishSectionId)) as GitHubPublishSection;
             publish?.Connect();
         }
 

src/GitHub.VisualStudio/Commands/GoToSolutionOrPullRequestFileCommand.cs

@@ -237,7 +237,7 @@ bool TryNavigateFromHistoryFile(IVsTextView sourceView)
             if (teamExplorerContext.Value.ActiveRepository?.LocalPath is string repositoryDir &&
                 FindObjectishForTFSTempFile(sourceView) is string objectish)
             {
-                var (commitSha, blobPath) = gitHubContextService.Value.ResolveBlobFromHistory(repositoryDir, objectish);
+                var (_, blobPath) = gitHubContextService.Value.ResolveBlobFromHistory(repositoryDir, objectish);
                 if (blobPath is string)
                 {
                     var workingFile = Path.Combine(repositoryDir, blobPath);

src/GitHub.VisualStudio/Commands/OpenFromUrlCommand.cs

@@ -20,7 +20,6 @@ public class OpenFromUrlCommand : VsCommand<string>, IOpenFromUrlCommand
     {
         readonly Lazy<IGitHubContextService> gitHubContextService;
         readonly Lazy<IRepositoryCloneService> repositoryCloneService;
-        readonly Lazy<IPullRequestEditorService> pullRequestEditorService;
         readonly Lazy<ITeamExplorerContext> teamExplorerContext;
         readonly Lazy<IGitHubToolWindowManager> gitHubToolWindowManager;
         readonly Lazy<DTE> dte;
@@ -40,14 +39,12 @@ public class OpenFromUrlCommand : VsCommand<string>, IOpenFromUrlCommand
         public OpenFromUrlCommand(
             Lazy<IGitHubContextService> gitHubContextService,
             Lazy<IRepositoryCloneService> repositoryCloneService,
-            Lazy<IPullRequestEditorService> pullRequestEditorService,
             Lazy<ITeamExplorerContext> teamExplorerContext,
             [Import(typeof(SVsServiceProvider))] IServiceProvider serviceProvider) :
             base(CommandSet, CommandId)
         {
             this.gitHubContextService = gitHubContextService;
             this.repositoryCloneService = repositoryCloneService;
-            this.pullRequestEditorService = pullRequestEditorService;
             this.teamExplorerContext = teamExplorerContext;
             this.serviceProvider = serviceProvider;
             dte = new Lazy<DTE>(() => (DTE)serviceProvider.GetService(typeof(DTE)));

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs

@@ -17,6 +17,7 @@
 
 namespace GitHub.VisualStudio.Views.GitHubPane
 {
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1001:TypesThatOwnDisposableFieldsShouldBeDisposable")]
     [ExportViewFor(typeof(IPullRequestListViewModel))]
     [PartCreationPolicy(CreationPolicy.NonShared)]
     public partial class PullRequestListView : UserControl