Excluding code coverage flakes

StanleyGoldman · StanleyGoldman · commit f2dba0ccc360 · 2018-09-06T10:44:56.000-04:00
diff --git a/scripts/Run-CodeCoverage.ps1 b/scripts/Run-CodeCoverage.ps1
@@ -34,7 +34,7 @@ $testAssemblies = @(
     "test\TrackingCollectionTests\bin\$Configuration\TrackingCollectionTests.dll"
 )
 
-$opencoverTargetArgs = ($testAssemblies -join " ") + " --where cat!=Timings --inprocess --noresult"
+$opencoverTargetArgs = ($testAssemblies -join " ") + " --where cat!=Timings --where cat!=CodeCoverageFlake --inprocess --noresult"
 
 $opencoverDirectory = Join-Path $rootDirectory packages\OpenCover.4.6.519\tools
 $opencover = Join-Path $opencoverDirectory OpenCover.Console.exe
@@ -57,7 +57,7 @@ $codecovArgs = "-f `"coverage.xml`""
 
     Run-Process 600 $opencover $opencoverArgs
 
-    if($AppVeyor) {
+    if ($AppVeyor) {
         Run-Process 60 $codecov $codecovArgs
     }
 
diff --git a/test/GitHub.InlineReviews.UnitTests/Services/PullRequestSessionManagerTests.cs b/test/GitHub.InlineReviews.UnitTests/Services/PullRequestSessionManagerTests.cs
@@ -447,7 +447,7 @@ Line 2
                 }
             }
 
-            [Test]
+            [Test, NUnit.Framework.Category("CodeCoverageFlake")]
             public async Task UpdatesInlineCommentThreadsFromEditorContent()
             {
                 var baseContents = @"Line 1

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ $testAssemblies = @(`
`34`	`34`	`"test\TrackingCollectionTests\bin\$Configuration\TrackingCollectionTests.dll"`
`35`	`35`	`)`
`36`	`36`
`37`		`-$opencoverTargetArgs = ($testAssemblies -join " ") + " --where cat!=Timings --inprocess --noresult"`
	`37`	`+$opencoverTargetArgs = ($testAssemblies -join " ") + " --where cat!=Timings --where cat!=CodeCoverageFlake --inprocess --noresult"`
`38`	`38`
`39`	`39`	`$opencoverDirectory = Join-Path $rootDirectory packages\OpenCover.4.6.519\tools`
`40`	`40`	`$opencover = Join-Path $opencoverDirectory OpenCover.Console.exe`
@@ -57,7 +57,7 @@ $codecovArgs = "-f `"coverage.xml`""
`57`	`57`
`58`	`58`	`Run-Process 600 $opencover $opencoverArgs`
`59`	`59`
`60`		`- if($AppVeyor) {`
	`60`	`+ if ($AppVeyor) {`
`61`	`61`	`Run-Process 60 $codecov $codecovArgs`
`62`	`62`	`}`
`63`	`63`
Original file line number	Diff line number	Diff line change
`@@ -447,7 +447,7 @@ Line 2`
`447`	`447`	`}`
`448`	`448`	`}`
`449`	`449`
`450`		`- [Test]`
	`450`	`+ [Test, NUnit.Framework.Category("CodeCoverageFlake")]`
`451`	`451`	`public async Task UpdatesInlineCommentThreadsFromEditorContent()`
`452`	`452`	`{`
`453`	`453`	`var baseContents = @"Line 1`