Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Commit 5b0838c

Browse files
author
Nicolas Garnier
authored
Merge pull request #342 from googlecodelabs/google-feedback
Using Google Feedback when there is no Feedback link provided.
2 parents b4d6882 + c3fda35 commit 5b0838c

4 files changed

Lines changed: 16 additions & 5 deletions

File tree

claat/render/template.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
<script src="{{.Prefix}}/codelab-elements/custom-elements.min.js"></script>
5252
<script src="{{.Prefix}}/codelab-elements/prettify.js"></script>
5353
<script src="{{.Prefix}}/codelab-elements/codelab-elements.js"></script>
54+
<script src="//support.google.com/inapp/api.js"></script>
5455

5556
</body>
5657
</html>

codelab-elements/google-codelab/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ closure_js_library(
2525
name = "google_codelab",
2626
srcs = [
2727
"google_codelab.js",
28-
"google_codelab_def.js"
28+
"google_codelab_def.js",
2929
],
3030
deps = [
3131
"@io_bazel_rules_closure//closure/library",

codelab-elements/google-codelab/google_codelab.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,7 @@ class Codelab extends HTMLElement {
559559
return;
560560
}
561561

562+
562563
let time = 0;
563564
for (let i = this.currentSelectedStep_; i < this.steps_.length; i++) {
564565
const step = /** @type {!Element} */ (this.steps_[i]);
@@ -747,6 +748,17 @@ class Codelab extends HTMLElement {
747748
const feedback = this.getAttribute(FEEDBACK_LINK_ATTR);
748749
const steps = this.steps_.map((step) => step.getAttribute(LABEL_ATTR));
749750
soy.renderElement(this.drawer_, Templates.drawer, {steps, feedback});
751+
// Start Google Feedback when the feedback link is clicked, if it exists.
752+
const feedbackLink = this.drawer_.querySelector('#codelab-feedback');
753+
if (feedbackLink) {
754+
this.eventHandler_.listen(feedbackLink, events.EventType.CLICK,
755+
(e) => {
756+
if ('userfeedback' in window) {
757+
window['userfeedback']['api']['startFeedback']
758+
({productId: '5143948'});
759+
}
760+
});
761+
}
750762
}
751763

752764
/**

codelab-elements/google-codelab/google_codelab.soy

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,9 @@
8484
{/for}
8585
</ol>
8686
</div>
87-
{if $feedback}
88-
<div id="feedback" class="metadata">
89-
<a target="_blank" href="{$feedback}">
87+
<div class="metadata">
88+
<a target="_blank" {if $feedback}href="{$feedback}"{else}href="#" id="codelab-feedback"{/if}>
9089
<i class="material-icons">bug_report</i> Report a mistake
9190
</a>
9291
</div>
93-
{/if}
9492
{/template}

0 commit comments

Comments
 (0)