API does not accepted encoded query string params

[NathanielWroblewski]

API breaks when passed encoded values instead of actual values. For example:

encodeURIComponent('=')
> "%3D"
encodeURIComponent('&')
> "%26"

This breaks when passing multiple parameters.

%26addresses%3Dmu1izpJmF7CHnbVcH59f1PqfvXnmiBEMq8
&addresses=mu1izpJmF7CHnbVcH59f1PqfvXnmiBEMq8

[scottlingran]

@NathanielWroblewski, how did the urls become encoded?

I'm a bit hesitant to handle this because even the following will break
www.google.com/search?q%3Dhello

[NathanielWroblewski]

Faraday.

[scottlingran]

require 'faraday'
require 'json'

conn = Faraday.new(:url => 'https://testnet.helloblock.io') do |faraday|
  faraday.request  :url_encoded
  faraday.response :logger
  faraday.adapter  Faraday.default_adapter
end


response = conn.get do |req|
  req.url '/wallet'
  req.params['addresses'] = ["mpjuaPusdVC5cKvVYCFX94bJX1SNUY8EJo"]
end

url = response.env.url.to_s
p url
# => https://testnet.helloblock.io/wallet?addresses%5B%5D=mpjuaPusdVC5cKvVYCFX94bJX1SNUY8EJo

body = JSON.parse(response.body)
p body
# seems fine

[scottlingran]

How was that bug produced?