Return ref to rule in slice to avoid allocation

hmarr · hmarr · commit a8d3c95fa537 · 2022-10-26T22:10:44.000-04:00
diff --git a/codeowners.go b/codeowners.go
@@ -104,10 +104,10 @@ type Ruleset []Rule
 // last matching rule takes precedence.
 func (r Ruleset) Match(path string) (*Rule, error) {
 	for i := len(r) - 1; i >= 0; i-- {
-		rule := r[i]
+		rule := &r[i]
 		match, err := rule.Match(path)
 		if match || err != nil {
-			return &rule, err
+			return rule, err
 		}
 	}
 	return nil, nil

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,10 @@ type Ruleset []Rule`
`104`	`104`	`// last matching rule takes precedence.`
`105`	`105`	`func (r Ruleset) Match(path string) (*Rule, error) {`
`106`	`106`	`for i := len(r) - 1; i >= 0; i-- {`
`107`		`- rule := r[i]`
	`107`	`+ rule := &r[i]`
`108`	`108`	`match, err := rule.Match(path)`
`109`	`109`	`if match \|\| err != nil {`
`110`		`- return &rule, err`
	`110`	`+ return rule, err`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`	`return nil, nil`