Prevent deprecation warnings (#70)

Author: janlam7

composer.json

@@ -39,6 +39,12 @@
             "test/annotation_loader.php"
         ]
     },
+    "config": {
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": false,
+            "hostnet/*":                                      true
+        }
+    },
     "extra": {
         "class": "Hostnet\\Component\\AccessorGenerator\\Plugin"
     },

src/Collection/ImmutableCollection.php

@@ -45,7 +45,7 @@ public function __construct(Collection $collection)
      *
      * @throws \LogicException if the collection not cloned.
      */
-    public function add($element)
+    public function add($element): bool
     {
         if ($this->is_clone) {
             return $this->collection->add($element);
@@ -61,7 +61,7 @@ public function add($element)
      *
      * @throws \LogicException if the collection is not cloned.
      */
-    public function clear()
+    public function clear(): void
     {
         if (!$this->is_clone) {
             throw new \LogicException('This collection is immutable');
@@ -78,9 +78,6 @@ public function contains($element): bool
         return $this->collection->contains($element);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function isEmpty(): bool
     {
         return $this->collection->isEmpty();
@@ -90,6 +87,7 @@ public function isEmpty(): bool
      * Do not use, this collection is immutable.
      * {@inheritdoc}
      * @throws \LogicException if the collection is not cloned.
+     * @return mixed
      */
     public function remove($key)
     {
@@ -105,7 +103,7 @@ public function remove($key)
      * {@inheritdoc}
      * @throws \LogicException if the collection is not cloned.
      */
-    public function removeElement($element)
+    public function removeElement($element): bool
     {
         if ($this->is_clone) {
             return $this->collection->removeElement($element);
@@ -146,7 +144,7 @@ public function getValues(): array
         return $this->collection->getValues();
     }
 
-    public function set($key, $value)
+    public function set($key, $value): void
     {
         if (!$this->is_clone) {
             throw new \LogicException('This collection is immutable');
@@ -203,33 +201,21 @@ public function next()
         return $this->collection->next();
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function exists(Closure $predicate): bool
     {
         return $this->collection->exists($predicate);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function filter(Closure $predicate): Collection
     {
         return $this->collection->filter($predicate);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function forAll(Closure $predicate): bool
     {
         return $this->collection->forAll($predicate);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function map(Closure $func): Collection
     {
         return $this->collection->map($func);
@@ -259,32 +245,28 @@ public function slice($offset, $length = null): array
         return $this->collection->slice($offset, $length);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function count()
+    public function count(): int
     {
         return $this->collection->count();
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function getIterator()
+    public function getIterator(): \Traversable
     {
         return $this->collection->getIterator();
     }
 
     /**
      * {@inheritdoc}
      */
-    public function offsetExists($offset)
+    public function offsetExists($offset): bool
     {
         return $this->collection->offsetExists($offset);
     }
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function offsetGet($offset)
     {
@@ -296,7 +278,7 @@ public function offsetGet($offset)
      * {@inheritdoc}
      * @throws \LogicException if the collection is not cloned.
      */
-    public function offsetSet($offset, $value)
+    public function offsetSet($offset, $value): void
     {
         if (!$this->is_clone) {
             throw new \LogicException('This collection is immutable');
@@ -310,7 +292,7 @@ public function offsetSet($offset, $value)
      * {@inheritdoc}
      * @throws \LogicException if the collection is not cloned.
      */
-    public function offsetUnset($offset)
+    public function offsetUnset($offset): void
     {
         if (!$this->is_clone) {
             throw new \LogicException('This collection is immutable');
@@ -319,10 +301,7 @@ public function offsetUnset($offset)
         $this->collection->offsetUnset($offset);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function matching(Criteria $criteria)
+    public function matching(Criteria $criteria): Collection
     {
         return $this->collection->matching($criteria);
     }