Merge pull request #42 from janlam7/phpcs-tool-9

janlam7 · web-flow · commit 7aa712a38c2c · 2022-05-02T19:18:50.000+02:00
Update phpcs-tool to 9.1.0 with Hostnet-Level-1
diff --git a/composer.json b/composer.json
@@ -12,7 +12,7 @@
     },
     "require-dev": {
         "hostnet/database-test-lib": "^2.0.2",
-        "hostnet/phpcs-tool":        "^8.3",
+        "hostnet/phpcs-tool":        "^9.1.0",
         "phpspec/prophecy-phpunit":  "^2.0",
         "phpunit/phpunit":           "^9.4",
         "symfony/cache":             "^5.3"
@@ -26,5 +26,11 @@
         "psr-4": {
             "Hostnet\\Component\\EntityTracker\\": "test/"
         }
+    },
+    "config": {
+        "allow-plugins": {
+            "hostnet/*":                                      true,
+            "dealerdirect/phpcodesniffer-composer-installer": false
+        }
     }
 }
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -0,0 +1,4 @@
+<?xml version="1.0"?>
+<ruleset name="entity-tracker-component PHPCS">
+  <rule ref="Hostnet-Level-1"/>
+</ruleset>
diff --git a/src/Events.php b/src/Events.php
@@ -20,5 +20,5 @@ final class Events
      *
      * @var string
      */
-    const ENTITY_CHANGED = 'entityChanged';
+    public const ENTITY_CHANGED = 'entityChanged';
 }
diff --git a/src/Provider/EntityAnnotationMetadataProvider.php b/src/Provider/EntityAnnotationMetadataProvider.php
@@ -8,8 +8,6 @@
 
 use Doctrine\Common\Annotations\Reader;
 use Doctrine\ORM\EntityManagerInterface;
-use Doctrine\ORM\Mapping\ClassMetadata;
-use Doctrine\ORM\UnitOfWork;
 use Hostnet\Component\EntityTracker\Annotation\Tracked;
 
 class EntityAnnotationMetadataProvider
diff --git a/src/Provider/EntityMutationMetadataProvider.php b/src/Provider/EntityMutationMetadataProvider.php
@@ -135,7 +135,7 @@ public function getMutatedFields(EntityManagerInterface $em, $entity, $original)
     }
 
     /**
-     * @param ClassMetaData $association_meta
+     * @param ClassMetadata $association_meta
      * @param string        $left
      * @param string        $right
      * @return bool
diff --git a/test/Provider/Entity/C.php b/test/Provider/Entity/C.php
@@ -6,7 +6,6 @@
 
 namespace Hostnet\Component\EntityTracker\Provider\Entity;
 
-use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\ORM\Mapping as ORM;
 
 /**
diff --git a/test/Provider/Entity/Visit.php b/test/Provider/Entity/Visit.php
@@ -6,8 +6,6 @@
 
 namespace Hostnet\Component\EntityTracker\Provider\Entity;
 
-use Doctrine\Common\Collections\ArrayCollection;
-use Doctrine\Common\Collections\Collection;
 use Doctrine\ORM\Mapping as ORM;
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -20,5 +20,5 @@ final class Events`
`20`	`20`	`*`
`21`	`21`	`* @var string`
`22`	`22`	`*/`
`23`		`- const ENTITY_CHANGED = 'entityChanged';`
	`23`	`+ public const ENTITY_CHANGED = 'entityChanged';`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public function getMutatedFields(EntityManagerInterface $em, $entity, $original)`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`/**`
`138`		`- * @param ClassMetaData $association_meta`
	`138`	`+ * @param ClassMetadata $association_meta`
`139`	`139`	`* @param string $left`
`140`	`140`	`* @param string $right`
`141`	`141`	`* @return bool`