feat: support selective tensor dump by task#844
Open
zmnobug wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a selective tensor dump feature, allowing users to dump inputs and outputs for specific tasks by enabling a selective mode and marking individual tasks. The implementation adds bitmask-based request flags to task metadata and updates the AICPU collection logic to filter tasks accordingly. Review feedback suggests adding defensive null checks for the runtime context in the orchestration API to prevent potential crashes and using bitwise OR assignment for consistency in setting dump requests to avoid accidentally clearing flags.
- add rt_tensor_dump_selective() to enable selective dump mode - add Arg::dump_input(), dump_output(), and dump_input_output() - carry dump requests through task payload and dump records - filter unmarked tasks at AICPU tensor dump collection entry - keep legacy full tensor dump behavior when selective mode is not enabled - add partial tensor dump test and update docs
zmnobug
force-pushed
the
feature/838-partial-task-tensor-dump
branch
from
0dab2f6 to
b76483f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #838