DTPAYWONE-564:

- Changed minimum supported Python version in README to 3.5, due to RSA library constraint.
- Fixed pycodestyle complaints.

Author: rhunterduvar-hw-dev

README.rst

@@ -12,7 +12,7 @@ A library to manage users, transfer methods and payments through the Hyperwallet
 Prerequisites
 -------------
 
-Hyperwallet's Python server SDK requires at minimum Python 2.7 and above.
+Hyperwallet's Python server SDK requires at minimum Python 3.5 and above.
 
 Installation
 ------------

hyperwallet/api.py

@@ -2765,7 +2765,7 @@ def __buildUrl(self, *paths):
         return '/'.join(s.strip('/') for s in paths)
 
     def setDocumentAndReasonFromResponseHelper(self,
-                               data=None):
+                                               data=None):
         '''
         Helper to modify dictionary with Document and Reason classes
 
@@ -3131,7 +3131,7 @@ def listTransferMethods(self,
 
         if not userToken:
             raise HyperwalletException('userToken is required')
-        
+
         if params and not set(list(params)).issubset(TransferMethod.filters_array):
             raise HyperwalletException('Invalid filter')
 

hyperwallet/models.py

@@ -3,6 +3,7 @@
 import json
 from enum import Enum
 
+
 class HyperwalletModel(object):
     '''
     The base Hyperwallet Model from which all other models will inherit.
@@ -70,7 +71,7 @@ class User(HyperwalletModel):
         A dictionary containing the attributes for the User.
     '''
 
-    filters_array = {'clientUserId','email','programToken','status','verificationStatus', 'taxVerificationStatus', 'createdBefore', 'createdAfter', 'sortBy', 'offset', 'limit'}
+    filters_array = {'clientUserId', 'email', 'programToken', 'status', 'verificationStatus', 'taxVerificationStatus', 'createdBefore', 'createdAfter', 'sortBy', 'offset', 'limit'}
 
     def __init__(self, data):
         '''
@@ -130,6 +131,7 @@ def __repr__(self):
             token=self.token
         )
 
+
 class HyperwalletVerificationDocument(HyperwalletModel):
     '''
     The HyperwalletVerificationDocument Model.
@@ -163,6 +165,7 @@ def __repr__(self):
             createdOn=self.createdOn, category=self.category
         )
 
+
 class HyperwalletVerificationDocumentReason(HyperwalletModel):
     '''
     The HyperwalletVerificationDocumentReason Model.
@@ -191,6 +194,7 @@ def __repr__(self):
             name=self.name, description=self.description
         )
 
+
 class RejectReason(Enum):
     DOCUMENT_EXPIRED = 0
     DOCUMENT_NOT_RELATED_TO_PROFILE = 1
@@ -201,6 +205,7 @@ class RejectReason(Enum):
     DOCUMENT_NOT_VALID_WITH_NOTES = 6
     DOCUMENT_TYPE_NOT_VALID = 7
 
+
 class AuthenticationToken(HyperwalletModel):
     '''
     The AuthenticationToken Model.
@@ -274,7 +279,7 @@ class BankAccount(TransferMethod):
         A dictionary containing the attributes for the Bank Account.
     '''
 
-    filters_array = {'type','status', 'createdBefore', 'createdAfter', 'sortBy', 'offset', 'limit'}
+    filters_array = {'type', 'status', 'createdBefore', 'createdAfter', 'sortBy', 'offset', 'limit'}
 
     def __init__(self, data):
         '''
@@ -487,7 +492,7 @@ class Transfer(HyperwalletModel):
         A dictionary containing the attributes for the Transfer.
     '''
 
-    filters_array = {'clientTransferId','sourceToken','destinationToken', 'createdBefore', 'createdAfter', 'offset', 'limit'}
+    filters_array = {'clientTransferId', 'sourceToken', 'destinationToken', 'createdBefore', 'createdAfter', 'offset', 'limit'}
 
     def __init__(self, data):
         '''
@@ -533,7 +538,7 @@ class PayPalAccount(TransferMethod):
         A dictionary containing the attributes for the PayPal Account.
     '''
 
-    filters_array = {'status', 'type', 'createdOn' , 'createdBefore', 'createdAfter', 'sortBy', 'offset', 'limit'}
+    filters_array = {'status', 'type', 'createdOn', 'createdBefore', 'createdAfter', 'sortBy', 'offset', 'limit'}
 
     def __init__(self, data):
         '''

hyperwallet/tests/test_api.py

@@ -64,7 +64,7 @@ def setUp(self):
             'currencies': ['USD'],
             'type': 'INDIVIDUAL'
         }
-        
+
         self.uploadSuccessData = {
             'token': 'tkn-12345',
             "documents": [{
@@ -84,12 +84,12 @@ def setUp(self):
                 "status": "INVALID",
                 "reasons": [
                     {
-                    "name": "DOCUMENT_CORRECTION_REQUIRED",
-                    "description": "Document requires correction"
+                        "name": "DOCUMENT_CORRECTION_REQUIRED",
+                        "description": "Document requires correction"
                     },
                     {
-                    "name": "DOCUMENT_NOT_DECISIVE",
-                    "description": "Decision cannot be made based on document. Alternative document required"
+                        "name": "DOCUMENT_NOT_DECISIVE",
+                        "description": "Decision cannot be made based on document. Alternative document required"
                     }
                 ],
                 "createdOn": "2020-11-24T19:05:02"
@@ -220,7 +220,7 @@ def test_list_user_status_transitions_fail_need_params_invalid(self):
 
     @mock.patch('hyperwallet.utils.ApiClient._makeRequest')
     def test_list_user_status_transitions_params_valid(self, mock_get):
-        
+
         options = {'transition': 'test'}
         mock_get.return_value = {'data': [self.data]}
         response = self.api.listUserStatusTransitions('token', options)
@@ -810,7 +810,7 @@ def test_list_prepaid_cards_fail_need_params_invalid(self):
             self.api.listPrepaidCards('token', options)
 
         self.assertEqual(exc.exception.message, 'Invalid filter')
-    
+
     @mock.patch('hyperwallet.utils.ApiClient._makeRequest')
     def test_list_prepaid_cards_params_valid(self, mock_get):
 
@@ -1892,7 +1892,7 @@ def test_list_venmo_accounts_fail_need_params_invalid(self):
             self.api.listVenmoAccounts('token', options)
 
         self.assertEqual(exc.exception.message, 'Invalid filter')
-        
+
     @mock.patch('hyperwallet.utils.ApiClient._makeRequest')
     def test_list_venmo_accounts_params_valid(self, mock_get):
 
@@ -2101,7 +2101,7 @@ def test_get_payment_success(self, mock_get):
         self.assertTrue(response.token, self.data.get('token'))
 
     def test_list_payments_fail_need_params_invalid(self):
-    
+
         options = {'currency': 'test', 'email': 'test'}
         with self.assertRaises(HyperwalletException) as exc:
             self.api.listPayments(options)
@@ -2585,7 +2585,6 @@ def test_list_transfer_method_configurations_params_valid(self, mock_get):
 
         self.assertTrue(response[0].type, self.configuration.get('type'))
 
-
     @mock.patch('hyperwallet.utils.ApiClient._makeRequest')
     def test_list_transfer_method_configurations_success(self, mock_get):
 
@@ -2677,7 +2676,6 @@ def test_uploadDocumentsForUserAndParse_success(self, mock_put):
         self.assertEqual(response.token, self.uploadSuccessData.get('token'))
         self.assertEqual(response.documents[0].type, self.uploadSuccessData.get("documents")[0].type)
 
-
     @mock.patch('hyperwallet.utils.ApiClient._makeRequest')
     def test_uploadDocumentsForUserAndParseRejection_success(self, mock_put):
 
@@ -2869,7 +2867,7 @@ def test_list_transfer_status_transitions_fail_need_params_invalid(self):
 
         options = {'transition': 'test', 'token': 'test'}
         with self.assertRaises(HyperwalletException) as exc:
-            self.api.listTransferStatusTransitions('token',options)
+            self.api.listTransferStatusTransitions('token', options)
 
         self.assertEqual(exc.exception.message, 'Invalid filter')
 
@@ -2957,7 +2955,7 @@ def test_list_transfer_methods_fail_need_params_invalid(self):
 
         options = {'type': 'test', 'token': 'test'}
         with self.assertRaises(HyperwalletException) as exc:
-            self.api.listTransferMethods('token',options)
+            self.api.listTransferMethods('token', options)
 
         self.assertEqual(exc.exception.message, 'Invalid filter')