fix: auto-update arch fallback + CI install smoke tests (#1133)

* fix: improve updater arch fallback and add CI install smoke tests

* fix: stabilize windows update and directory path handling

* fix: improve updater arch fallback and add CI install smoke tests

* fix: stabilize windows update and directory path handling

* chore(i18n): regenerate i18n key types

* chore(i18n): regenerate key types after upstream merge

* chore(format): fix prettier issues in settings bridge and i18n types

Author: loonghao

.github/workflows/pr-checks.yml

@@ -250,6 +250,122 @@ jobs:
       - name: Verify packaged i18n assets
         run: bun run test:packaged:i18n
 
+      - name: Verify build artifacts exist
+        shell: bash
+        run: |
+          echo "=========================================="
+          echo "VERIFY ARTIFACTS: ${{ matrix.platform }}"
+          echo "=========================================="
+          ls -lah out || true
+
+          case "${{ matrix.platform }}" in
+            windows-*)
+              ls out/*.exe out/*latest*.yml >/dev/null
+              ;;
+            macos-*)
+              ls out/*.dmg out/*.zip out/*latest*.yml >/dev/null
+              ;;
+            linux)
+              ls out/*.AppImage out/*.deb out/*latest*.yml >/dev/null
+              ;;
+          esac
+
+      - name: Silent install smoke test (Windows x64)
+        if: matrix.platform == 'windows-x64'
+        shell: pwsh
+        run: |
+          Write-Host "=========================================="
+          Write-Host "SMOKE INSTALL: windows-x64"
+          Write-Host "=========================================="
+
+          $installer = Get-ChildItem -Path out -Filter "AionUi-*-win-*.exe" | Sort-Object LastWriteTime -Descending | Select-Object -First 1
+          if (-not $installer) {
+            throw "No Windows installer found in out/"
+          }
+
+          Write-Host "Using installer: $($installer.FullName)"
+          Start-Process -FilePath $installer.FullName -ArgumentList '/S' -Wait -NoNewWindow
+
+          $candidates = @(
+            "$env:LOCALAPPDATA\Programs\AionUi\AionUi.exe",
+            "$env:ProgramFiles\AionUi\AionUi.exe",
+            "$env:ProgramFiles(x86)\AionUi\AionUi.exe"
+          )
+
+          $installedExe = $candidates | Where-Object { Test-Path $_ } | Select-Object -First 1
+          if (-not $installedExe) {
+            throw "Silent install finished but app executable not found in expected locations"
+          }
+
+          Write-Host "Installed executable: $installedExe"
+
+      - name: Skip executable smoke for Windows arm64 cross build
+        if: matrix.platform == 'windows-arm64'
+        shell: pwsh
+        run: |
+          Write-Host "Skipping runtime install smoke for windows-arm64: runner is windows-x64, cannot reliably execute arm64 installer."
+          Get-ChildItem -Path out -Filter "AionUi-*-win-*.exe" | Format-Table Name, Length
+
+      - name: Install smoke test (macOS arm64)
+        if: matrix.platform == 'macos-arm64'
+        shell: bash
+        run: |
+          set -euo pipefail
+          echo "=========================================="
+          echo "SMOKE INSTALL: macos-arm64"
+          echo "=========================================="
+
+          DMG_FILE=$(ls out/*.dmg | head -n 1)
+          MOUNT_POINT="/tmp/aionui-smoke-mount"
+          APP_DIR="/tmp/aionui-smoke-app"
+
+          rm -rf "$MOUNT_POINT" "$APP_DIR"
+          mkdir -p "$MOUNT_POINT" "$APP_DIR"
+
+          hdiutil attach "$DMG_FILE" -nobrowse -mountpoint "$MOUNT_POINT"
+          cp -R "$MOUNT_POINT"/*.app "$APP_DIR"/
+          hdiutil detach "$MOUNT_POINT"
+
+          APP_PATH=$(ls -d "$APP_DIR"/*.app | head -n 1)
+          APP_BIN="$APP_PATH/Contents/MacOS/AionUi"
+
+          test -x "$APP_BIN"
+          "$APP_BIN" --version || true
+
+      - name: Skip executable smoke for macOS x64 cross build
+        if: matrix.platform == 'macos-x64'
+        shell: bash
+        run: |
+          echo "Skipping runtime launch smoke for macos-x64 cross build on arm64 runner."
+          ls -lah out/*.dmg out/*.zip
+
+      - name: Install smoke test (Linux)
+        if: matrix.platform == 'linux'
+        shell: bash
+        run: |
+          set -euo pipefail
+          echo "=========================================="
+          echo "SMOKE INSTALL: linux"
+          echo "=========================================="
+
+          APPIMAGE_FILE=$(ls out/*.AppImage | head -n 1)
+          chmod +x "$APPIMAGE_FILE"
+          "$APPIMAGE_FILE" --appimage-extract-and-run --version || true
+
+          DEB_FILE=$(ls out/*.deb | head -n 1)
+          PKG_NAME=$(dpkg-deb -f "$DEB_FILE" Package)
+          sudo dpkg -i "$DEB_FILE" || sudo apt-get install -f -y
+
+          INSTALLED_BIN=$(dpkg -L "$PKG_NAME" | grep -Ei '/(bin|opt)/.*(aionui)$' | head -n 1 || true)
+          if [ -z "$INSTALLED_BIN" ]; then
+            echo "Package files:"
+            dpkg -L "$PKG_NAME" | head -n 50
+            echo "No installed executable path matched expected pattern"
+            exit 1
+          fi
+
+          test -x "$INSTALLED_BIN"
+
   # Job 4: Trigger GPT AI review (only on first PR submission)
   review:
     name: AI Review

src/process/bridge/systemSettingsBridge.ts

@@ -41,5 +41,4 @@ export function initSystemSettingsBridge(): void {
     // 然后通知主进程更新托盘状态
     _changeListener?.(enabled);
   });
-
 }

src/process/bridge/updateBridge.ts

@@ -63,30 +63,62 @@ const mapAsset = (asset: GitHubReleaseApiAsset): GitHubReleaseAsset => ({
   contentType: asset.content_type,
 });
 
-const getPlatformHints = () => {
-  const platform = process.platform;
-  const arch = process.arch;
+type RuntimePlatformInfo = {
+  platform: NodeJS.Platform;
+  arch: string;
+};
+
+type CanonicalArch = 'x64' | 'arm64' | 'ia32';
+
+const normalizeArch = (arch: string): CanonicalArch => {
+  if (arch === 'arm64') return 'arm64';
+  if (arch === 'ia32' || arch === 'x32') return 'ia32';
+  return 'x64';
+};
+
+const detectAssetArchs = (nameLower: string): Set<CanonicalArch> => {
+  const detected = new Set<CanonicalArch>();
+
+  if (/\b(arm64|aarch64)\b/.test(nameLower)) detected.add('arm64');
+  if (/\b(x64|x86_64|amd64)\b/.test(nameLower)) detected.add('x64');
+
+  const hasX86Token = /\bx86\b/.test(nameLower) && !/\bx86[_-]?64\b/.test(nameLower);
+  if (/\b(ia32|x32|32bit)\b/.test(nameLower) || hasX86Token) detected.add('ia32');
 
-  const archHints = arch === 'arm64' ? ['arm64', 'aarch64'] : ['x64', 'x86_64', 'amd64'];
+  return detected;
+};
+
+const getPlatformHints = (runtime: RuntimePlatformInfo = { platform: process.platform, arch: process.arch }) => {
+  const platform = runtime.platform;
+  const arch = runtime.arch;
+  const normalizedArch = normalizeArch(arch);
+
+  const archHints = normalizedArch === 'arm64' ? ['arm64', 'aarch64'] : normalizedArch === 'ia32' ? ['ia32', 'x86', 'x32', '32bit'] : ['x64', 'x86_64', 'amd64'];
 
   // electron-builder artifact names often include one of these
   const platformHints = platform === 'win32' ? ['win', 'win32', 'windows'] : platform === 'darwin' ? ['mac', 'darwin', 'osx'] : ['linux'];
 
-  return { platform, arch, archHints, platformHints };
+  return { platform, arch, normalizedArch, archHints, platformHints };
 };
 
-const scoreAsset = (asset: GitHubReleaseAsset): number => {
-  const { platform, archHints, platformHints } = getPlatformHints();
+const scoreAsset = (asset: GitHubReleaseAsset, runtime?: RuntimePlatformInfo): number => {
+  const { platform, normalizedArch, archHints, platformHints } = getPlatformHints(runtime);
   const nameLower = asset.name.toLowerCase();
   const ext = path.extname(asset.name);
 
+  const detectedArchs = detectAssetArchs(nameLower);
+  if (detectedArchs.size > 0 && !detectedArchs.has(normalizedArch)) {
+    return -1;
+  }
+
   let score = 0;
 
   // Platform match
   if (platformHints.some((hint) => nameLower.includes(hint))) score += 20;
 
   // Arch match
   if (archHints.some((hint) => nameLower.includes(hint))) score += 10;
+  if (detectedArchs.has(normalizedArch)) score += 15;
 
   // Prefer installer formats per platform
   if (platform === 'win32') {
@@ -106,10 +138,15 @@ const scoreAsset = (asset: GitHubReleaseAsset): number => {
   return score;
 };
 
-const pickRecommendedAsset = (assets: GitHubReleaseAsset[]): GitHubReleaseAsset | undefined => {
+export const pickRecommendedAsset = (assets: GitHubReleaseAsset[], runtime?: RuntimePlatformInfo): GitHubReleaseAsset | undefined => {
   if (!assets.length) return undefined;
-  const scored = [...assets].sort((a, b) => scoreAsset(b) - scoreAsset(a));
-  return scored[0];
+
+  const scored = assets
+    .map((asset) => ({ asset, score: scoreAsset(asset, runtime) }))
+    .filter((item) => item.score >= 0)
+    .sort((a, b) => b.score - a.score);
+
+  return scored[0]?.asset;
 };
 
 const resolveRepo = (requestRepo?: string): string => {

src/renderer/components/UpdateModal/index.tsx

@@ -27,6 +27,7 @@ const UpdateModal: React.FC = () => {
   const [progress, setProgress] = useState({ percent: 0, speed: '', total: 0, transferred: 0 });
   const [errorMsg, setErrorMsg] = useState('');
   const [downloadPath, setDownloadPath] = useState('');
+  const [releasePageUrl, setReleasePageUrl] = useState('');
   const [useAutoUpdate, setUseAutoUpdate] = useState(true); // 默认使用自动更新
   const [autoUpdateInfo, setAutoUpdateInfo] = useState<{ version: string; releaseNotes?: string } | null>(null);
 
@@ -38,10 +39,19 @@ const UpdateModal: React.FC = () => {
     setProgress({ percent: 0, speed: '', total: 0, transferred: 0 });
     setErrorMsg('');
     setDownloadPath('');
+    setReleasePageUrl('');
     setAutoUpdateInfo(null);
   };
 
   const includePrerelease = useMemo(() => localStorage.getItem('update.includePrerelease') === 'true', [visible]);
+  const hasCompatibleManualAsset = Boolean(updateInfo?.recommendedAsset);
+
+  const openReleasePage = () => {
+    if (!releasePageUrl) return;
+    void ipcBridge.shell.openExternal.invoke(releasePageUrl).catch((error) => {
+      console.error('Failed to open release page:', error);
+    });
+  };
 
   const checkForUpdates = async () => {
     setStatus('checking');
@@ -60,6 +70,11 @@ const UpdateModal: React.FC = () => {
             setCurrentVersion(manualRes.data?.currentVersion || '');
             if (manualRes.data?.latest) {
               setUpdateInfo(manualRes.data.latest);
+              setReleasePageUrl(manualRes.data.latest.htmlUrl || '');
+              if (!manualRes.data.latest.recommendedAsset) {
+                setUseAutoUpdate(false);
+                setErrorMsg(t('update.noCompatibleAssetManual'));
+              }
             }
           }
           setStatus('available');
@@ -79,11 +94,16 @@ const UpdateModal: React.FC = () => {
 
       if (res.data?.updateAvailable && res.data.latest) {
         setUpdateInfo(res.data.latest);
+        setReleasePageUrl(res.data.latest.htmlUrl || '');
+        if (!res.data.latest.recommendedAsset) {
+          setErrorMsg(t('update.noCompatibleAssetManual'));
+        }
         setStatus('available');
         return;
       }
 
       setUpdateInfo(res.data?.latest || null);
+      setReleasePageUrl(res.data?.latest?.htmlUrl || '');
       setStatus('upToDate');
     } catch (err: unknown) {
       const msg = err instanceof Error ? err.message : String(err);
@@ -99,6 +119,10 @@ const UpdateModal: React.FC = () => {
     try {
       // 使用自动更新模式
       if (useAutoUpdate) {
+        if (updateInfo && !updateInfo.recommendedAsset) {
+          setUseAutoUpdate(false);
+          throw new Error(t('update.noCompatibleAssetManual'));
+        }
         const res = await ipcBridge.autoUpdate.download.invoke();
         if (!res?.success) {
           throw new Error(res?.msg || t('update.downloadStartFailed'));
@@ -110,7 +134,7 @@ const UpdateModal: React.FC = () => {
       if (!updateInfo) return;
       const asset = updateInfo.recommendedAsset;
       if (!asset) {
-        throw new Error(t('update.noCompatibleAsset'));
+        throw new Error(t('update.noCompatibleAssetManual'));
       }
 
       const res = await ipcBridge.update.download.invoke({
@@ -302,12 +326,15 @@ const UpdateModal: React.FC = () => {
                 </div>
               </div>
               <div className='flex items-center gap-12px'>
-                {!useAutoUpdate && (
+                {!hasCompatibleManualAsset && releasePageUrl ? (
+                  <Button type='primary' size='small' onClick={openReleasePage} className='!px-16px'>
+                    {t('update.goToRelease')}
+                  </Button>
+                ) : !useAutoUpdate ? (
                   <Button type='primary' size='small' onClick={startDownload} className='!px-16px'>
                     {t('update.downloadButton')}
                   </Button>
-                )}
-                {useAutoUpdate && (
+                ) : (
                   <Button type='primary' size='small' onClick={startDownload} className='!px-16px'>
                     {t('update.downloadAndInstall')}
                   </Button>
@@ -318,9 +345,11 @@ const UpdateModal: React.FC = () => {
             {/* 自动更新开关 / Auto update toggle */}
             <div className='flex items-center justify-between px-24px py-12px bg-fill-1 border-b border-border-2'>
               <div className='text-13px text-t-secondary'>{t('update.autoUpdateMode')}</div>
-              <Switch checked={useAutoUpdate} onChange={setUseAutoUpdate} size='small' />
+              <Switch checked={useAutoUpdate} onChange={setUseAutoUpdate} size='small' disabled={!hasCompatibleManualAsset} />
             </div>
 
+            {!hasCompatibleManualAsset && <div className='mx-24px mt-12px px-12px py-10px text-12px rounded-8px bg-[rgb(var(--warning-6))]/10 text-[rgb(var(--warning-6))]'>{t('update.noCompatibleAssetManual')}</div>}
+
             {/* 更新日志内容 / Release notes content */}
             <div className='flex-1 min-h-0 overflow-y-auto px-24px py-16px custom-scrollbar'>
               {updateInfo?.name && <div className='text-14px font-500 text-t-primary mb-12px'>{updateInfo.name}</div>}
@@ -395,9 +424,16 @@ const UpdateModal: React.FC = () => {
             </div>
             <div className='text-16px text-t-primary font-600 mb-8px'>{t('update.errorTitle')}</div>
             <div className='text-13px text-t-tertiary mb-24px text-center max-w-360px'>{errorMsg}</div>
-            <Button size='small' onClick={checkForUpdates} icon={<Refresh size='14' />} className='!px-16px'>
-              {t('common.retry')}
-            </Button>
+            <div className='flex gap-12px'>
+              <Button size='small' onClick={checkForUpdates} icon={<Refresh size='14' />} className='!px-16px'>
+                {t('common.retry')}
+              </Button>
+              {releasePageUrl && (
+                <Button type='primary' size='small' onClick={openReleasePage} className='!px-16px'>
+                  {t('update.goToRelease')}
+                </Button>
+              )}
+            </div>
           </div>
         );
     }

src/renderer/i18n/i18n-keys.d.ts

@@ -794,6 +794,7 @@ export type I18nKey =
   | 'settings.clearStatus'
   | 'settings.clickToValidate'
   | 'settings.closeDevTools'
+  | 'settings.closeToTray'
   | 'settings.command'
   | 'settings.configGuide'
   | 'settings.configGuideSuffix'
@@ -1230,9 +1231,11 @@ export type I18nKey =
   | 'update.downloadStartFailed'
   | 'update.downloadingTitle'
   | 'update.errorTitle'
+  | 'update.goToRelease'
   | 'update.installNow'
   | 'update.modalTitle'
   | 'update.noCompatibleAsset'
+  | 'update.noCompatibleAssetManual'
   | 'update.noReleaseNotes'
   | 'update.openFile'
   | 'update.readyToInstall'

src/renderer/i18n/locales/en-US/update.json

@@ -12,6 +12,8 @@
   "downloadStartFailed": "Failed to start download",
   "downloadFailed": "Download failed",
   "noCompatibleAsset": "No compatible download found for this platform",
+  "noCompatibleAssetManual": "No package matches your current system architecture. Please download the correct installer from Releases.",
+  "goToRelease": "Open Releases",
   "downloadCompleteTitle": "Download complete",
   "readyToInstall": "Ready to install",
   "readyToInstallDesc": "Update has been downloaded. Click the button below to restart and install the update.",

src/renderer/i18n/locales/ja-JP/update.json

@@ -12,6 +12,8 @@
   "downloadStartFailed": "ダウンロードを開始できませんでした",
   "downloadFailed": "ダウンロードに失敗しました",
   "noCompatibleAsset": "このプラットフォームに対応するファイルが見つかりません",
+  "noCompatibleAssetManual": "現在のシステムアーキテクチャに対応するパッケージがありません。Release ページから手動でダウンロードしてください。",
+  "goToRelease": "Release を開く",
   "downloadCompleteTitle": "ダウンロード完了",
   "readyToInstall": "インストール準備完了",
   "readyToInstallDesc": "更新のダウンロードが完了しました。下のボタンをクリックして再起動し、更新をインストールしてください。",

src/renderer/i18n/locales/ko-KR/update.json

@@ -12,6 +12,8 @@
   "downloadStartFailed": "다운로드를 시작하지 못했습니다",
   "downloadFailed": "다운로드에 실패했습니다",
   "noCompatibleAsset": "이 플랫폼에 호환되는 다운로드를 찾을 수 없습니다",
+  "noCompatibleAssetManual": "현재 시스템 아키텍처에 맞는 패키지가 없습니다. Releases 페이지에서 수동으로 다운로드하세요.",
+  "goToRelease": "Releases 열기",
   "downloadCompleteTitle": "다운로드 완료",
   "readyToInstall": "설치 준비 완료",
   "readyToInstallDesc": "업데이트가 다운로드되었습니다. 아래 버튼을 클릭하여 재시작하고 업데이트를 설치하세요.",