[patch] work with mas update pipeline

Author: anilprajapatiibm

bin/mas-devops-notify-slack

@@ -99,10 +99,12 @@ def notifyProvisionRoks(channels: list[str], rc: int, additionalMsg: str | None
 
 def notifyPipelineStart(channels: list[str], instanceId: str | None = None, pipelineName: str | None = None) -> dict | None:
     """Send Slack notification about pipeline start and create thread for all channels."""
-    namespace = f"mas-{instanceId}-pipelines"
+    # For update pipeline, use mas-pipelines namespace (no instance ID)
+    # For install/upgrade pipelines, use mas-{instanceId}-pipelines namespace
     if instanceId is None or instanceId == "":
-        print("instanceId must be set")
-        sys.exit(1)
+        namespace = "mas-pipelines"
+    else:
+        namespace = f"mas-{instanceId}-pipelines"
 
     # Check if thread already exists
     threadInfo = SlackUtil.getThreadConfigMap(namespace, instanceId, pipelineName)
@@ -152,10 +154,12 @@ def notifyPipelineStart(channels: list[str], instanceId: str | None = None, pipe
 
 def notifyAnsibleStart(channels: list[str], taskName: str, instanceId: str | None = None, pipelineName: str | None = None) -> bool:
     """Send Slack notification about Ansible task start to all channels."""
-    namespace = f"mas-{instanceId}-pipelines"
+    # For update pipeline, use mas-pipelines namespace (no instance ID)
+    # For install/upgrade pipelines, use mas-{instanceId}-pipelines namespace
     if instanceId is None or instanceId == "":
-        print("instanceId must be set")
-        sys.exit(1)
+        namespace = "mas-pipelines"
+    else:
+        namespace = f"mas-{instanceId}-pipelines"
 
     # Get thread information, create if doesn't exist
     threadInfo = SlackUtil.getThreadConfigMap(namespace, instanceId, pipelineName)
@@ -204,10 +208,12 @@ def notifyAnsibleStart(channels: list[str], taskName: str, instanceId: str | Non
 
 def notifyAnsibleComplete(channels: list[str], rc: int, taskName: str, instanceId: str | None = None, pipelineName: str | None = None) -> bool:
     """Send Slack notification about Ansible task completion status to all channels."""
-    namespace = f"mas-{instanceId}-pipelines"
+    # For update pipeline, use mas-pipelines namespace (no instance ID)
+    # For install/upgrade pipelines, use mas-{instanceId}-pipelines namespace
     if instanceId is None or instanceId == "":
-        print("instanceId must be set")
-        sys.exit(1)
+        namespace = "mas-pipelines"
+    else:
+        namespace = f"mas-{instanceId}-pipelines"
 
     # Get thread information, create if doesn't exist
     threadInfo = SlackUtil.getThreadConfigMap(namespace, instanceId, pipelineName)
@@ -287,10 +293,12 @@ def notifyAnsibleComplete(channels: list[str], rc: int, taskName: str, instanceI
 
 def notifyPipelineComplete(channels: list[str], rc: int, instanceId: str | None = None, pipelineName: str | None = None) -> bool:
     """Send Slack notification about pipeline completion to all channels and cleanup ConfigMap."""
-    namespace = f"mas-{instanceId}-pipelines"
+    # For update pipeline, use mas-pipelines namespace (no instance ID)
+    # For install/upgrade pipelines, use mas-{instanceId}-pipelines namespace
     if instanceId is None or instanceId == "":
-        print("instanceId must be set")
-        sys.exit(1)
+        namespace = "mas-pipelines"
+    else:
+        namespace = f"mas-{instanceId}-pipelines"
 
     # Get thread information
     threadInfo = SlackUtil.getThreadConfigMap(namespace, instanceId, pipelineName)

src/mas/devops/slack.py

@@ -279,7 +279,7 @@ def createThreadConfigMap(cls, namespace: str, instanceId: str, pipelineRunName:
             namespace (str): Kubernetes namespace for the ConfigMap
             channelId (str): Slack channel ID where the thread was created
             threadId (str): Slack thread timestamp
-            instanceId (str): Name of the Mas Instance ID
+            instanceId (str): Name of the Mas Instance ID (can be None or empty for update pipeline)
 
         Returns:
             bool: True if ConfigMap was created successfully, False otherwise
@@ -291,7 +291,9 @@ def createThreadConfigMap(cls, namespace: str, instanceId: str, pipelineRunName:
             except Exception:
                 config.load_kube_config()
             v1 = client.CoreV1Api()
-            configmap_name = f"slack-thread-{instanceId}-{pipelineRunName}"
+            # For update pipeline (no instance ID), use "update" as identifier
+            instance_identifier = instanceId if instanceId else "update"
+            configmap_name = f"slack-thread-{instance_identifier}-{pipelineRunName}"
             configmap = client.V1ConfigMap(
                 metadata=client.V1ObjectMeta(
                     name=configmap_name,
@@ -316,7 +318,7 @@ def getThreadConfigMap(cls, namespace: str, instanceId: str, pipelineRunName: st
 
         Parameters:
             namespace (str): Kubernetes namespace containing the ConfigMap
-            instanceId (str): Unique identifier for the pipeline run
+            instanceId (str): Unique identifier for the pipeline run (can be None or empty for update pipeline)
 
         Returns:
             dict | None: Dictionary containing threadId, channelId, pipelineName, and startTime, or None if not found
@@ -328,7 +330,9 @@ def getThreadConfigMap(cls, namespace: str, instanceId: str, pipelineRunName: st
             except Exception:
                 config.load_kube_config()
             v1 = client.CoreV1Api()
-            configmap_name = f"slack-thread-{instanceId}-{pipelineRunName}"
+            # For update pipeline (no instance ID), use "update" as identifier
+            instance_identifier = instanceId if instanceId else "update"
+            configmap_name = f"slack-thread-{instance_identifier}-{pipelineRunName}"
             configmap = v1.read_namespaced_config_map(name=configmap_name, namespace=namespace)
             logger.debug(f"Retrieved ConfigMap {configmap_name} from namespace {namespace}")
             return configmap.data
@@ -348,7 +352,7 @@ def updateThreadConfigMap(cls, namespace: str, instanceId: str, updates: dict, p
 
         Parameters:
             namespace (str): Kubernetes namespace containing the ConfigMap
-            instanceId (str): Unique identifier for the pipeline run
+            instanceId (str): Unique identifier for the pipeline run (can be None or empty for update pipeline)
             updates (dict): Dictionary of key-value pairs to add/update in the ConfigMap
 
         Returns:
@@ -361,7 +365,9 @@ def updateThreadConfigMap(cls, namespace: str, instanceId: str, updates: dict, p
             except Exception:
                 config.load_kube_config()
             v1 = client.CoreV1Api()
-            configmap_name = f"slack-thread-{instanceId}-{pipelineRunName}"
+            # For update pipeline (no instance ID), use "update" as identifier
+            instance_identifier = instanceId if instanceId else "update"
+            configmap_name = f"slack-thread-{instance_identifier}-{pipelineRunName}"
 
             # Get existing ConfigMap
             configmap = v1.read_namespaced_config_map(name=configmap_name, namespace=namespace)
@@ -385,6 +391,7 @@ def deleteThreadConfigMap(cls, namespace: str, instanceId: str, pipelineRunName:
 
         Parameters:
             namespace (str): Kubernetes namespace containing the ConfigMap
+            instanceId (str): Unique identifier for the pipeline run (can be None or empty for update pipeline)
             pipelineRunName (str): Unique identifier for the pipeline run
 
         Returns:
@@ -398,7 +405,9 @@ def deleteThreadConfigMap(cls, namespace: str, instanceId: str, pipelineRunName:
                 config.load_kube_config()
 
             v1 = client.CoreV1Api()
-            configmap_name = f"slack-thread-{instanceId}-{pipelineRunName}"
+            # For update pipeline (no instance ID), use "update" as identifier
+            instance_identifier = instanceId if instanceId else "update"
+            configmap_name = f"slack-thread-{instance_identifier}-{pipelineRunName}"
             v1.delete_namespaced_config_map(name=configmap_name, namespace=namespace)
             logger.info(f"Deleted ConfigMap {configmap_name} from namespace {namespace}")
             return True