Now creating solution-wide formatting options container correctly. Added "Code Formatting" option tab to project properties view.

Author: Rpinski

src/AddIns/BackendBindings/CSharpBinding/Project/CSharpBinding.addin

@@ -119,6 +119,10 @@
 		             label = "${res:Dialog.ProjectOptions.Publish}"
 		             class = "ICSharpCode.SharpDevelop.Gui.OptionPanels.Publish"/>-->
 		<Include id = "AllManaged" path="/SharpDevelop/BackendBindings/ProjectOptions/AllManaged"/>
+		<!-- TODO Localize label! -->
+		<OptionPanel id    = "CSharpProjectFormattingOptions"
+		             label = "Code Formatting"
+		             class = "CSharpBinding.OptionPanels.CSharpProjectFormattingOptionPanel"/>
 	</Path>
 
 	<Path name = "/Workspace/Icons">
@@ -497,4 +501,10 @@
 		                class = "CSharpBinding.FormsDesigner.FormsDesignerSecondaryDisplayBinding"
 		                fileNamePattern = "\.cs$"/>
 	</Path>
+	
+	<!-- Autostart command for initialization -->
+	<Path name = "/SharpDevelop/Autostart">
+		<Class id    = "CSharpFormattingOptionsPersistenceInitCommand"
+		       class = "CSharpBinding.FormattingStrategy.CSharpFormattingOptionsPersistenceInitCommand"/>
+	</Path>
 </AddIn>

src/AddIns/BackendBindings/CSharpBinding/Project/Src/FormattingStrategy/CSharpFormattingOptionsPersistence.cs

@@ -25,14 +25,23 @@
 
 namespace CSharpBinding.FormattingStrategy
 {
+	public class CSharpFormattingOptionsPersistenceInitCommand : SimpleCommand
+	{
+		public override void Execute(object parameter)
+		{
+			// Initialize CSharpFormattingOptionsPersistence as early as possible (before solution is opened)
+			CSharpFormattingOptionsPersistence.Initialize();
+		}
+	}
+	
 	/// <summary>
 	/// Persistence helper for C# formatting options.
 	/// </summary>
 	internal class CSharpFormattingOptionsPersistence
 	{
 		static Dictionary<string, CSharpFormattingOptionsPersistence> projectOptions;
 
-		static CSharpFormattingOptionsPersistence()
+		public static void Initialize()
 		{
 			projectOptions = new Dictionary<string, CSharpFormattingOptionsPersistence>();
 
@@ -64,10 +73,10 @@ public static CSharpFormattingOptionsPersistence GetProjectOptions(IProject proj
 			if (csproject != null) {
 				string key = project.FileName;
 				if (!projectOptions.ContainsKey(key)) {
-					// Lazily create options container
+					// Lazily create options container for project
 					projectOptions[key] = new CSharpFormattingOptionsPersistence(
 						csproject.ExtensionProperties,
-						new CSharpFormattingOptionsContainer((SolutionOptions ?? GlobalOptions).OptionsContainer)); // HACK!
+						new CSharpFormattingOptionsContainer((SolutionOptions ?? GlobalOptions).OptionsContainer));
 				}
 
 				return projectOptions[key];

src/AddIns/BackendBindings/CSharpBinding/Project/Src/OptionPanels/CSharpProjectFormattingOptions.xaml.cs

@@ -45,16 +45,26 @@ public CSharpProjectFormattingOptionPanel()
 		protected override void Load(ICSharpCode.SharpDevelop.Project.MSBuildBasedProject project, string configuration, string platform)
 		{
 			base.Load(project, configuration, platform);
+			if (persistenceHelper != null) {
+				persistenceHelper.OptionsContainer.PropertyChanged -= ContainerPropertyChanged;
+			}
 			persistenceHelper = CSharpFormattingOptionsPersistence.GetProjectOptions(project);
 			formattingEditor.OptionsContainer = persistenceHelper.OptionsContainer;
 			formattingEditor.AllowPresets = true;
 			persistenceHelper.Load();
+			persistenceHelper.OptionsContainer.PropertyChanged += ContainerPropertyChanged;
 		}
 
 		protected override bool Save(ICSharpCode.SharpDevelop.Project.MSBuildBasedProject project, string configuration, string platform)
 		{
 			bool success = (persistenceHelper != null) && persistenceHelper.Save();
 			return base.Save(project, configuration, platform) && success;
 		}
+
+		void ContainerPropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
+		{
+			// A formatting option has been changed, mark project settings as dirty
+			this.IsDirty = true;
+		}
 	}
 }

src/Main/Base/Project/Src/Project/AbstractProject.cs

@@ -59,7 +59,6 @@ protected AbstractProject(ProjectInformation information)
 			this.configurationMapping = information.ConfigurationMapping ?? new ConfigurationMapping();
 			this.Name = information.ProjectName;
 			this.FileName = information.FileName;
-			this.globalPreferencesFileName = new FileName(fileName + ".sdsettings");
 			this.idGuid = (information.IdGuid != Guid.Empty ? information.IdGuid : Guid.NewGuid());
 			this.TypeGuid = information.TypeGuid;
 			if (information.ProjectSections != null)
@@ -115,28 +114,6 @@ public Properties Preferences {
 			}
 		}
 
-		Properties globalPreferences = new Properties();
-		
-		public Properties GlobalPreferences {
-			get {
-				lock (syncRoot) {
-					if (globalPreferences == null) {
-						globalPreferences = new Properties(); // in case of errors, use empty properties container
-						if (FileUtility.IsValidPath(globalPreferencesFileName) && File.Exists(globalPreferencesFileName)) {
-							try {
-								globalPreferences = Properties.Load(globalPreferencesFileName);
-							} catch (IOException) {
-							} catch (UnauthorizedAccessException) {
-							} catch (XmlException) {
-								// ignore errors about inaccessible or malformed files
-							}
-						}
-					}
-					return globalPreferences;
-				}
-			}
-		}
-		
 		static FileName GetPreferenceFileName(string projectFileName)
 		{
 			string directory = Path.Combine(PropertyService.ConfigDirectory, "preferences");
@@ -154,7 +131,6 @@ public void SavePreferences()
 				FileName preferencesFile = GetPreferenceFileName(fileName);
 				System.IO.Directory.CreateDirectory(preferencesFile.GetParentDirectory());
 				p.Save(preferencesFile);
-				this.GlobalPreferences.Save(globalPreferencesFileName);
 			} catch (IOException) {
 			} catch (UnauthorizedAccessException) {
 			}
@@ -163,7 +139,6 @@ public void SavePreferences()
 
 		#region Filename / Directory
 		volatile FileName fileName;
-		volatile FileName globalPreferencesFileName;
 		volatile DirectoryName directoryName;
 		protected IProjectChangeWatcher watcher;