GotoDialog and CodeCompletion-window: Fix window being closed when double-clicking the list's scroll bar.

Author: dgrunwald

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/CodeCompletion/CompletionList.cs

@@ -26,6 +26,7 @@
 using System.Windows.Documents;
 using System.Windows.Input;
 using System.Linq;
+using ICSharpCode.AvalonEdit.Utils;
 
 namespace ICSharpCode.AvalonEdit.CodeCompletion
 {
@@ -180,8 +181,11 @@ protected override void OnMouseDoubleClick(MouseButtonEventArgs e)
 		{
 			base.OnMouseDoubleClick(e);
 			if (e.ChangedButton == MouseButton.Left) {
-				e.Handled = true;
-				RequestInsertion(e);
+				// only process double clicks on the ListBoxItems, not on the scroll bar
+				if (ExtensionMethods.VisualAncestorsAndSelf(e.OriginalSource as DependencyObject).TakeWhile(obj => obj != this).Any(obj => obj is ListBoxItem)) {
+					e.Handled = true;
+					RequestInsertion(e);
+				}
 			}
 		}
 

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Utils/ExtensionMethods.cs

@@ -209,6 +209,14 @@ public static Rect ToWpf(this System.Drawing.Rectangle rect)
 		}
 		#endregion
 
+		public static IEnumerable<DependencyObject> VisualAncestorsAndSelf(this DependencyObject obj)
+		{
+			while (obj != null) {
+				yield return obj;
+				obj = VisualTreeHelper.GetParent(obj);
+			}
+		}
+		
 		[Conditional("DEBUG")]
 		public static void CheckIsFrozen(Freezable f)
 		{

src/Main/Base/Project/Src/Gui/Dialogs/GotoDialog.cs

@@ -459,6 +459,13 @@ void okButtonClick(object sender, RoutedEventArgs e)
 				Close();
 			}
 		}
+		
+		void ListItem_MouseLeftButtonDown(object sender, System.Windows.Input.MouseButtonEventArgs e)
+		{
+			if (e.ClickCount == 2) {
+				okButtonClick(sender, e);
+			}
+		}
 	}
 
 	public class GotoUtils

src/Main/Base/Project/Src/Gui/Dialogs/GotoDialog.xaml

@@ -46,11 +46,10 @@
 			HorizontalAlignment="Stretch"
 			VerticalAlignment="Stretch"
 			Margin="8,4,8,4"
-			Name="listBox"
-			MouseDoubleClick="okButtonClick">
+			Name="listBox">
 			<ListBox.ItemTemplate>
 				<DataTemplate>
-					<StackPanel Orientation="Horizontal">
+					<StackPanel Orientation="Horizontal" MouseLeftButtonDown="ListItem_MouseLeftButtonDown">
 						<Image Source="{Binding ImageSource}" Style="{StaticResource ListItemImageStyle}"/>
 						<TextBlock Text="{Binding Text}" Margin="4,0,0,0" Style="{StaticResource ListItemTextStyle}"/>
 					</StackPanel>