Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Commit 56b3d62

Browse files
committed
Prevent updating to unpublished/unlisted NuGet packages.
Update-Package was updating to unpublished/unlisted NuGet packages.
1 parent 5da6791 commit 56b3d62

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

src/AddIns/Misc/PackageManagement/Project/Src/ProcessPackageAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ void FindPackage()
136136
{
137137
Package = Project
138138
.SourceRepository
139-
.FindPackage(PackageId, PackageVersion, AllowPrereleaseVersions, allowUnlisted: true);
139+
.FindPackage(PackageId, PackageVersion, AllowPrereleaseVersions, allowUnlisted: false);
140140
}
141141

142142
void ThrowPackageNotFoundError(string packageId)

src/AddIns/Misc/PackageManagement/Test/Src/InstallPackageActionTests.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,13 +385,27 @@ public void Execute_InstallUnlistedPackage_InstallsPackageIntoProject()
385385
FakePackage expectedPackage = fakeProject.FakeSourceRepository.AddFakePackageWithVersion("test", "1.0");
386386
expectedPackage.Listed = false;
387387
action.PackageId = "test";
388+
action.PackageVersion = new SemanticVersion("1.0");
388389

389390
action.Execute();
390391

391392
IPackage actualPackage = fakeProject.PackagePassedToInstallPackage;
392393
Assert.AreEqual(expectedPackage, actualPackage);
393394
}
394395

396+
[Test]
397+
public void Execute_InstallUnlistedPackageWithoutVersion_DoesNotInstallPackageIntoProject()
398+
{
399+
CreateAction();
400+
FakePackage expectedPackage = fakeProject.FakeSourceRepository.AddFakePackageWithVersion("test", "1.0");
401+
expectedPackage.Listed = false;
402+
action.PackageId = "test";
403+
404+
Exception ex = Assert.Throws(typeof(ApplicationException), () => action.Execute());
405+
406+
Assert.AreEqual("Unable to find package 'test'.", ex.Message);
407+
}
408+
395409
[Test]
396410
public void Execute_PackageIdSpecifiedButDoesNotExistInRepository_ExceptionThrown()
397411
{

0 commit comments

Comments
 (0)